From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk0-x236.google.com (mail-vk0-x236.google.com [IPv6:2607:f8b0:400c:c05::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1458B21E74933 for ; Wed, 6 Sep 2017 18:39:33 -0700 (PDT) Received: by mail-vk0-x236.google.com with SMTP id o22so14499473vke.1 for ; Wed, 06 Sep 2017 18:42:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=iXDxs/Fvz1bP+T6//0NkgtAMPZRlAooROAgfW2009sQ=; b=azWZLqgb7mlU4RXdJOQd8KxFo5GcP8k7T4UA82pa5Wk4qlsEgp8FevhGpIc019vs3L gbuSz7nb2bK78rWi5oHWkECSljvX6dsFAjKW0GaQXOQulNlTHSLpKwITJ2g0eL6mJHIl 8LxLOg3LlJoLr3Fjg3sW4VstBp26SXII83wvixVlqWSuVWoZwoua/dW19XNf5LHgN0XK xENdlBoWxDyemhLstEhw7ki8/o4wQu/UHc2ZFtv2s061R7nQXQrTzAiveroc11PA8K+h P3VTOxq4kFeVRR9RZuiifGGlV+l5LZ9hEmmNLl4nmtmb6JXASoz/xVbf0oRTssLe4Iwo Ez9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=iXDxs/Fvz1bP+T6//0NkgtAMPZRlAooROAgfW2009sQ=; b=kh9ZGjD4605sB//ChJeZEJ+bwQ95MgoJBzicpfQCrB/9wZARjAWYIkOgOkK+zAdBZV BHGuOaX2xjJk8YJCke4b2cmNa3HHFqmPm+nSI2TB6o0ASkjTohn5rvyLxUinPqYGYIpk au6q492wylvFJougntDA9lS3H/UuuRT9Ma3tazKkNwGWwWu2qU4akgpA+0ltgTCW9DJV T0+Owzpm0SG8E/kTvE97Niigxlu7/BX2XHEKhBjOKshO0CXyvCJanrWqk1iOpIoy+Euh fqP6kVeGft4HKCa/0xLCVYd1SQb3cQcVadT80ZxwwcHoJimTZYI586iWHdZyOjEMQIFd O75w== X-Gm-Message-State: AHPjjUi0BR8PvywLrLTQDDjnVwmJE7e8kLtt44K9+SVs6gD/ZRPMhVKU 1/6oTOho2IniP5EYtt2xv4r4ppRUXw== X-Google-Smtp-Source: ADKCNb4fleVMG0xfoWBZ3fw1dt2jOpeX2smv7DCiemIgtWIIKbFTiWJQibnCSUTxPz8kkZKFLHU1cqSZhNvsIoa1J6k= X-Received: by 10.31.3.17 with SMTP id 17mr574447vkd.82.1504748542495; Wed, 06 Sep 2017 18:42:22 -0700 (PDT) MIME-Version: 1.0 Received: by 10.176.72.81 with HTTP; Wed, 6 Sep 2017 18:42:01 -0700 (PDT) In-Reply-To: <20170905180306.53vfwarlt7tjbtlo@bivouac.eciton.net> References: <20170903021214.11516-1-ge.song@hxt-semitech.com> <20170903021214.11516-2-ge.song@hxt-semitech.com> <150453207055.10722.7097788282280420028@jljusten-skl> <7db5728c-a901-012e-0584-99c4b10d988e@gmail.com> <711fe92e-7b15-e349-b853-65b07315053e@redhat.com> <150463355735.10253.17993674709751476963@jljusten-skl.jf.intel.com> <20170905180306.53vfwarlt7tjbtlo@bivouac.eciton.net> From: Songge Date: Thu, 7 Sep 2017 09:42:01 +0800 Message-ID: To: Leif Lindholm Cc: Jordan Justen , Laszlo Ersek , edk2-devel@lists.01.org, Ard Biesheuvel , "Kinney, Michael D" , Andrew Fish X-Content-Filtered-By: Mailman/MimeDel 2.1.22 Subject: Re: [PATCH v1 1/1] OvmfPkg/SecMain: Fix stack switching to permanent memory fail X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Sep 2017 01:39:33 -0000 Content-Type: text/plain; charset="UTF-8" 2017-09-06 2:03 GMT+08:00 Leif Lindholm : > On Tue, Sep 05, 2017 at 10:45:57AM -0700, Jordan Justen wrote: > > On 2017-09-04 14:25:48, Laszlo Ersek wrote: > > > On 09/04/17 17:11, Ge Song wrote: > > > > On 09/04/2017 09:34 PM, Jordan Justen wrote: > > > > > > > >> On 2017-09-03 16:55:36, Laszlo Ersek wrote: > > > >>> On 09/03/17 04:12, Ge Song wrote: > > > >>>> In earlier PEI stage, temporary memory(Cache As Ram) is employed > as > > > >>>> stack > > > >>>> and heap. We move them to the new room and do some relocation > fixup > > > >>>> when > > > >>>> permanent memory becomes available. TemporaryRamMigration() > > > >>>> is responsible for switching the stack. > > > >>> [...] > > > >>> > > > >>>> Cc: Jordan Justen > > > >>>> Cc: Laszlo Ersek > > > >>>> Cc: Ard Biesheuvel > > > >>>> Contributed-under: TianoCore Contribution Agreement 1.1 > > > >>>> Signed-off-by: Ge Song > > > >>>> --- > > > >>>> OvmfPkg/Sec/SecMain.c | 2 ++ > > > >>>> 1 file changed, 2 insertions(+) > > > >>> (No more separate emails, I promise.) > > > >>> > > > >>> Before you send v2, can you please amend the patch like this: > > > >>> > > > >>> git commit --amend --author='Ge Song >' > > > >>> > > > >>> It's OK if you mail it out from another email address, but IMO the > git > > > >>> authorship should match the first Signed-off-by. > > > >> I disagree with this. Unless the individual is well known to the EDK > > > >> II community as the owner of both email addresses, I think the > author > > > >> needs to send it from their author email. > > > >> > > > >> I suppose they can send it from another email, and then reply from > > > >> their other email saying they contributed it under the Tianocore > > > >> Contribution Agreement, but that sounds like a stretch... > > > > > > I'm fine either way, as long as we can establish some kind of agreement > > > between (two of?) the three email addresses (sender, git author, > S-o-b). > > > > We've generally said they need to match. If it is a one-time > > contribution, then I think it is acceptable for the contributor to > > reply to the patch from the author's email saying: "This is me. I > > contributed it under the Tiancore Contribution Agreement" > > > > I think any change from this policy should be decided by the stewards. > > > > Regarding Ge Song's contribution, I think things are now even more > > complicated. It sounds like the contribution is being made by > > ge.song@hxt-semitech.com, but due to "IT issues" v2 is now being > > authored/sent from songgebird@gmail.com. > > > > Does hxt-semitech.com agree to this contribution? I think given that > > we know ge.song@hxt-semitech.com is the intended author, the patch > > should have ge.song@hxt-semitech.com as the author with > > ge.song@hxt-semitech.com in the Signed-off-by. > > > > Ideally it should be sent from ge.song@hxt-semitech.com, but if that > > is not possible, then ge.song@hxt-semitech.com should reply to the > > patch sent by songgebird@gmail.com re-iterating the > > Signed-off-by/Contributed-under is from ge.song@hxt-semitech.com. > > > > Ge Song, Can you send a v3 with the author reset to > > ge.song@hxt-semitech.com (see lersek's git commit command above) and > > the Signed-off-by using ge.song@hxt-semitech.com, and then reply to > > the patch posting from ge.song@hxt-semitech.com to re-iterate the > > Signed-off-by and Contributed-under? > > While obviously not an ideal situation, it is not the first time I > have come across this sort of issue. (And I doubt it will be the > last.) > > Your suggestion sounds like a good workaround. > For a series, a reply to the cover-letter should be sufficient. > > > > > OK, I'll try to send it from the same email address next time, the > reason > > > > that using two different mail addresses is because the author email > is an > > > > exchange account and it's hard to find the mail server preferences > for > > > > git-send-email... > > > > Sorry for the hassle, but maybe if you are able to work with your IT > > department to setup git send-email then you'll be able to contribute > > to other open source project's easier from your > > ge.song@hxt-semitech.com email address. > > In my experience, getting IT departments on board with this sort of > thing can be very difficult. Clearly, it should be attempted. > > Since hxt-semtech.com is a Linaro member, I will try to raise the > importance of getting this situation resolved internally. > > / > Leif > I have raised the problem to our IT department, As Leif said, this supposed to be a tough process, hope they can solve it finally Thanks to Jordan for the great solution. And this discussion made me gain a deep understanding of stewards, thank you everyone -- Best Regards, Songge