From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) by mx.groups.io with SMTP id smtpd.web10.1247.1600895663265502967 for ; Wed, 23 Sep 2020 14:14:23 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@corthon-com.20150623.gappssmtp.com header.s=20150623 header.b=IWE8wnXJ; spf=none, err=permanent DNS error (domain: corthon.com, ip: 209.85.218.43, mailfrom: bret@corthon.com) Received: by mail-ej1-f43.google.com with SMTP id z23so1490158ejr.13 for ; Wed, 23 Sep 2020 14:14:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corthon-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=44S/86LeTaeYRuX+HSu5pgFILYs3rkBRXm7sx1pdLF4=; b=IWE8wnXJJ1eV5kXE+ohUoUvdNpqa1VbvZawWGdOzTT0soLX0bhQbBlK6JCYC5pZlUd JYfK1LI2DtgpXqM128nTw5y05++R/0aGkhLpNViqCXkpjnRKstvBvZtYWMU6xmbvFMq9 UhqgrtS8ikplEX5YUcES63CG8FR7frgqWx/NLyy85H1r3/kKUyKH+BTPF1gW0mQcCgJQ FKeXm2ZXVf/bYsi9l1DMdlIG713+DTzJGC6VK/v8MKjnirxA+/zYUEBnpG1e+2sIf8+T CfmSl1/BAYAU8TWQDgRLuiUZJnpmOSq68C+iWuP8nF9eaYHI3PZcUQFxXJRWz53vWpRY Nt1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=44S/86LeTaeYRuX+HSu5pgFILYs3rkBRXm7sx1pdLF4=; b=okhlbpDiKVDzIhYDSsbpWTbMSZg4ME3PKXH5heAMIt22SxUfG1fAKnbCHgGKGxnvjr F0iems/eusKTtD5Az6r5g7ig6EZDHxmPUymgE4kgBseGUcSCxyCycZF/ozuOOwMHWOe2 wKCasfqJ4c/uHm49U9784Ao4MXDV9CzKfnhKD1fmsu8KIw7JhdTRuJUkaqE1jqLCnYBS UGtjxWvb+Ceht2T8qYQ+p/qxj+j1/8lXyk2JTp4liuGTlFpc5f+eTtOLuQlK2JS1FVcs k1GGBdpDDjdiqicxeQF8fy9zQs5CIKG9qEB0Wbr5Uv1ZXzvQOELoTTHa+Fkn5H4nWBXk +gvw== X-Gm-Message-State: AOAM530uhXzxReCz0cuucu+H41r6MRpsv5pITN3PvxCvg0TGQsn/0J20 sgFSWXgHa7IJcXqBPjGmNXV3cXA+3BG72O3DMdjJUA== X-Google-Smtp-Source: ABdhPJwq3OTJa89+SHCOEdixCMGFEFfAW0MJ9OwMtdpYJ28twrdvLWW9u5fIVXYBaAoR1PD5XRbDV7UIR+hKvxCmlBA= X-Received: by 2002:a17:906:441:: with SMTP id e1mr1497899eja.396.1600895661709; Wed, 23 Sep 2020 14:14:21 -0700 (PDT) MIME-Version: 1.0 References: <20200923060748.3795-1-bret.barkelew@microsoft.com> In-Reply-To: From: "Bret Barkelew" Date: Wed, 23 Sep 2020 14:14:09 -0700 Message-ID: Subject: Re: [edk2-devel] [EXTERNAL] [PATCH v8 00/14] Add the VariablePolicy feature To: Laszlo Ersek Cc: devel@edk2.groups.io, Bret Barkelew , "Yao, Jiewen" , Dandan Bi , Chao Zhang , Jian J Wang , Hao A Wu , "liming.gao" , Jordan Justen , Ard Biesheuvel , Andrew Fish , "Ni, Ray" Content-Type: multipart/alternative; boundary="0000000000003d39b905b001919a" --0000000000003d39b905b001919a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable As far as I can tell, this is exposing a pre-existing race condition in EndOfDxe. It just so HAPPENS that the old "Disable RequestToLock" callback executed after this TcgMor callback, whereas the new VariablePolicy callback executes first. I'm going to poke around for a solution, but this seems like an architectural problem with EndOfDxe. On Wed, Sep 23, 2020 at 6:02 AM Laszlo Ersek wrote: > Hi Bret, > > On 09/23/20 08:12, Bret Barkelew via groups.io wrote: > > To whom it may concern, > > This is as done as it=C3=A2=E2=82=AC=E2=84=A2s going to get. > > > > Thank you all for your help! > > I tried to merge this via , > but it failed. Please review the build report, and submit v9 if necessary= . > > Thanks! > Laszlo > > --0000000000003d39b905b001919a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
As far as I can tell, this is exposing a pre-existing race= condition in EndOfDxe. It just so HAPPENS that the old "Disable=C2=A0= RequestToLock" callback=C2=A0executed after this TcgMor callback, wher= eas the new VariablePolicy callback executes first.

I= 9;m going to poke around for a solution, but this seems like an architectur= al problem with EndOfDxe.

On Wed, Sep 23, 2020 at 6:02 AM Laszlo Ersek= <lersek@redhat.com> wrote:<= br>
Hi Bret,

On 09/23/20 08:12, Bret Barkelew via groups.io wrote:
> To whom it may concern,
> This is as done as it=C3=A2=E2=82=AC=E2=84=A2s going to get.
>
> Thank you all for your help!

I tried to merge this via <https://github.com/tianocore= /edk2/pull/954>,
but it failed. Please review the build report, and submit v9 if necessary.<= br>
Thanks!
Laszlo

--0000000000003d39b905b001919a--