From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) by mx.groups.io with SMTP id smtpd.web11.1658.1600896873896774596 for ; Wed, 23 Sep 2020 14:34:34 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@corthon-com.20150623.gappssmtp.com header.s=20150623 header.b=Tyahy4cj; spf=none, err=permanent DNS error (domain: corthon.com, ip: 209.85.218.51, mailfrom: bret@corthon.com) Received: by mail-ej1-f51.google.com with SMTP id j11so1684371ejk.0 for ; Wed, 23 Sep 2020 14:34:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corthon-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=X9XtgqQkM2U5aWIWY7i/l4vM3kt65Vkf2CFGf1LU1ns=; b=Tyahy4cjbSBFbgmZb5I/8qInwjifjylEPpHVapwhT6VZhdeENgjmJqOBNxe6XvEqIX 6eLrI7aAAvme72D+Rc3LoavYwm0H81ysOK+CtxbEzhU4hb1cGLe0wV8y+GLabCGnkIxR r4NknVtvV5aqv5+2EF2OGRxtkrHIj0KpUFTVgVCoJt2PUEgISITXU+UqcD8yDiQ33FE4 kXZ4AsX7y0YL+HFa6zzEF/aitUI2Mo4ktotBaZKNR0sJllEHja92V5HsJ2Z/8kV9m8Fp B/OkXzfrTVY2FqFK96YHCqTuCwgX9n7xFMBEpOQ9bpe8FnzckvsjBJrxzilT7iUohLfd gjGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=X9XtgqQkM2U5aWIWY7i/l4vM3kt65Vkf2CFGf1LU1ns=; b=OGY6g8GdWfUT5M1zPSUv9/yjIDFCescPh7SoYMzhWCSZmF0oOkUJniVJIDnBlqHcBs Pfmy9Zq9UWQPZ/c0XYHLf/zgNoTANsS5lGCkCi9WAlfnAHys5/annQK4mpxQypfB5XlP 4RP6CCf8w7TdEJeT/oO+vMXhJupe10brl45/9cCGAzZEwDUTfvp3lFfT8lzUv/oX+Ahd esBCOW9gMz3EIR9G85VRbz0++EsKpiswDsY6hkjipaX5r6J+Z7xVPAmmUw0UJ/FBYqzg 8YqyeYupqBp9coBLeNIarNIreGfJFYj6+8MYhJdtSw510b18vWEXqADx5280yz6Qo8Cv kSaA== X-Gm-Message-State: AOAM532Pw5Retydv9h5PGj2xfjxhKbVzwVDmduL1A/1wcpDPml8yCVzw TeNfXbOVaYYflQTHsjX/x2XWZHDYsF5ojUBPfqTZDg== X-Google-Smtp-Source: ABdhPJwA28/YJDs26eShszI4qoiw64BZEy891YWncna2V3dYwPtlbvr/rOak4ukpoQ3NJ3wqtYmkUS6u1xQVzhmPQCo= X-Received: by 2002:a17:906:b756:: with SMTP id fx22mr1524429ejb.245.1600896872077; Wed, 23 Sep 2020 14:34:32 -0700 (PDT) MIME-Version: 1.0 References: <20200923060748.3795-1-bret.barkelew@microsoft.com> In-Reply-To: From: "Bret Barkelew" Date: Wed, 23 Sep 2020 14:34:19 -0700 Message-ID: Subject: Re: [edk2-devel] [EXTERNAL] [PATCH v8 00/14] Add the VariablePolicy feature To: Andrew Fish Cc: edk2-devel-groups-io , Laszlo Ersek , Bret Barkelew , "Yao, Jiewen" , Dandan Bi , Chao Zhang , Jian J Wang , Hao A Wu , "liming.gao" , Jordan Justen , Ard Biesheuvel , "Ni, Ray" Content-Type: multipart/alternative; boundary="00000000000062008605b001d912" --00000000000062008605b001d912 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Agreed. It's random that the previous config worked. On Wed, Sep 23, 2020 at 2:32 PM Andrew Fish wrote: > > > On Sep 23, 2020, at 2:14 PM, Bret Barkelew wrote: > > As far as I can tell, this is exposing a pre-existing race condition in > EndOfDxe. It just so HAPPENS that the old "Disable RequestToLock" > callback executed after this TcgMor callback, whereas the new > VariablePolicy callback executes first. > > I'm going to poke around for a solution, but this seems like an > architectural problem with EndOfDxe. > > > The architecture does not guarantee order for the events. So if the even= ts > are dependent on the order of other events that is a bug in implementati= on. > These kind of bugs are hard to notice as the DXE Core implementation eve= nt > dispatch in a fixed order, I think in the order the event was registered= . > So it looks correct until you add more events. > > Thanks, > > Andrew Fish > > On Wed, Sep 23, 2020 at 6:02 AM Laszlo Ersek wrote: > >> Hi Bret, >> >> On 09/23/20 08:12, Bret Barkelew via groups.io wrote: >> > To whom it may concern, >> > This is as done as it=C3=A2=E2=82=AC=E2=84=A2s going to get. >> > >> > Thank you all for your help! >> >> I tried to merge this via , >> but it failed. Please review the build report, and submit v9 if necessa= ry. >> >> Thanks! >> Laszlo >> >>=20 > > > --00000000000062008605b001d912 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Agreed. It's random that the previous config worked.
On= Wed, Sep 23, 2020 at 2:32 PM Andrew Fish <afish@apple.com> wrote:

On Sep 23, 2020, at 2:14 PM, Bret Barkelew = <bret@corthon.com<= /a>> wrote:

As far as I can tell, this is= exposing a pre-existing race condition in EndOfDxe. It just so HAPPENS tha= t the old "Disable=C2=A0RequestToLock" callback=C2=A0executed aft= er this TcgMor callback, whereas the new VariablePolicy callback executes f= irst.

I'm going to poke around for a solution, but t= his seems like an architectural problem with EndOfDxe.





<= div dir=3D"ltr" class=3D"gmail_attr">On Wed, Sep 23, 2020 at 6:02 AM Laszlo= Ersek <lersek@re= dhat.com> wrote:
Hi Bret,

On 09/23/20 08:12, Bret Barkelew via groups.io wrote:
> To whom it may concern,
> This is as done as it=C3=A2=E2=82=AC=E2=84=A2s going to get.
>
> Thank you all for your help!

I tried to merge this via <https://github.com/tianocor= e/edk2/pull/954>,
but it failed. Please review the build report, and submit v9 if necessary.=

Thanks!
Laszlo


--00000000000062008605b001d912--