From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.25946.1669845109693244469 for ; Wed, 30 Nov 2022 13:51:50 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=J16IYPSs; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: osteffen@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669845108; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WDawGFdcXDG4QM9cDZf+V+HbTbEsuHiW6EOn1l26Qyk=; b=J16IYPSsT+1R4cNFO6GNzFD3VanLfXdxKMVFcn+ebxdyo+xkZAOY5vpl5389V6Geq819yr cvz54Vq9RMFeaMtDIDZa+ojcPkcCzhwxIj9Q9vVXj7iahmVWMt4lJ1UvHMPVWMV9Db17pM laoH5YM9GrPMVybZVPDx0VnfdxOk7SI= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-321-36ol77GeNle06mP_UwAYhQ-1; Wed, 30 Nov 2022 16:51:47 -0500 X-MC-Unique: 36ol77GeNle06mP_UwAYhQ-1 Received: by mail-lf1-f70.google.com with SMTP id r17-20020ac25a51000000b004b01305202dso6920978lfn.5 for ; Wed, 30 Nov 2022 13:51:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WDawGFdcXDG4QM9cDZf+V+HbTbEsuHiW6EOn1l26Qyk=; b=nKQyc6/Jhz7nNCypGDyFdZhfWZhl98fBOzUeoCTb6XqHmWkptDM2HLfnNuAjhWQeLK BaEPywO95EOrfzlxd6auQ4y13oFmaVrEW/BaontbWk6kEIQGPbLHEE6ix/Xbll0UNyh9 DrTIAAxLeZZMY8QDtUvbIRQCl2j+4Tk/oOtoZi5eu3cy5qlOVFIbg/rLVBwDjAjRMiZ8 xM9LBz/hIc8sj+xs5HEb/Fy6c7wzINhfi5oHEMi0qrwtjQKafiXq4emSi1092RX/XoCs 89T95lYT1z/FReo1pcYa/P1+R1ags0mt0ge62EMRYER/RxfEgROpbK7fHYRVBSXjA1Cf RUCA== X-Gm-Message-State: ANoB5pm2QcMfqTCTw0+s/iPGkeroOKY48JSwOHN0KZyraMKd7RFr9Mqo XSFLby/YBJAU3mXdK86dUNhEBLqzKvdB7cKuVRcEIh15I4Cw0sX8j/8Nvbcn96FLGK+MpO9UEzr 5qvaQ06RrQQtjVJKWOC/jEuFfI3aWHQ== X-Received: by 2002:a19:ca55:0:b0:4b5:2ae5:d3bd with SMTP id h21-20020a19ca55000000b004b52ae5d3bdmr2589386lfj.46.1669845105234; Wed, 30 Nov 2022 13:51:45 -0800 (PST) X-Google-Smtp-Source: AA0mqf57O4feNRg5zjw2znj5KI37PMrV4IjFQd1ozVRZz1RJGAqDjv0cR/lNaP94BASTLgxP0F8q+LWVMgCSV3LGyTE= X-Received: by 2002:a19:ca55:0:b0:4b5:2ae5:d3bd with SMTP id h21-20020a19ca55000000b004b52ae5d3bdmr2589361lfj.46.1669845104923; Wed, 30 Nov 2022 13:51:44 -0800 (PST) MIME-Version: 1.0 References: <20221130200037.1098765-1-osteffen@redhat.com> In-Reply-To: From: "Oliver Steffen" Date: Wed, 30 Nov 2022 22:51:33 +0100 Message-ID: Subject: Re: [edk2-devel] [PATCH v8 10/12] CI: Don't install cspell To: Chris Fernald Cc: devel@edk2.groups.io, Andrew Fish , Ard Biesheuvel , Bob Feng , Daniel Schaefer , Gerd Hoffmann , Jiewen Yao , Jordan Justen , Leif Lindholm , Liming Gao , Michael D Kinney , Michael Kubacki , Ray Ni , Sami Mujawar , Sean Brogan , Sunil V L , Yuwei Chen , Zhiguang Liu , Pawel Polawski , Chris Fernald X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" On Wed, Nov 30, 2022 at 9:45 PM Chris Fernald wrote: > > I apologize as I think I mislead you on this. I think we can only remove > this operation for the builds using the container. I believe Windows > builds will still require this step for the time being. The Windows > pipeline on your PR is currently failing to find cspell. Sorry for not > being clear on this originally. No worries. Sorry for misunderstanding. I'll drop this patch for now. Don't have a simple and good way to skip this on Linux only. I also don't think this is too critical now, the install should not do much if cspell is already there. We can clean this up later, and track this in an issue / BZ. - Oliver > On 11/30/2022 12:01 PM, Oliver Steffen wrote: > > cspell is already included in the container image. > > > > Signed-off-by: Oliver Steffen > > --- > > .azurepipelines/templates/spell-check-prereq-steps.yml | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/.azurepipelines/templates/spell-check-prereq-steps.yml > > b/.azurepipelines/templates/spell-check-prereq-steps.yml > > index 226909d54c4e..66354ad78b5c 100644 > > --- a/.azurepipelines/templates/spell-check-prereq-steps.yml > > +++ b/.azurepipelines/templates/spell-check-prereq-steps.yml > > @@ -16,7 +16,3 @@ steps: > > versionSpec: '14.x' > > #checkLatest: false # Optional > > condition: and(gt(variables.pkg_count, 0), succeeded()) > > - > > -- script: npm install -g cspell@5.20.0 > > - displayName: 'Install cspell npm' > > - condition: and(gt(variables.pkg_count, 0), succeeded()) >