From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.19428.1669831965270428144 for ; Wed, 30 Nov 2022 10:12:45 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=f9DyP6UN; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: osteffen@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669831964; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4GENcenCrJ95uaWV8ms1oj9FftZLU2/HYVXio/DGAXc=; b=f9DyP6UNfYmTaNlR+vVz9hHNGybM+ddvxaNjFnQml2AhhHv4/QfbbfG6UIeTXqf12ERDkr lmTsVclWB+6CFVWAQnhZ2d9dGD5mA//t+WBQYHL6dXbSiX1pCjQNaFmDS22RYyk0s/7dSY wYDOBwA0a5yX1NpxXRLxh2ZgIHbfXn0= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-7-4e05wLFYPByYh74ekYdqKA-1; Wed, 30 Nov 2022 13:12:42 -0500 X-MC-Unique: 4e05wLFYPByYh74ekYdqKA-1 Received: by mail-lj1-f197.google.com with SMTP id w21-20020a05651c119500b002797c24427aso4162185ljo.4 for ; Wed, 30 Nov 2022 10:12:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:user-agent:from:references :in-reply-to:mime-version:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4GENcenCrJ95uaWV8ms1oj9FftZLU2/HYVXio/DGAXc=; b=kgRt9ZEDrI+om1nehJNRc1SOsEJSZoDXpR4D4KuJuRF2ASZdh6fm8JSxhpC6VbygY3 40seH+TC45HvS8SrBep6Wcq3fjGJ50t6cwunxmeUbmD1pY/g6ZImhyCq1EQ+Ly5Ftfip 9BiaZKmLparsJOEIL1S27n7gdDusHIaATetxvyjYRP1RUbhnaQNWuivDALCcoMXGdcM4 MLGPdRDJvB0DxdrKqc7gJKv4t8ylsICWUu4+2ptfK9tApqkaIqZC9LD02tMwjvPMgdsz rzkGsJ8Jt+H+RdskohUFV1e4wBCW49zmQ+atTFG9O1gX29gONXmAxfbtkAvbHOtc/kFi GK+Q== X-Gm-Message-State: ANoB5pkO+ZITx0fxWR7ugRYZb/geMGydQaHnXnTLHTsWxOLFHiiOGoQM 1VAF/Njwk0saqHGkdIg/FmKuw4ZcjGXDAKp6e3UfxqB3s8JtTy2Xmc2A6jGaG7bdejxVkpxIk2C g/trvJG3HxsOq1m4cX5OVppER7Mi0aA== X-Received: by 2002:a19:5e50:0:b0:4b4:f19b:c155 with SMTP id z16-20020a195e50000000b004b4f19bc155mr11657993lfi.438.1669831961417; Wed, 30 Nov 2022 10:12:41 -0800 (PST) X-Google-Smtp-Source: AA0mqf76kHWCdB+Qxl7G0q0nP5xIQSstndwQ+d7bJHQTXo1zZAn5iyoNCwv7Joo4uG0dqyamw/J5A4o6kzdJFmIw3RM= X-Received: by 2002:a19:5e50:0:b0:4b4:f19b:c155 with SMTP id z16-20020a195e50000000b004b4f19bc155mr11657954lfi.438.1669831961138; Wed, 30 Nov 2022 10:12:41 -0800 (PST) Received: from 567203818698 named unknown by gmailapi.google.com with HTTPREST; Wed, 30 Nov 2022 10:12:40 -0800 MIME-Version: 1.0 In-Reply-To: References: From: "Oliver Steffen" User-Agent: alot/0.8.1 Date: Wed, 30 Nov 2022 10:12:40 -0800 Message-ID: Subject: Re: [edk2-devel] [PATCH v7 0/6] CI: Use Fedora 35 container for Linux jobs To: Sean Brogan , devel@edk2.groups.io Cc: Abner Chang , Alexei Fedorov , Andrew Fish , Anthony Perard , Ard Biesheuvel , Bob Feng , Brijesh Singh , Chasel Chiu , Daniel Schaefer , Erdem Aktas , Eric Dong , Gerd Hoffmann , Gua Guo , Guo Dong , Guomin Jiang , Hao A Wu , Igor Kulchytskyy , James Bottomley , James Lu , Jian J Wang , Jiaxin Wu , Jiewen Yao , Jordan Justen , Julien Grall , Leif Lindholm , Liming Gao , Maciej Rabeda , Michael D Kinney , Michael Kubacki , Min Xu , Nate DeSimone , Nickle Wang , Peter Grehan , Pierre Gondois , Rahul Kumar , Ray Ni , Rebecca Cran , Sami Mujawar , Sean Brogan , Sean Rhodes , Sebastien Boeuf , Siyuan Fu , Star Zeng , Sunil V L , Supreeth Venkatesh , Tom Lendacky , Wei6 Xu , Xiaoyu Lu , Yuwei Chen , Zhichao Gao , Zhiguang Liu , Pawel Polawski , Chris Fernald , Ard Biesheuvel , Chris Fernald X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Sean, Quoting Sean Brogan (2022-11-30 01:28:45) > Oliver, > > Thanks for this changeset and i think this is getting closer but over the past > few months there have been a few changes that I don't think this series takes > into account. > > A few comments i hope we can address quickly (since 18.04 is going offline > tomorrow). > > 1. Can the whole block at [1]https://github.com/tianocore/edk2/blob/ > dd3ba82d31a6d3cc4564dc83c9229e13773b55da/.pytool/CISettings.py#L172 be > removed. The only reason these exist is to pick up and download the > compilers. Yes. Done. > > 2. what about supporting the loongarch64 compiler? Can we add to container? Added the gcc release from the LoongSon GitHub page. This is a 13.0.0 20220906 (experimental), and not yet available via regular repositories. I opted for the "c-only" package which is only 70MB instead of the "full" one which was used in the ext_dep file (921MB). > > 3. If loongarch64 is included in container should you delete this file too: [2] > edk2/gcc_loongarch64_unknown_linux_ext_dep.yaml at master tianocore/edk2 > (github.com) > Deleted. > 4. Patch 4 has changes in multiple packages. I believe it is a requirement in > edk2 to only change a single package per commit. It makes reviews and > cherry-picking/bisection easier. Commit is now split by package. > 5. Since only Core CI as controlled by file .azurepipelines/Ubuntu_GCC5.yml > why not use the base container instead of test container? The Core CI Process > will not use qemu. The platform Ci files have their own yml with container > specifier. Changed. > > 6. what about removing the steps for installing node and cspell from the > container build? Since these are managed in the container they should be > skipped. I do not know what exactly what is was added for. I'll open an issue on the containers github for that. I think this is not critical at the moment. We can still thin out the image after tomorrow. > > Thanks > > Sean > We'll need to merge the changes for the docker file and let the new image be generated. Then I can prepare the next version of the patches. Thanks, Oliver