From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web09.6450.1665750871622247649 for ; Fri, 14 Oct 2022 05:34:32 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=EgZp3QI/; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: osteffen@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665750870; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=Zw8EqxAizWFfVMG1paP7sklsQ+HBdLXVr/w2D/hVVIc=; b=EgZp3QI/4SDIkWD+MOxVq+1jAeaESo22f87TGC16yDrxjUZS3N67sgLovc248p2xc6Xcn4 q/bnFKz5eZOn7Vme+1SPRNgB5fj8zo8r7BhRPvWY1kw9UfxuZ0Fx81O/KEhEhkv22pCUZ2 QK4suYNgZHmTMjrlz7u4/7bm0Qvh7Kk= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-324-PyFeeySuNiKqmZsqwT9HvA-1; Fri, 14 Oct 2022 08:34:29 -0400 X-MC-Unique: PyFeeySuNiKqmZsqwT9HvA-1 Received: by mail-lj1-f198.google.com with SMTP id bn39-20020a05651c17a700b0026309143eeeso2052532ljb.4 for ; Fri, 14 Oct 2022 05:34:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Zw8EqxAizWFfVMG1paP7sklsQ+HBdLXVr/w2D/hVVIc=; b=MJjn8c1hlSQmNpeR9SItNk5jWePypUp1bzuuHRG/32RYjzv6tP4oJMeixhcOXqzkja jl/DZ+3k+b+2/CVjSsmhaW9mc3CLpQC4wYVIMIG7v8dJu+C0cWhbyUXGQYiitQMzoFTW Mc/pDfqhkc0PdFp2bhAA3dXRi136inB3cpJ/bTyZIjPjXoDM/yy3rqFD1UxaX1wC3P+d LZGSTM4e/D55irJYeRgttUmGaipoWU/3dXOnJWtqGkTMABwKOSOSwEWOrK5xEzk91hpX TZhS9gCKVZW+Tp11TTBTpYkvwbFwcaYcWvbH3//pCczvP+1QbUeIR1SF7DbF4705w/EV oCfw== X-Gm-Message-State: ACrzQf3OzT26wB2D8M+QMf7+JUn5OfESYaBnkFvyd9S1olk7ijGXcoVB POP1IMc9vN2TW5N990BzgJVwQu19sdgbnejLUpAh6STcGUUwCaPtlcCPgjcE3ZHK4kSAryA3wiO TbsX2fl20HcMjLd/oWDVtmI/NID93TQ== X-Received: by 2002:ac2:46c9:0:b0:4a4:47cc:fc9d with SMTP id p9-20020ac246c9000000b004a447ccfc9dmr1738571lfo.1.1665750867272; Fri, 14 Oct 2022 05:34:27 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4/zA9jwy6hzlF7I58CJpkT+8HOzQZzzfsV/mCeLCsJ6CMie7m2c2lG+g5w2LRWV2UKZfFcz7Ki0CrnG9QNWfY= X-Received: by 2002:ac2:46c9:0:b0:4a4:47cc:fc9d with SMTP id p9-20020ac246c9000000b004a447ccfc9dmr1738547lfo.1.1665750867009; Fri, 14 Oct 2022 05:34:27 -0700 (PDT) Received: from 567203818698 named unknown by gmailapi.google.com with HTTPREST; Fri, 14 Oct 2022 05:34:26 -0700 From: "Oliver Steffen" X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 Date: Fri, 14 Oct 2022 05:34:26 -0700 Message-ID: Subject: [PATCH v2 0/2] Set Firmware Version from build command line To: devel@edk2.groups.io Cc: Anthony Perard , Ard Biesheuvel , Gerd Hoffmann , Jian J Wang , Jiewen Yao , Jordan Justen , Julien Grall , Leif Lindholm , Liming Gao , Ray Ni , Sami Mujawar , Zhichao Gao , Pawel Polawski , nd@arm.com, Oliver Steffen X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" ArmVirtXen.dsc allows setting the firmware version string in gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString via FIRMWARE_VER variable conveniently on the build command line. These two patches add this behavior to all .dsc files in ArmVirtPkg and OvmfPkg. PR: https://github.com/tianocore/edk2/pull/3476 v2: Address comments by Sami and Gerd: - Only set PCD if FIRMWARE_VER is defined - ArmVirt: move logic to ArmVirt.dsc.inc v1: https://edk2.groups.io/g/devel/message/95057 Signed-off-by: Oliver Steffen Oliver Steffen (2): OvmfPkg: allow setting Firmware Version from build command line ArmVirtPkg: allow setting Firmware Version from build command line ArmVirtPkg/ArmVirt.dsc.inc | 4 ++++ ArmVirtPkg/ArmVirtXen.dsc | 1 - OvmfPkg/OvmfPkgIa32.dsc | 3 +++ OvmfPkg/OvmfPkgIa32X64.dsc | 3 +++ OvmfPkg/OvmfPkgX64.dsc | 3 +++ OvmfPkg/OvmfXen.dsc | 3 +++ 6 files changed, 16 insertions(+), 1 deletion(-) -- 2.37.3