From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.6306.1649336173468559604 for ; Thu, 07 Apr 2022 05:56:13 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Ao+RvMqM; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: osteffen@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649336172; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dbIFDrilduOOzBx/ftBbvnu3fk6qWNFYF6oETKoO15g=; b=Ao+RvMqMHh5rIcL7bSpZ47+HVgSpdKWGGjv/u94dnK9/NSbeacO2um0JLdo4ZVLfMv1MzC tA1dONJY4rbZrcU8+9ZHMoW+ZvhPtQyTEaFIQOwlSGZdGdWiKlT6UhhK9v+g139TERkGkb hiTkBPnOCVTiz9KtmDkNR6tnTMFWC70= Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-78-iN10h1wCMcWGTBihbBEecQ-1; Thu, 07 Apr 2022 08:56:09 -0400 X-MC-Unique: iN10h1wCMcWGTBihbBEecQ-1 Received: by mail-ua1-f71.google.com with SMTP id c17-20020ab02751000000b0035d130b0725so73737uap.6 for ; Thu, 07 Apr 2022 05:56:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dbIFDrilduOOzBx/ftBbvnu3fk6qWNFYF6oETKoO15g=; b=BDCR7VV+OgYwFSIw2uGuULiQuNOtQyg/bZ8NI+Vc/J1Tijcqa7EHfsSO/Li+x4uLuN OcjfRw6Wlw+EiWyPEyxl6rVkgrYxZxFapz9jG0hbUf6ZzYQcsVsi8IIhDKBApAljIuRB uJBZ6lylS2Pf16kiROKcO2zvkHucVrpZ/IQZnFtM32FlisqE4f2bmNq/Ivn437XtF5MH 3WCbO2uwHzPiY0VBKuJ01bnpN1sX+f5gHMg4HP3Yylti7lRQVIYUd8OWWnKvcKrLHVgL aso3PsH1TTmpUfOPsY3tP6ouyoNQNkNtBCNyL6R/zjFGVQqHdNYWeSJZMPs0GLkX2CHQ 6ADA== X-Gm-Message-State: AOAM531XZBtOtDvjvsD0slbtnZX4/sE0KM/d9FuwstEQDzHRwag12uY7 7yU4qpi1sf3IB/HtOC4bS7v3Kow2iOtrwmO+j+ZKKiEkmYeqrvO9It8ji9BBqwL1Tm9aVfv+SM4 /DgeWE8ozze6rmeFx4PJwQiWs8afLOQ== X-Received: by 2002:a67:e9d7:0:b0:31a:df79:3a7c with SMTP id q23-20020a67e9d7000000b0031adf793a7cmr4405729vso.19.1649336168817; Thu, 07 Apr 2022 05:56:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyUfla+tHwb2jgsNhF+anJwIxV6GKmhkEgwvfh/35LeSlUVe1jgHKxJR307y8BXkRApibDQKzyFjb8eqyzuyOA= X-Received: by 2002:a67:e9d7:0:b0:31a:df79:3a7c with SMTP id q23-20020a67e9d7000000b0031adf793a7cmr4405724vso.19.1649336168662; Thu, 07 Apr 2022 05:56:08 -0700 (PDT) MIME-Version: 1.0 References: <20220304130403.47832-1-osteffen@redhat.com> <20220322133008.152037-1-osteffen@redhat.com> <01f201d83e53$ff55a440$fe00ecc0$@byosoft.com.cn> <20220407095750.rqwjlf3cvcj2gy5f@sirius.home.kraxel.org> <10f3672d-9e0c-61be-344d-9b8a2675942e@linux.intel.com> In-Reply-To: <10f3672d-9e0c-61be-344d-9b8a2675942e@linux.intel.com> From: "Oliver Steffen" Date: Thu, 7 Apr 2022 14:55:56 +0200 Message-ID: Subject: =?UTF-8?B?UmU6IOWbnuWkjTogW2VkazItZGV2ZWxdIFtQQVRDSCB2MyAwLzVdIEh0dHAgRml4ZXMgKFRha2UgVHdvKQ==?= To: "Rabeda, Maciej" , devel@edk2.groups.io Cc: Gerd Hoffmann , gaoliming@byosoft.com.cn, jiaxin.wu@intel.com, siyuan.fu@intel.com Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=osteffen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" On Thu, Apr 7, 2022 at 2:46 PM Rabeda, Maciej wrote: > 1. In HttpResponseWorker(): > > if (AsciiStrnCmp (HttpHeaders, "HTTP/1.0", AsciiStrLen > ("HTTP/1.0")) == 0) { > DEBUG ((DEBUG_VERBOSE, "HTTP: Server version is 1.0. Setting > Connection close.\n")); > HttpInstance->ConnectionClose = TRUE; > } > > I'd change AsciiStrLen ("HTTP/1.0") to sizeof("HTTP/1.0") - 1. No need > to call a AsciiStrLen every time this flow is executed, it is easily a > compile-time thing. Yes, of course. > 2. In HttpResponseWorker(), index -> Index, coding standard. Sorry, I missed that one. > I can merge this patch with changes above one I get an ACK from you. Sounds good to me. Thank you! -- Oliver