From: "Oliver Steffen" <osteffen@redhat.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
Andrew Fish <afish@apple.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
"Feng, Bob C" <bob.c.feng@intel.com>,
Daniel Schaefer <git@danielschaefer.me>,
Gerd Hoffmann <kraxel@redhat.com>,
"Yao, Jiewen" <jiewen.yao@intel.com>,
"Justen, Jordan L" <jordan.l.justen@intel.com>,
Leif Lindholm <quic_llindhol@quicinc.com>,
"Gao, Liming" <gaoliming@byosoft.com.cn>,
Michael Kubacki <mikuback@linux.microsoft.com>,
"Ni, Ray" <ray.ni@intel.com>,
Sami Mujawar <sami.mujawar@arm.com>,
Sean Brogan <sean.brogan@microsoft.com>,
Sunil V L <sunilvl@ventanamicro.com>,
"Chen, Christine" <yuwei.chen@intel.com>,
"Liu, Zhiguang" <zhiguang.liu@intel.com>,
Pawel Polawski <ppolawsk@redhat.com>,
"fernald, chris" <chfernal@microsoft.com>
Subject: Re: [edk2-devel] [PATCH v8 12/12] CI: use latest vm_image (Linux only)
Date: Wed, 30 Nov 2022 22:53:55 +0100 [thread overview]
Message-ID: <CA+bRGFpNqj8hX9K351-x3i95W2O=eUEumo=AUcd14fTU6dLv0w@mail.gmail.com> (raw)
In-Reply-To: <CO1PR11MB492958051DFE774CA41249CCD2159@CO1PR11MB4929.namprd11.prod.outlook.com>
On Wed, Nov 30, 2022 at 9:39 PM Kinney, Michael D
<michael.d.kinney@intel.com> wrote:
>
> I know we have run into issues before when using ubuntu-latest when
> a change was made to the latest image that broke CI.
>
> I would prefer to always set this to a specific version, so we can
> choose to move to a newer one with a PR that can run through CI.
>
> I am ok with selecting the highest version available that matches
> current ubuntu-latest version number.
I'll set it to ubuntu-22.04.
Although the actual VM does not do much anymore except
spawning a container, which I would assume to "always" work.
But better be safe than sorry.
-Oliver
>
> Thanks,
>
> Mike
>
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Oliver Steffen
> > Sent: Wednesday, November 30, 2022 12:01 PM
> > To: devel@edk2.groups.io
> > Cc: Andrew Fish <afish@apple.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Feng, Bob C <bob.c.feng@intel.com>; Daniel
> > Schaefer <git@danielschaefer.me>; Gerd Hoffmann <kraxel@redhat.com>; Yao, Jiewen <jiewen.yao@intel.com>; Justen, Jordan L
> > <jordan.l.justen@intel.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Kinney,
> > Michael D <michael.d.kinney@intel.com>; Michael Kubacki <mikuback@linux.microsoft.com>; Ni, Ray <ray.ni@intel.com>; Sami
> > Mujawar <sami.mujawar@arm.com>; Sean Brogan <sean.brogan@microsoft.com>; Sunil V L <sunilvl@ventanamicro.com>; Chen,
> > Christine <yuwei.chen@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>; Pawel Polawski <ppolawsk@redhat.com>; fernald,
> > chris <chfernal@microsoft.com>; Oliver Steffen <osteffen@redhat.com>
> > Subject: [edk2-devel] [PATCH v8 12/12] CI: use latest vm_image (Linux only)
> >
> > Switch over to `ubuntu-latest` as the vm_image for Linux
> > CI jobs (EmulatorPkg, ArmVirtPkg, OvmfPkg).
> > The previously used ubuntu-18.04 will not be available
> > after Dec 1st 2022.
> >
> > Signed-off-by: Oliver Steffen <osteffen@redhat.com>
> > ---
> > ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 2 +-
> > EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 2 +-
> > OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 2 +-
> > 3 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> > b/ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> > index 6d75502b5628..f7844229e60c 100644
> > --- a/ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> > +++ b/ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> > @@ -19,7 +19,7 @@ jobs:
> > - job: Platform_CI
> > variables:
> > package: 'ArmVirtPkg'
> > - vm_image: 'ubuntu-18.04'
> > + vm_image: 'ubuntu-latest'
> > should_run: true
> > run_flags: "MAKE_STARTUP_NSH=TRUE QEMU_HEADLESS=TRUE"
> >
> > diff --git a/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> > b/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> > index e58bb5b55245..3124de6634b2 100644
> > --- a/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> > +++ b/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> > @@ -19,7 +19,7 @@ jobs:
> > - job: Platform_CI
> > variables:
> > package: 'EmulatorPkg'
> > - vm_image: 'ubuntu-18.04'
> > + vm_image: 'ubuntu-latest'
> > should_run: false
> > run_flags: "MAKE_STARTUP_NSH=TRUE"
> >
> > diff --git a/OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> > b/OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> > index 984782aa7d19..831b0eb254b4 100644
> > --- a/OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> > +++ b/OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> > @@ -19,7 +19,7 @@ jobs:
> > - job: Platform_CI
> > variables:
> > package: 'OvmfPkg'
> > - vm_image: 'ubuntu-18.04'
> > + vm_image: 'ubuntu-latest'
> > should_run: true
> > run_flags: "MAKE_STARTUP_NSH=TRUE QEMU_HEADLESS=TRUE"
> >
> > --
> > 2.38.1
> >
> >
> >
> >
> >
>
prev parent reply other threads:[~2022-11-30 21:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221130200037.1098765-1-osteffen@redhat.com>
2022-11-30 20:01 ` [PATCH v8 01/12] CI: make Python version configurable Oliver Steffen
2022-11-30 20:01 ` [PATCH v8 02/12] OvmfPkg: CI: use Python version from defaults template Oliver Steffen
2022-11-30 20:01 ` [PATCH v8 03/12] EmulatorPkg: " Oliver Steffen
2022-11-30 20:01 ` [PATCH v8 04/12] CI: add ~/.local/bin to PATH (Linux only) Oliver Steffen
2022-11-30 20:01 ` [PATCH v8 05/12] CI: Allow running in a container Oliver Steffen
2022-11-30 20:01 ` [PATCH v8 06/12] BaseTools: CI: Use Fedora 35 container (Linux only) Oliver Steffen
2022-11-30 20:01 ` [PATCH v8 07/12] ArmVirtPkg: " Oliver Steffen
2022-11-30 20:01 ` [PATCH v8 08/12] OvmfPkg: " Oliver Steffen
2022-11-30 20:01 ` [PATCH v8 09/12] EmulatorPkg: " Oliver Steffen
2022-12-01 2:34 ` Ni, Ray
2022-11-30 20:01 ` [PATCH v8 10/12] CI: Don't install cspell Oliver Steffen
2022-11-30 20:44 ` [edk2-devel] " Chris Fernald
2022-11-30 21:51 ` Oliver Steffen
2022-11-30 20:01 ` [PATCH v8 11/12] .pytool: CISettings.py: don't add scopes for GCC Oliver Steffen
2022-11-30 20:01 ` [PATCH v8 12/12] CI: use latest vm_image (Linux only) Oliver Steffen
2022-11-30 20:38 ` [edk2-devel] " Michael D Kinney
2022-11-30 21:53 ` Oliver Steffen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+bRGFpNqj8hX9K351-x3i95W2O=eUEumo=AUcd14fTU6dLv0w@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox