Re: [edk2-devel] [PATCH v2 2/2] ArmVirtPkg/ArmVirtQemu: Avoid early ID map on ThunderX

["Oliver Steffen" <osteffen@redhat.com>]

Quoting Ard Biesheuvel (2023-01-18 08:34:32)
> On Wed, 18 Jan 2023 at 07:37, Oliver Steffen <osteffen@redhat.com> wrote:
> >
> > On Tue, Jan 17, 2023 at 3:57 PM Ard Biesheuvel <ardb@kernel.org> wrote:
> >>
> >> On Tue, 17 Jan 2023 at 13:48, Oliver Steffen <osteffen@redhat.com> wrote:
> >> >
> >> > Hi Ard, Hi everyone,
> >> >
> >> > Thanks for the work!
> >> >
> >> > But somehow this patch (as it was merged into master branch) does not
> >> > work for me on the ThunderX box we have.
> >> >
> >> > Any idea what could be wrong?
> >>
> >> I'm not sure I understand the question. The patch targets ThunderX,
> >> and you are using a ThunderX2.
> >>
> >> What were you expecting to happen, and what is happening instead?
> >
> >
> > Firmware does not start at all when using KVM.
> >
> > Please excuse my limited knowledge of Arm processor variants.
> > I assumed that ThunderX and ThunderX2 are very similar and hoped
> > the fix would also work for this case.
> >
> > The issue was introduced by the same commit that Dann
> > reported (07be1d34d95460a238fcd0f6693efb747c28b329):
> > "ArmVirtPkg/ArmVirtQemu: enable initial ID map at early boot".
> >
>
> Can you share the QEMU command line that you are using? I use a
> ThunderX2 basically 24/7 to do all my Linux and EDK2 development, so
> this change was developed on ThunderX2 and so I'm surprised you are
> seeing this issue.
>
> Did you try the DEBUG build as well?
Yes, debug is on.

Here is what I have, trying with the master branch from just now
(998ebe5ca0ae5c449e83ede533bee872f97d63af):

# make -C BaseTools && \
  . ./edksetup.sh && \
  build -t GCC5 -a AARCH64 \
    -p ArmVirtPkg/ArmVirtQemu.dsc \
    -DCAVIUM_ERRATUM_27456 \
    -b DEBUG

# /usr/libexec/qemu-kvm \
    -machine accel=kvm -m 1G -boot menu=on \
    -blockdev node-name=code,driver=file,filename="${FW_CODE_RESIZED}",read-only=on
\
    -blockdev node-name=vars,driver=file,filename="${FW_VARS}" \
    -machine pflash0=code \
    -machine pflash1=vars \
    -cpu max \
    -net none \
    -serial stdio

# /usr/libexec/qemu-kvm --version
QEMU emulator version 7.2.0 (qemu-kvm-7.2.0-3.el9)

# uname -r
5.14.0-234.el9.aarch64

# gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/libexec/gcc/aarch64-redhat-linux/11/lto-wrapper
Target: aarch64-redhat-linux
Configured with: ../configure --enable-bootstrap --enable-host-pie
--enable-host-bind-now --enable-languages=c,c++,fortran,lto
--prefix=/usr --mandir=/usr/share/man --infodir=/usr/share/info
--with-bugurl=http://bugzilla.redhat.com/bugzilla --enable-shared
--enable-threads=posix --enable-checking=release --with-system-zlib
--enable-__cxa_atexit --disable-libunwind-exceptions
--enable-gnu-unique-object --enable-linker-build-id
--with-gcc-major-version-only --enable-plugin --enable-initfini-array
--without-isl --enable-multilib --with-linker-hash-style=gnu
--enable-gnu-indirect-function --build=aarch64-redhat-linux
--with-build-config=bootstrap-lto --enable-link-serialization=1
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 11.3.1 20221121 (Red Hat 11.3.1-4) (GCC)


Since you have the same CPU... Might this be a bug in KVM?

Thanks!
-Oliver