From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web09.3584.1663743807211615327 for ; Wed, 21 Sep 2022 00:03:28 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=bS1WiZKA; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: osteffen@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663743806; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2H4ZLrlee9qC9d2Lqz6yWBFO+4gnDz1BYEK4Cp9328Y=; b=bS1WiZKAt9jJjP8RGDuShWg/pm4lth1SA6CVtGGKOpR7cdWjGft/8qVmwI9g3bduo9JzAs tc1LchV/Bkpjynm0p0nb81VFVxC8vDnJMAqTl0CnvXX7HLeXbptVwaShvvtuY9QAY14bOp PGKp89CoUWGr13khelc2uJbYut1LJgg= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-167-44AY_BeZO3aCQCRBO1F50Q-1; Wed, 21 Sep 2022 03:03:22 -0400 X-MC-Unique: 44AY_BeZO3aCQCRBO1F50Q-1 Received: by mail-lj1-f200.google.com with SMTP id v4-20020a2ea444000000b00261e0d5bc25so1682047ljn.19 for ; Wed, 21 Sep 2022 00:03:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=2H4ZLrlee9qC9d2Lqz6yWBFO+4gnDz1BYEK4Cp9328Y=; b=MKQNQg1lp7M2/ci+faXU4AiR4GnxMtNw7ZTv3xSwiEA/gkYlVvpB53edymuezNdZLI V6zKmuRr8CXBB1GQuWg/nLIyLGymC9zLNyViLpnZmducSt23Bo5Oz5bgnToLgD8eiF7W RpNB15s4Gp6i3kx7BED+tKIdePOKQn1tC3cfVwvE3EWEsx/sX6DDL4f/k0rMdmatxDCq uMC7uJoPLAoZjKNn/XYk4VChVEcTQZw5YZdqm3p40A+DaXdLAMB2cErqL1infll8PGbi Fj4LAIJxiJgLg8mI6/65FbfH6OvHBrGHwicTePNXFwLW/1J+QRicuL9/2E2Sa0SYfeSC cV7g== X-Gm-Message-State: ACrzQf2Nj1Bm+jZgPRNur4c7fJgT9A7tFJj0g8KIf7RO+yfIi1S60OYh 6CyKmdnIz1+i4Lj7GUI9yn1Wx1oEl6YJF6RwkatLZDHVgvjAkko9pmjbP1q334EF0M/ij8AaJCI lueWH+odOOYz7kyrXDLOZ9W4vl0+Bcg== X-Received: by 2002:ac2:4422:0:b0:49f:5c95:9525 with SMTP id w2-20020ac24422000000b0049f5c959525mr8039980lfl.1.1663743799585; Wed, 21 Sep 2022 00:03:19 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4KXX4hRUNnOuI5XpyF13i7RTcsfAfBV/7EK700qscQRpaghMspHgXhUQprPGlJkTAyoz9CaOUrCLYw1gETXuY= X-Received: by 2002:ac2:4422:0:b0:49f:5c95:9525 with SMTP id w2-20020ac24422000000b0049f5c959525mr8039965lfl.1.1663743799321; Wed, 21 Sep 2022 00:03:19 -0700 (PDT) MIME-Version: 1.0 References: <15026.1658420593869880980@groups.io> In-Reply-To: <15026.1658420593869880980@groups.io> From: "Oliver Steffen" Date: Wed, 21 Sep 2022 09:03:08 +0200 Message-ID: Subject: Re: [edk2-devel] [PATCH 1/1] ArmPlatformPkg/PrePeiCore: Print the firmware version early in boot To: devel@edk2.groups.io, Sami Mujawar , Rebecca Cran Cc: Ard Biesheuvel , Gerd Hoffmann X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="0000000000002803a105e92a8ab3" --0000000000002803a105e92a8ab3 Content-Type: text/plain; charset="UTF-8" Hi all, Is anybody still interested in this? Rohit's "Invoke constructors for SEC phase" patch was merged. Link to the original thread: https://edk2.groups.io/g/devel/message/88884 Regards, Oliver On Thu, Jul 21, 2022 at 6:24 PM Sami Mujawar wrote: > Hi Rebecca, Ard, > > On Tue, May 3, 2022 at 12:43 AM, Ard Biesheuvel wrote: > > // Data Cache enabled on Primary core when MMU is enabled. > ArmDisableDataCache (); > // Invalidate instruction cache > @@ -90,6 +95,18 @@ CEntryPoint ( > > // If not primary Jump to Secondary Main > if (ArmPlatformIsPrimaryCore (MpId)) { > + // Initialize the Serial Port > + SerialPortInitialize (); > + CharCount = AsciiSPrint ( > + Buffer, > + sizeof (Buffer), > + "UEFI firmware (version %s built at %a on %a)\n\r", > + (CHAR16 *)PcdGetPtr (PcdFirmwareVersionString), > > Given that this runs before any library constructors are called, I'd > be inclined to use FixedPcdGetPtr() here (and [FixedPcd] in the .INFs > below), to ensure that we don't dereference garbage. > > I also wonder whether we need a call to > ProcessLibraryConstructorList() somewhere. > > [SAMI] There is a patch at https://edk2.groups.io/g/devel/message/91113 > which aims to call ProcessLibraryConstructorList(). The idea being that the > DebugLib constructor would be called which initializes the serial port. > So, maybe these patches need adjustment so that we avoid calling > SerialPortInitialize () twice. > [/SAMI] > > regards, > > Sami Mujawar > > > + __TIME__, > + __DATE__ > + ); > + SerialPortWrite ((UINT8 *)Buffer, CharCount); > > > > --0000000000002803a105e92a8ab3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi all,

Is anybody still interested in this?
Rohit's "Invoke constructors for SEC ph= ase" patch was merged.

Link to the original thread:
https://edk2.groups.io/g/devel/mes= sage/88884

Regards,
=C2=A0Oliver

=
On Thu, Jul 21, 2022 at 6:24 PM Sami = Mujawar <sami.mujawar@arm.com> wrote:
Hi = Rebecca, Ard,

On Tue, May 3, 2022 at 12:43 AM, Ard Biesheuvel wrote:=
// Data Cache enabled on Primary core when MMU is enabled.
A= rmDisableDataCache ();
// Invalidate instruction cache
@@ -90,6 +95,1= 8 @@ CEntryPoint (

// If not primary Jump to Secondary Main
if (A= rmPlatformIsPrimaryCore (MpId)) {
+ // Initialize the Serial Port
+ S= erialPortInitialize ();
+ CharCount =3D AsciiSPrint (
+ Buffer,
+ = sizeof (Buffer),
+ "UEFI firmware (version %s built at %a on %a)\n\= r",
+ (CHAR16 *)PcdGetPtr (PcdFirmwareVersionString),
Given that this runs before any library constructors are called, I'dbe inclined to use FixedPcdGetPtr() here (and [FixedPcd] in the .INFs
b= elow), to ensure that we don't dereference garbage.

I also wonde= r whether we need a call to
ProcessLibraryConstructorList() somewhere. [SAMI] There is a patch at https://edk2.groups.io/g/devel/= message/91113 which aims to call ProcessLibraryConstructorList(). The i= dea being that the DebugLib constructor would be called which initializes t= he serial port.
So, maybe these patches need adjustment so that we avoid= calling SerialPortInitialize () twice.
[/SAMI]

regards,

S= ami Mujawar

+ __TIME__,
+ __DATE__
+ );
+ SerialPortWrite ((UINT8 = *)Buffer, CharCount);
=20

--0000000000002803a105e92a8ab3--