From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.11369.1674553955340284754 for ; Tue, 24 Jan 2023 01:52:35 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Mm0iwycN; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: osteffen@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674553954; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FlYUAXpbaLEawnO8gJd6u0siMz9yyv9uMGDSnKfvnV0=; b=Mm0iwycNgnpYrdB/75Ef/gIo+NSFIjBnJwi4/ymEJoK9gyvJn07ned+VDGIqiAZOVs2oCu 5ImXhYwELgt4Unlmn2MKGS902nTPP8BypVkIV2x2PV+B1NQ463kzD60PJ98jZM7JBVDJsX ruNLw8kRJw1ROfXxZY5VMCFgE8qCoXg= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-106-9z9O0jYMPc-NoN6cuo8fQQ-1; Tue, 24 Jan 2023 04:52:32 -0500 X-MC-Unique: 9z9O0jYMPc-NoN6cuo8fQQ-1 Received: by mail-lf1-f69.google.com with SMTP id n6-20020a0565120ac600b004d5a68b0f94so5027520lfu.14 for ; Tue, 24 Jan 2023 01:52:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FlYUAXpbaLEawnO8gJd6u0siMz9yyv9uMGDSnKfvnV0=; b=qu8lUE5veTXtRHHdYVkgBtadVIb7G51YBjrRu7Z3vnQr8mlDxyfp7Mcwa6/ezk5Qv2 OuJdVNagMWY0aF9kHaLUag8nuCkpJN5uWvJPPZ+xgjh9rdOrGn2DWko9piy3t/XwyGT7 NTp0m6Cs/Sxfu75aJsNOSMWEkNPEKL8+jxS/CVSPRi4tMO0DavCIzf0saU2lstbUDndx yNa7EHqiL6Yf+3GoWqMwzyzgDWw533PGK/057zdvCAJHMtsi3tJ/mtbg/ybkQU0aXiIW 13vDvcRcXSZHhl2gPoAjxUlefxDp2MFmBvMMDTd8COsaNtBXFWM5by0Y616mYAgnwBBL XTpg== X-Gm-Message-State: AFqh2kqwV2EF06w/uDWzztUtQRi07Gu+w7mYo4RibLHxLrp1/46G8c6Y ZCtiKsnlXgrY1cJCpxo2USNmPkAKzvQ+0gt2ufrPgu7GSVRm0oC3Vex5UPBj3wMa3rt1zn+SJrJ 7cXCDDbSZJse/6ftActgMntcoiZWWfQ== X-Received: by 2002:a2e:9316:0:b0:27f:b787:fd31 with SMTP id e22-20020a2e9316000000b0027fb787fd31mr1781069ljh.438.1674553950607; Tue, 24 Jan 2023 01:52:30 -0800 (PST) X-Google-Smtp-Source: AMrXdXvq2QkGNIlIsFPiIk/0OXZGVkXFq/K3enx1Vs+6bwOjMsVq6oGRlM4sQVmyjTYPB2bp1tfNGEvQPXhZa1DIprI= X-Received: by 2002:a2e:9316:0:b0:27f:b787:fd31 with SMTP id e22-20020a2e9316000000b0027fb787fd31mr1781068ljh.438.1674553950246; Tue, 24 Jan 2023 01:52:30 -0800 (PST) MIME-Version: 1.0 References: <173C1FA3C96CC3CD.14781@groups.io> <75649289-c3cb-d020-2592-391315ccd9f6@linux.microsoft.com> In-Reply-To: <75649289-c3cb-d020-2592-391315ccd9f6@linux.microsoft.com> From: "Oliver Steffen" Date: Tue, 24 Jan 2023 10:52:18 +0100 Message-ID: Subject: Re: [edk2-devel] [PATCH v1 1/1] .devcontainer/devcontainer.json: Add devcontainer file To: devel@edk2.groups.io, mikuback@linux.microsoft.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="0000000000005cab6c05f2ff79e0" --0000000000005cab6c05f2ff79e0 Content-Type: text/plain; charset="UTF-8" Hi Michael, Thanks for thinking of me. But I must admit I do not use devcontainers or vscode, and I am not sure how much help I can be here. It looks like a nice feature though, and I might try it out sometime. Thanks, Oliver On Fri, Jan 20, 2023 at 9:54 PM Michael Kubacki < mikuback@linux.microsoft.com> wrote: > Hi Oliver, > > Please let me know if you would like to be added to the maintainer list > for this directory. I'm happy to update the patch and sent that in a v2. > > Thanks, > Michael > > On 1/20/2023 3:51 PM, Michael Kubacki wrote: > > From: Michael Kubacki > > > > Tianocore maintains container images in the tianocore/containers repo > > and stores container images within the GitHub container registry. > > > > https://github.com/tianocore/containers > > > > This change adds a devcontainer.json file to the edk2 repo. This > > file's metadata and settings to configurate a development container > > for a given well-defined tool and runtime stack. > > > > More information about the devcontainer.json file is available here: > > https://containers.dev/implementors/json_reference/ > > > > This file is recognized by popular tools such as GitHub Codespaces > > and VS Code. In VS Code in particular, it makes it much easier for > > a user to be aware a dev container exists (via UI notifications) > > and to load the container. > > > > A minimal number of VS Code extensions are specified that are useful > > for edk2 development or to assist in complying with CI checks in > > place in edk2. > > > > Cc: Andrew Fish > > Cc: Chris Fernald > > Cc: Leif Lindholm > > Cc: Michael D Kinney > > Cc: Oliver Steffen > > Signed-off-by: Michael Kubacki > > --- > > .devcontainer/devcontainer.json | 16 ++++++++++++++++ > > Maintainers.txt | 5 +++++ > > 2 files changed, 21 insertions(+) > > > > diff --git a/.devcontainer/devcontainer.json > b/.devcontainer/devcontainer.json > > new file mode 100644 > > index 000000000000..592bb8cf6626 > > --- /dev/null > > +++ b/.devcontainer/devcontainer.json > > @@ -0,0 +1,16 @@ > > +{ > > + "image": "ghcr.io/tianocore/containers/fedora-35-dev:latest", > > + "postCreateCommand": "git config --global --add safe.directory * && > pip install --upgrade -r pip-requirements.txt", > > + "customizations": { > > + "vscode": { > > + "extensions": [ > > + "DavidAnson.vscode-markdownlint", > > + "ms-azuretools.vscode-docker", > > + "ms-vscode-remote.remote-containers", > > + "ms-vscode.cpptools", > > + "walonli.edk2-vscode", > > + "zachflower.uncrustify" > > + ] > > + } > > + } > > +} > > diff --git a/Maintainers.txt b/Maintainers.txt > > index 68f603b48398..4aa7973d5156 100644 > > --- a/Maintainers.txt > > +++ b/Maintainers.txt > > @@ -117,6 +117,11 @@ M: Michael Kubacki > [makubacki] > > R: Michael D Kinney [mdkinney] > > R: Liming Gao [lgao4] > > > > +.devcontainer/ > > +F: .devcontainer/ > > +M: Michael Kubacki [makubacki] > > +R: Chris Fernald [cfernald] > > + > > .github/ > > F: .github/ > > M: Sean Brogan [spbrogan] > > --0000000000005cab6c05f2ff79e0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi = Michael,
=
Tha= nks for thinking of me.
But I must admit I do not use devcontainers or vscode,
and I am not sure how much= help I can be here.

It l= ooks like a nice feature though, and I might try it out sometime.

Thanks,
=C2=A0Oliver

On Fri, Jan 20, 202= 3 at 9:54 PM Michael Kubacki <mikuback@linux.microsoft.com> wrote:
Hi Oliver,

Please let me know if you would like to be added to the maintainer list for this directory. I'm happy to update the patch and sent that in a v2= .

Thanks,
Michael

On 1/20/2023 3:51 PM, Michael Kubacki wrote:
> From: Michael Kubacki <michael.kubacki@microsoft.com>
>
> Tianocore maintains container images in the tianocore/containers repo<= br> > and stores container images within the GitHub container registry.
>
> https://github.com/tianocore/containers
>
> This change adds a devcontainer.json file to the edk2 repo. This
> file's metadata and settings to configurate a development containe= r
> for a given well-defined tool and runtime stack.
>
> More information about the devcontainer.json file is available here: > https://containers.dev/implementors/json_ref= erence/
>
> This file is recognized by popular tools such as GitHub Codespaces
> and VS Code. In VS Code in particular, it makes it much easier for
> a user to be aware a dev container exists (via UI notifications)
> and to load the container.
>
> A minimal number of VS Code extensions are specified that are useful > for edk2 development or to assist in complying with CI checks in
> place in edk2.
>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Chris Fernald <chris.fernald@outlook.com>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Oliver Steffen <osteffen@redhat.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
>=C2=A0 =C2=A0.devcontainer/devcontainer.json | 16 ++++++++++++++++
>=C2=A0 =C2=A0Maintainers.txt=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0|=C2=A0 5 +++++
>=C2=A0 =C2=A02 files changed, 21 insertions(+)
>
> diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontai= ner.json
> new file mode 100644
> index 000000000000..592bb8cf6626
> --- /dev/null
> +++ b/.devcontainer/devcontainer.json
> @@ -0,0 +1,16 @@
> +{
> +=C2=A0 "image": "ghcr.i= o/tianocore/containers/fedora-35-dev:latest",
> +=C2=A0 "postCreateCommand": "git config --global --add= safe.directory * && pip install --upgrade -r pip-requirements.txt&= quot;,
> +=C2=A0 "customizations": {
> +=C2=A0 =C2=A0 "vscode": {
> +=C2=A0 =C2=A0 =C2=A0 "extensions": [
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 "DavidAnson.vscode-markdownlint"= ;,
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 "ms-azuretools.vscode-docker",<= br> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 "ms-vscode-remote.remote-containers&= quot;,
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 "ms-vscode.cpptools",
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 "walonli.edk2-vscode",
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 "zachflower.uncrustify"
> +=C2=A0 =C2=A0 =C2=A0 ]
> +=C2=A0 =C2=A0 }
> +=C2=A0 }
> +}
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 68f603b48398..4aa7973d5156 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -117,6 +117,11 @@ M: Michael Kubacki <mikuback@linux.microsoft.com>= ; [makubacki]
>=C2=A0 =C2=A0R: Michael D Kinney <michael.d.kinney@intel.com> [mdkinney]=
>=C2=A0 =C2=A0R: Liming Gao <gaoliming@byosoft.com.cn> [lgao4]
>=C2=A0 =C2=A0
> +.devcontainer/
> +F: .devcontainer/
> +M: Michael Kubacki <mikuback@linux.microsoft.com> [makubacki]
> +R: Chris Fernald <chris.fernald@outlook.com> [cfernald]
> +
>=C2=A0 =C2=A0.github/
>=C2=A0 =C2=A0F: .github/
>=C2=A0 =C2=A0M: Sean Brogan <sean.brogan@microsoft.com> [spbrogan]

--0000000000005cab6c05f2ff79e0--