From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.38859.1674465835050868619 for ; Mon, 23 Jan 2023 01:23:55 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=RmWWNTUY; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: osteffen@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674465834; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XOacFGM5cuhlyXuiWGjGmLM2M50hciuYf4LD13M+iyY=; b=RmWWNTUYzpKMiggFX/YyQNaH5n00Xm0rvb/8w7oFdJ+g1FrAkX4HrhteasgFeiIwUM04sD SU4BkFKLZ0zu6KXIRun1mp26pwd9iKYkpmZGoyKLcb8VLPerTNoj7l0uY2VAsdaUKb/cAH f0kov0ClL0+PjVR8XC8/1VeVJXrppgU= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-340-p8DY2zJGM9qDNohjbUIAVQ-1; Mon, 23 Jan 2023 04:23:53 -0500 X-MC-Unique: p8DY2zJGM9qDNohjbUIAVQ-1 Received: by mail-lj1-f197.google.com with SMTP id l1-20020a2e9081000000b0028b97d2c493so2407965ljg.2 for ; Mon, 23 Jan 2023 01:23:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:user-agent:from:references :in-reply-to:mime-version:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XOacFGM5cuhlyXuiWGjGmLM2M50hciuYf4LD13M+iyY=; b=DvHQ1TMScF7iuX0UogE4F54gEn5XisUPQpA3vkgFdSPODPlQI5djMHS2eswOx5YLfP GvtinnB6j2mcVKzf+yb6XpbJhLA5v4r9xG6s5GtgujrViO3oC4NKOJRfprmkqGZecrZ9 VHyK6zTw891zQ6QfGxrqAtsRo5oB6J7bqSWCnGhSMIYy/OHSJE1R2WXKJK918/4ubT1k XMsnWEWnPkXAtRL7MlHoOCx+NRkgjNjOdEQ5+CBb81SxeCmV/sOARrZEKct74YCmLh+3 zSZ+3EsgFz4TdnL7anHrdEupfmyot67KlTwzQ1hWWCVpxA94xwIl5RC7vrnqhC/lvOXi wuWw== X-Gm-Message-State: AFqh2koSEpiSSxzTksEKP+H0qlJXSSUXxVzvXW/rE4aH1rsx2/Q/Ojx1 BRQut7JDqUYLbAAtnXu/zlOpxEJBu7RalScFUvPH88g8DxsbsK7jWoSWSS012Rhb8nOkibWxgxo Lk//8dcVnzDFp8VkNQrbNNJM6rVLPrA== X-Received: by 2002:a2e:8750:0:b0:28b:6377:219a with SMTP id q16-20020a2e8750000000b0028b6377219amr2022630ljj.455.1674465831607; Mon, 23 Jan 2023 01:23:51 -0800 (PST) X-Google-Smtp-Source: AMrXdXuu8at1eLeGX5dM+z2GLP5pEf0BSlFmwagj9Lv/L9q8gyfv7FevlrzIvUHIhVfb5MABuiigc3lcYvf5y+A8C9I= X-Received: by 2002:a2e:8750:0:b0:28b:6377:219a with SMTP id q16-20020a2e8750000000b0028b6377219amr2022627ljj.455.1674465831373; Mon, 23 Jan 2023 01:23:51 -0800 (PST) Received: from 567203818698 named unknown by gmailapi.google.com with HTTPREST; Mon, 23 Jan 2023 01:23:50 -0800 MIME-Version: 1.0 In-Reply-To: <4be046eb-ea12-2e0c-2bd8-5b735c5028b1@bsdio.com> References: <20230120205157.167-1-mikuback@linux.microsoft.com> <4be046eb-ea12-2e0c-2bd8-5b735c5028b1@bsdio.com> From: "Oliver Steffen" User-Agent: alot/0.8.1 Date: Mon, 23 Jan 2023 01:23:50 -0800 Message-ID: Subject: Re: [edk2-devel] [PATCH v1 1/1] .devcontainer/devcontainer.json: Add devcontainer file To: Rebecca Cran , devel@edk2.groups.io, mikuback@linux.microsoft.com Cc: Andrew Fish , Chris Fernald , Leif Lindholm , Michael D Kinney X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Quoting Rebecca Cran (2023-01-20 22:22:55) > Related to this, I've been wondering if we might want to commit a .vscode directory with project configuration file(s)? As long as project settings for other IDEs (should there be a reasonable user base) would be accepted in the future, why not? > > Also perhaps a .editorconfig file? I like the idea, because it is understood by many IDEs and text editors. > > -- > > Rebecca Cran > > > On 1/20/23 13:51, Michael Kubacki wrote: > > From: Michael Kubacki [1] > > Tianocore maintains container images in the tianocore/containers repo > and stores container images within the GitHub container registry. > > [2]https://github.com/tianocore/containers > > This change adds a devcontainer.json file to the edk2 repo. This > file's metadata and settings to configurate a development container > for a given well-defined tool and runtime stack. > > More information about the devcontainer.json file is available here: > [3]https://containers.dev/implementors/json_reference/ > > This file is recognized by popular tools such as GitHub Codespaces > and VS Code. In VS Code in particular, it makes it much easier for > a user to be aware a dev container exists (via UI notifications) > and to load the container. > > A minimal number of VS Code extensions are specified that are useful > for edk2 development or to assist in complying with CI checks in > place in edk2. > > Cc: Andrew Fish [4] > Cc: Chris Fernald [5] > Cc: Leif Lindholm [6] > Cc: Michael D Kinney [7] > Cc: Oliver Steffen [8] > Signed-off-by: Michael Kubacki [9] > --- > .devcontainer/devcontainer.json | 16 ++++++++++++++++ > Maintainers.txt | 5 +++++ > 2 files changed, 21 insertions(+) > > diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json > new file mode 100644 > index 000000000000..592bb8cf6626 > --- /dev/null > +++ b/.devcontainer/devcontainer.json > @@ -0,0 +1,16 @@ > +{ > + "image": "ghcr.io/tianocore/containers/fedora-35-dev:latest", > + "postCreateCommand": "git config --global --add safe.directory * && pip install --upgrade -r pip-requirements.txt", > + "customizations": { > + "vscode": { > + "extensions": [ > + "DavidAnson.vscode-markdownlint", > + "ms-azuretools.vscode-docker", > + "ms-vscode-remote.remote-containers", > + "ms-vscode.cpptools", > + "walonli.edk2-vscode", > + "zachflower.uncrustify" > + ] > + } > + } > +} > diff --git a/Maintainers.txt b/Maintainers.txt > index 68f603b48398..4aa7973d5156 100644 > --- a/Maintainers.txt > +++ b/Maintainers.txt > @@ -117,6 +117,11 @@ M: Michael Kubacki [10] [makubacki] > R: Michael D Kinney [11] [mdkinney] > R: Liming Gao [12] [lgao4] > > +.devcontainer/ > +F: .devcontainer/ > +M: Michael Kubacki [13] [makubacki] > +R: Chris Fernald [14] [cfernald] > + > .github/ > F: .github/ > M: Sean Brogan [15] [spbrogan] > > -Oliver