From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 1E3C59419A9 for ; Fri, 4 Aug 2023 13:21:33 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=nTW4msuviGfTXajITSvEiEa1w3GFbrTPSTZVY34ZLAk=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1691155292; v=1; b=aDdIFGpNXOY8STDGsJsCcbDbeCcKZBdb5I4HcV5dV6XUc9uMlMIT0Vb7vyiUWrFxSiUD+BBT 5G9nn5ZFgUgtfpoinuo7AgLdGURtnupcpUGkXFPS0lXx1pzm2m0oMxlGKLt9MsZR891C7j8Dl0y pG0R8cL63lTT42YsFqF8nbTA= X-Received: by 127.0.0.2 with SMTP id vpGhYY7687511xqKdqQWT0eM; Fri, 04 Aug 2023 06:21:32 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.10897.1691155292191162694 for ; Fri, 04 Aug 2023 06:21:32 -0700 X-Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-185-9W48T9bYO_6M1ZEvyDhJhg-1; Fri, 04 Aug 2023 09:21:27 -0400 X-MC-Unique: 9W48T9bYO_6M1ZEvyDhJhg-1 X-Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-4fe52cd62aaso2171081e87.0 for ; Fri, 04 Aug 2023 06:21:27 -0700 (PDT) X-Gm-Message-State: 1ORheawttcckCjFM96zzdYwNx7686176AA= X-Received: by 2002:a19:da02:0:b0:4f6:2a02:fc1a with SMTP id r2-20020a19da02000000b004f62a02fc1amr1034647lfg.17.1691155286395; Fri, 04 Aug 2023 06:21:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHByP79wmylz5vNpfbsF6UFrCgpCJdXcbfSQNbaOAjPUaNEmsuJc2zqiezv25RW/155T5GMAlohpDRzi2eBYJk= X-Received: by 2002:a19:da02:0:b0:4f6:2a02:fc1a with SMTP id r2-20020a19da02000000b004f62a02fc1amr1034631lfg.17.1691155286064; Fri, 04 Aug 2023 06:21:26 -0700 (PDT) MIME-Version: 1.0 References: <20230803114425.318246-1-osteffen@redhat.com> <001ed4ff-89fa-c7bf-3a29-305a28b94b41@linux.microsoft.com> In-Reply-To: From: "Oliver Steffen" Date: Fri, 4 Aug 2023 15:21:14 +0200 Message-ID: Subject: Re: [edk2-devel] [PATCH v1 0/4] Use Qemu 8 in CI and enable SMP in tests To: Ard Biesheuvel Cc: "Kinney, Michael D" , "devel@edk2.groups.io" , "mikuback@linux.microsoft.com" , "Feng, Bob C" , Gerd Hoffmann , "Yao, Jiewen" , "Justen, Jordan L" , "Gao, Liming" , Rebecca Cran , Sean Brogan , "Chen, Christine" , Laszlo Ersek X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,osteffen@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=aDdIFGpN; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Fri, Aug 4, 2023 at 3:17=E2=80=AFPM Ard Biesheuvel wro= te: > > On Thu, 3 Aug 2023 at 23:25, Ard Biesheuvel wrote: > > > > On Thu, 3 Aug 2023 at 21:21, Kinney, Michael D > > wrote: > > > > > > Hi Ard, > > > > > > This is the email with the analysis and the flag > > > setting required for SMP to work with SMM enabled for > > > IA32/X64 QEMU. > > > > > > https://edk2.groups.io/g/devel/message/102364 > > > > > > > > > I tried latest version of QEMU earlier in the Summer > > > and did not see any improvements. > > > > > > > Ah thanks, I had forgotten all about that rabbit hole you went down :-) > > > > So let's respin this with -smp 4 --accel=3Dtcg,thread=3Dsingle. It is > > still an improvement to exercise the MP code even if it doesn't > > strictly execute concurrently. (It will be very hard to > > catch/reproduce true concurrency issues in TCG anyway) > > > > Something like this is what I had in mind: > > --- a/OvmfPkg/PlatformCI/PlatformBuildLib.py > +++ b/OvmfPkg/PlatformCI/PlatformBuildLib.py > @@ -195,6 +195,7 @@ class PlatformBuilder( UefiBuilder, BuildSettingsMana= ger): > args =3D "-debugcon stdio" > # write messages to stdio > args +=3D " -global isa-debugcon.iobase=3D0x402" > # debug messages out thru virtual io port > args +=3D " -net none" > # turn off network > + args +=3D " -smp 4" > args +=3D f" -drive > file=3Dfat:rw:{VirtualDrive},format=3Draw,media=3Ddisk" # Mount disk with > startup.nsh > > if (self.env.GetValue("QEMU_HEADLESS").upper() =3D=3D "TRUE"): > @@ -202,6 +203,7 @@ class PlatformBuilder( UefiBuilder, BuildSettingsMana= ger): > > if (self.env.GetBuildValue("SMM_REQUIRE") =3D=3D "1"): > args +=3D " -machine q35,smm=3Don" #,accel=3D(tcg|kvm)" > + args +=3D " --accel tcg,thread=3Dsingle" > #args +=3D " -m ..." > args +=3D " -global driver=3Dcfi.pflash01,property=3Dsecure,= value=3Don" > args +=3D " -drive if=3Dpflash,format=3Draw,unit=3D0,file=3D= " + > os.path.join(OutputPath_FV, "OVMF_CODE.fd") + ",readonly=3Don" > > I can just fold that in if nobody minds. I suspect the time limit > increase may not be needed either this way. Yes, please do. Since you already have the changes ready. I was just looking into it now. If we do not need the larger timeout, even better. -Oliver -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107567): https://edk2.groups.io/g/devel/message/107567 Mute This Topic: https://groups.io/mt/100524063/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-