From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web09.4995.1660215001321468429 for ; Thu, 11 Aug 2022 03:50:01 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=C+x3Am3v; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: osteffen@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1660214999; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OH4rimQiIXHWOr4xALf1K4F0Bqe84wJP5yHslfbI1LA=; b=C+x3Am3vDh05v8dUjT2ol3/Vzo+MyMV4a0z/s4ClFOblFRj5zS31121Y/8wMGXk3ZhITtV 415GROBfqmO2MXa/Qy9faide5eeAI7Nsxb/MHTlBSTymgKAhJZWQw3JPkcDkpjGHs2BXvV Vka4UFGcxUf+vsOvuQw88atP3/jsRAQ= Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-516-KcLCYRnjMUC0RpxwaxrsOA-1; Thu, 11 Aug 2022 06:49:59 -0400 X-MC-Unique: KcLCYRnjMUC0RpxwaxrsOA-1 Received: by mail-ua1-f69.google.com with SMTP id y47-20020a9f3272000000b003874d9b010aso3467910uad.6 for ; Thu, 11 Aug 2022 03:49:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=OH4rimQiIXHWOr4xALf1K4F0Bqe84wJP5yHslfbI1LA=; b=S0lSIZS+yIp7GOHZbwRNavVMuA3ubzBhYicw8iXFb5xKd8l6wPNlq/n5o+mKiS5sCi sM/MvNs1uazQ/PyjcJ5Kmg76xQpFYLt7ouRznhJI4vI7KABSIj49M+eiK4CuCESRI6tG gYAJhcYR35n/BenA86nOrUcVt0ykfkesGEVzeNkANvqOGJHsq0fU6gQdudFn15Wmmf1A in7iv/uWam4E5FozBtkUuPhd6IA95H5fRZGd44i+rcb3KNDBJd3goaFRIdNI1K8k3vEw Fwh5MEsdOsCmcnd/yacvmRmDKoO6PqC6qdFl8h0GvEMjxY2OoXNMsrZyWNI9tqF4sRpR ox5w== X-Gm-Message-State: ACgBeo1o8kGvGL8D34zWXeGs9xmxboqDONpq3yfP5oGrGfTGxZ6D908J v/C7vIz7Q/Lte5IZv1UT8xiwb5h8WxYhAbnXfuKdMqwDYbniCKkCHRe9PBd/WXCFi3o8pop45i/ yCCTwYf+rAVoyskpGZqHOaQPXj493JQ== X-Received: by 2002:a67:d98f:0:b0:37d:d90e:dfc8 with SMTP id u15-20020a67d98f000000b0037dd90edfc8mr13678934vsj.20.1660214997409; Thu, 11 Aug 2022 03:49:57 -0700 (PDT) X-Google-Smtp-Source: AA6agR4/gfuaXz9FClEMss6bbtnOCjNuwvXCuDh/wnEdmBrr8X54EMFXCXoIfmipRAiAuuvw+B8FOXE2HKVakPTg19k= X-Received: by 2002:a67:d98f:0:b0:37d:d90e:dfc8 with SMTP id u15-20020a67d98f000000b0037dd90edfc8mr13678916vsj.20.1660214997137; Thu, 11 Aug 2022 03:49:57 -0700 (PDT) MIME-Version: 1.0 References: <20220810120313.203609-1-osteffen@redhat.com> <20220810120313.203609-5-osteffen@redhat.com> <0e573619-f0cc-a349-23e0-57da42b685a8@hpe.com> In-Reply-To: <0e573619-f0cc-a349-23e0-57da42b685a8@hpe.com> From: "Oliver Steffen" Date: Thu, 11 Aug 2022 12:49:46 +0200 Message-ID: Subject: Re: [edk2-devel] [PATCH v4 4/4] BaseTools: Remove ext. gcc dependencies (Linux only) To: devel@edk2.groups.io, daniel.schaefer@hpe.com Cc: Andrew Fish , Ard Biesheuvel , Bob Feng , Bret Barkelew , Eric Dong , Gerd Hoffmann , Jiewen Yao , Jordan Justen , Leif Lindholm , Liming Gao , Michael D Kinney , Rahul Kumar , Ray Ni , Sami Mujawar , Sean Brogan , Yuwei Chen , Sunil V L X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="00000000000027d30305e5f4eddf" --00000000000027d30305e5f4eddf Content-Type: text/plain; charset="UTF-8" Hi Daniel, The CI still runs through all jobs successfully. This includes builds for RiscV64. See the PR: https://github.com/tianocore/edk2/pull/2935 Thanks, Oliver On Thu, Aug 11, 2022 at 5:34 AM Daniel Schaefer wrote: > Hi Oliver, > > I assume you made sure that the build still works on at least one platform > per arch? > For example did you build a RISCV64 platform? > > Thanks, > Daniel > > On 8/10/22 20:03, Oliver Steffen wrote: > > Remove BaseTools/Bin/gcc*_linux_ext_dep.yaml to stop > > downloading gcc from external locations; use the > > toolchains provided by the container image instead. > > > > The image needs to set the GCC5_*_PREFIX accordingly. > > > > Signed-off-by: Oliver Steffen > > --- > > BaseTools/Bin/gcc_aarch64_linux_ext_dep.yaml | 21 ------------------ > > BaseTools/Bin/gcc_arm_linux_ext_dep.yaml | 21 ------------------ > > .../Bin/gcc_riscv64_unknown_ext_dep.yaml | 22 ------------------- > > 3 files changed, 64 deletions(-) > > delete mode 100644 BaseTools/Bin/gcc_aarch64_linux_ext_dep.yaml > > delete mode 100644 BaseTools/Bin/gcc_arm_linux_ext_dep.yaml > > delete mode 100644 BaseTools/Bin/gcc_riscv64_unknown_ext_dep.yaml > > > > diff --git a/BaseTools/Bin/gcc_aarch64_linux_ext_dep.yaml > b/BaseTools/Bin/gcc_aarch64_linux_ext_dep.yaml > > deleted file mode 100644 > > index ff8a9e868100..000000000000 > > --- a/BaseTools/Bin/gcc_aarch64_linux_ext_dep.yaml > > +++ /dev/null > > @@ -1,21 +0,0 @@ > > -## @file > > -# Download GCC AARCH64 compiler from Arm's release site > > -# Set shell variable GCC5_AARCH64_INSTALL to this folder > > -# > > -# This is only downloaded when a build activates scope gcc_aarch64_linux > > -# > > -# Copyright (c) Microsoft Corporation. > > -# SPDX-License-Identifier: BSD-2-Clause-Patent > > -## > > -{ > > - "scope": "gcc_aarch64_linux", > > - "type": "web", > > - "name": "gcc_aarch64_linux", > > - "source": " > https://developer.arm.com/-/media/Files/downloads/gnu/11.2-2022.02/binrel/gcc-arm-11.2-2022.02-x86_64-aarch64-none-linux-gnu.tar.xz > ", > > - "version": "11.2-2022.02", > > - "sha256": > "52dbac3eb71dbe0916f60a8c5ab9b7dc9b66b3ce513047baa09fae56234e53f3", > > - "compression_type": "tar", > > - "internal_path": > "/gcc-arm-11.2-2022.02-x86_64-aarch64-none-linux-gnu/", > > - "flags": ["set_shell_var", ], > > - "var_name": "GCC5_AARCH64_INSTALL" > > -} > > diff --git a/BaseTools/Bin/gcc_arm_linux_ext_dep.yaml > b/BaseTools/Bin/gcc_arm_linux_ext_dep.yaml > > deleted file mode 100644 > > index 151cbfa4b532..000000000000 > > --- a/BaseTools/Bin/gcc_arm_linux_ext_dep.yaml > > +++ /dev/null > > @@ -1,21 +0,0 @@ > > -## @file > > -# Download GCC ARM compiler from Arm's release site > > -# Set shell variable GCC5_ARM_INSTALL to this folder > > -# > > -# This is only downloaded when a build activates scope gcc_arm_linux > > -# > > -# Copyright (c) Microsoft Corporation. > > -# SPDX-License-Identifier: BSD-2-Clause-Patent > > -## > > -{ > > - "scope": "gcc_arm_linux", > > - "type": "web", > > - "name": "gcc_arm_linux", > > - "source": " > https://developer.arm.com/-/media/Files/downloads/gnu/11.2-2022.02/binrel/gcc-arm-11.2-2022.02-x86_64-arm-none-linux-gnueabihf.tar.xz > ", > > - "version": "11.2-2022.02", > > - "sha256": > "c254f7199261fe76c32ef42187502839bda7efad0a66646cf739d074eff45fad", > > - "compression_type": "tar", > > - "internal_path": > "/gcc-arm-11.2-2022.02-x86_64-arm-none-linux-gnueabihf/", > > - "flags": ["set_shell_var", ], > > - "var_name": "GCC5_ARM_INSTALL" > > -} > > diff --git a/BaseTools/Bin/gcc_riscv64_unknown_ext_dep.yaml > b/BaseTools/Bin/gcc_riscv64_unknown_ext_dep.yaml > > deleted file mode 100644 > > index 8abbcd7ba040..000000000000 > > --- a/BaseTools/Bin/gcc_riscv64_unknown_ext_dep.yaml > > +++ /dev/null > > @@ -1,22 +0,0 @@ > > -## @file > > -# Download GCC RISCV64 compiler from RISC-V Organization release site > > -# Set shell variable GCC5_RISCV64_INSTALL to this folder > > -# > > -# This is only downloaded when a build activates scope > gcc_riscv64_unknown > > -# > > -# Copyright (c) Microsoft Corporation. > > -# Copyright (c) 2020, Hewlett Packard Enterprise Development LP. All > rights reserved.
> > -# SPDX-License-Identifier: BSD-2-Clause-Patent > > -## > > -{ > > - "scope": "gcc_riscv64_unknown", > > - "type": "web", > > - "name": "gcc_riscv64_unknown", > > - "source": " > https://raw.githubusercontent.com/riscv/riscv-uefi-edk2-docs/master/gcc-riscv-edk2-ci-toolchain/gcc-riscv-9.2.0-2020.04-x86_64_riscv64-unknown-gnu.tar.xz > ", > > - "version": "9.2.0", > > - "compression_type": "tar", > > - "sha256": > "28373643b69f0ce008273c3dc63f172aa1121952f1b9ae94d7485ac94af7f344", > > - "internal_path": > "/gcc-riscv-9.2.0-2020.04-x86_64_riscv64-unknown-gnu", > > - "flags": ["set_shell_var", ], > > - "var_name": "GCC5_RISCV64_INSTALL" > > -} > > > > > > --00000000000027d30305e5f4eddf Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi = Daniel,

The CI still runs= through all jobs successfully.
This includes builds for RiscV64. See the PR:
https://github.com/tianocore/edk2/pull/29= 35

Thanks,
=C2=A0Oliver

On = Thu, Aug 11, 2022 at 5:34 AM Daniel Schaefer <daniel.schaefer@hpe.com> wrote:
Hi Oliver,

I assume you made sure that the build still works on at least one platform = per arch?
For example did you build a RISCV64 platform?

Thanks,
Daniel

On 8/10/22 20:03, Oliver Steffen wrote:
> Remove BaseTools/Bin/gcc*_linux_ext_dep.yaml to stop
> downloading gcc from external locations; use the
> toolchains provided by the container image instead.
>
> The image needs to set the GCC5_*_PREFIX accordingly.
>
> Signed-off-by: Oliver Steffen <osteffen@redhat.com>
> ---
>=C2=A0 BaseTools/Bin/gcc_aarch64_linux_ext_dep.yaml=C2=A0 | 21 --------= ----------
>=C2=A0 BaseTools/Bin/gcc_arm_linux_ext_dep.yaml=C2=A0 =C2=A0 =C2=A0 | 2= 1 ------------------
>=C2=A0 .../Bin/gcc_riscv64_unknown_ext_dep.yaml=C2=A0 =C2=A0 =C2=A0 | 2= 2 -------------------
>=C2=A0 3 files changed, 64 deletions(-)
>=C2=A0 delete mode 100644 BaseTools/Bin/gcc_aarch64_linux_ext_dep.yaml<= br> >=C2=A0 delete mode 100644 BaseTools/Bin/gcc_arm_linux_ext_dep.yaml
>=C2=A0 delete mode 100644 BaseTools/Bin/gcc_riscv64_unknown_ext_dep.yam= l
>
> diff --git a/BaseTools/Bin/gcc_aarch64_linux_ext_dep.yaml b/BaseTools/= Bin/gcc_aarch64_linux_ext_dep.yaml
> deleted file mode 100644
> index ff8a9e868100..000000000000
> --- a/BaseTools/Bin/gcc_aarch64_linux_ext_dep.yaml
> +++ /dev/null
> @@ -1,21 +0,0 @@
> -## @file
> -# Download GCC AARCH64 compiler from Arm's release site
> -# Set shell variable GCC5_AARCH64_INSTALL to this folder
> -#
> -# This is only downloaded when a build activates scope gcc_aarch64_li= nux
> -#
> -# Copyright (c) Microsoft Corporation.
> -# SPDX-License-Identifier: BSD-2-Clause-Patent
> -##
> -{
> -=C2=A0 "scope": "gcc_aarch64_linux",
> -=C2=A0 "type": "web",
> -=C2=A0 "name": "gcc_aarch64_linux",
> -=C2=A0 "source": "https= ://developer.arm.com/-/media/Files/downloads/gnu/11.2-2022.02/binrel/gcc-ar= m-11.2-2022.02-x86_64-aarch64-none-linux-gnu.tar.xz",
> -=C2=A0 "version": "11.2-2022.02",
> -=C2=A0 "sha256": "52dbac3eb71dbe0916f60a8c5ab9b7dc9b66= b3ce513047baa09fae56234e53f3",
> -=C2=A0 "compression_type": "tar",
> -=C2=A0 "internal_path": "/gcc-arm-11.2-2022.02-x86_64-= aarch64-none-linux-gnu/",
> -=C2=A0 "flags": ["set_shell_var", ],
> -=C2=A0 "var_name": "GCC5_AARCH64_INSTALL"
> -}
> diff --git a/BaseTools/Bin/gcc_arm_linux_ext_dep.yaml b/BaseTools/Bin/= gcc_arm_linux_ext_dep.yaml
> deleted file mode 100644
> index 151cbfa4b532..000000000000
> --- a/BaseTools/Bin/gcc_arm_linux_ext_dep.yaml
> +++ /dev/null
> @@ -1,21 +0,0 @@
> -## @file
> -# Download GCC ARM compiler from Arm's release site
> -# Set shell variable GCC5_ARM_INSTALL to this folder
> -#
> -# This is only downloaded when a build activates scope gcc_arm_linux<= br> > -#
> -# Copyright (c) Microsoft Corporation.
> -# SPDX-License-Identifier: BSD-2-Clause-Patent
> -##
> -{
> -=C2=A0 "scope": "gcc_arm_linux",
> -=C2=A0 "type": "web",
> -=C2=A0 "name": "gcc_arm_linux",
> -=C2=A0 "source": "htt= ps://developer.arm.com/-/media/Files/downloads/gnu/11.2-2022.02/binrel/gcc-= arm-11.2-2022.02-x86_64-arm-none-linux-gnueabihf.tar.xz",
> -=C2=A0 "version": "11.2-2022.02",
> -=C2=A0 "sha256": "c254f7199261fe76c32ef42187502839bda7= efad0a66646cf739d074eff45fad",
> -=C2=A0 "compression_type": "tar",
> -=C2=A0 "internal_path": "/gcc-arm-11.2-2022.02-x86_64-= arm-none-linux-gnueabihf/",
> -=C2=A0 "flags": ["set_shell_var", ],
> -=C2=A0 "var_name": "GCC5_ARM_INSTALL"
> -}
> diff --git a/BaseTools/Bin/gcc_riscv64_unknown_ext_dep.yaml b/BaseTool= s/Bin/gcc_riscv64_unknown_ext_dep.yaml
> deleted file mode 100644
> index 8abbcd7ba040..000000000000
> --- a/BaseTools/Bin/gcc_riscv64_unknown_ext_dep.yaml
> +++ /dev/null
> @@ -1,22 +0,0 @@
> -## @file
> -# Download GCC RISCV64 compiler from RISC-V Organization release site=
> -# Set shell variable GCC5_RISCV64_INSTALL to this folder
> -#
> -# This is only downloaded when a build activates scope gcc_riscv64_un= known
> -#
> -# Copyright (c) Microsoft Corporation.
> -# Copyright (c) 2020, Hewlett Packard Enterprise Development LP. All = rights reserved.<BR>
> -# SPDX-License-Identifier: BSD-2-Clause-Patent
> -##
> -{
> -=C2=A0 "scope": "gcc_riscv64_unknown",
> -=C2=A0 "type": "web",
> -=C2=A0 "name": "gcc_riscv64_unknown",
> -=C2=A0 "source": "https://raw.githubusercontent.com/riscv/riscv-uefi-edk2-do= cs/master/gcc-riscv-edk2-ci-toolchain/gcc-riscv-9.2.0-2020.04-x86_64_riscv6= 4-unknown-gnu.tar.xz ",
> -=C2=A0 "version": "9.2.0",
> -=C2=A0 "compression_type": "tar",
> -=C2=A0 "sha256": "28373643b69f0ce008273c3dc63f172aa112= 1952f1b9ae94d7485ac94af7f344",
> -=C2=A0 "internal_path": "/gcc-riscv-9.2.0-2020.04-x86_= 64_riscv64-unknown-gnu",
> -=C2=A0 "flags": ["set_shell_var", ],
> -=C2=A0 "var_name": "GCC5_RISCV64_INSTALL"
> -}





--00000000000027d30305e5f4eddf--