public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Grzegorz Bernacki" <gjb@semihalf.com>
To: Marcin Wojtas <mw@semihalf.com>
Cc: devel@edk2.groups.io, leif@nuviainc.com,
	ardb+tianocore@kernel.org,  Grzegorz Jaszczyk <jaz@semihalf.com>,
	upstream@semihalf.com,
	 Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>,
	jon@solid-run.com
Subject: Re: [edk2-platforms PATCH 2/4] Marvell/Cn913xDb: Add ACPI MDIO description
Date: Fri, 9 Jul 2021 07:36:37 +0200	[thread overview]
Message-ID: <CAA2Cew5587LctYVb+KacUju8Z_csXzWNM2e7_Y4Og+TarsvRUA@mail.gmail.com> (raw)
In-Reply-To: <20210613181631.2247221-3-mw@semihalf.com>

Tested-by: Grzegorz Bernacki <gjb@semihalf.com>

regards,
greg

niedz., 13 cze 2021 o 20:17 Marcin Wojtas <mw@semihalf.com> napisał(a):
>
> As the MDIO ACPI binding in DSDT is now established,
> add description for the SMI controller, along with the 1G PHYs.
> Add also a missing 'managed' property to the 10G ports.
>
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> ---
>  Silicon/Marvell/OcteonTx/AcpiTables/T91/Cn9131DbA/Ssdt.asl |  1 +
>  Silicon/Marvell/OcteonTx/AcpiTables/T91/Cn913xDbA/Dsdt.asl | 24 ++++++++++++++++++++
>  2 files changed, 25 insertions(+)
>
> diff --git a/Silicon/Marvell/OcteonTx/AcpiTables/T91/Cn9131DbA/Ssdt.asl b/Silicon/Marvell/OcteonTx/AcpiTables/T91/Cn9131DbA/Ssdt.asl
> index 691a709c18..8377b13763 100644
> --- a/Silicon/Marvell/OcteonTx/AcpiTables/T91/Cn9131DbA/Ssdt.asl
> +++ b/Silicon/Marvell/OcteonTx/AcpiTables/T91/Cn9131DbA/Ssdt.asl
> @@ -91,6 +91,7 @@ DefinitionBlock ("Cn9131DbASsdt.aml", "SSDT", 2, "MVEBU ", "CN9131", 3)
>                      Package () { "port-id", 0 },
>                      Package () { "gop-port-id", 0 },
>                      Package () { "phy-mode", "10gbase-kr"},
> +                    Package () { "managed", "in-band-status"},
>                    }
>                })
>              }
> diff --git a/Silicon/Marvell/OcteonTx/AcpiTables/T91/Cn913xDbA/Dsdt.asl b/Silicon/Marvell/OcteonTx/AcpiTables/T91/Cn913xDbA/Dsdt.asl
> index 30de868907..d76a2a902b 100644
> --- a/Silicon/Marvell/OcteonTx/AcpiTables/T91/Cn913xDbA/Dsdt.asl
> +++ b/Silicon/Marvell/OcteonTx/AcpiTables/T91/Cn913xDbA/Dsdt.asl
> @@ -185,6 +185,27 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "MVEBU ", "CN9130", 3)
>              })
>          }
>
> +        Device (SMI0)
> +        {
> +            Name (_HID, "MRVL0100")                             // _HID: Hardware ID
> +            Name (_UID, 0x00)                                   // _UID: Unique ID
> +            Name (_CRS, ResourceTemplate ()
> +            {
> +                Memory32Fixed (ReadWrite,
> +                    0xf212a200,                                 // Address Base
> +                    0x00000010,                                 // Address Length
> +                    )
> +            })
> +            Device (PHY0)
> +            {
> +                Name (_ADR, 0x0)
> +            }
> +            Device (PHY1)
> +            {
> +                Name (_ADR, 0x1)
> +            }
> +        }
> +
>          Device (PP20)
>          {
>              Name (_HID, "MRVL0110")                             // _HID: Hardware ID
> @@ -218,6 +239,7 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "MVEBU ", "CN9130", 3)
>                      Package () { "port-id", 0 },
>                      Package () { "gop-port-id", 0 },
>                      Package () { "phy-mode", "10gbase-kr"},
> +                    Package () { "managed", "in-band-status"},
>                    }
>                })
>              }
> @@ -237,6 +259,7 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "MVEBU ", "CN9130", 3)
>                      Package () { "port-id", 1 },
>                      Package () { "gop-port-id", 2 },
>                      Package () { "phy-mode", "rgmii-id"},
> +                    Package () { "phy-handle", \_SB.SMI0.PHY0},
>                    }
>                })
>              }
> @@ -256,6 +279,7 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "MVEBU ", "CN9130", 3)
>                      Package () { "port-id", 2 },
>                      Package () { "gop-port-id", 3 },
>                      Package () { "phy-mode", "rgmii-id"},
> +                    Package () { "phy-handle", \_SB.SMI0.PHY1},
>                    }
>                })
>              }
> --
> 2.29.0
>

  reply	other threads:[~2021-07-09  5:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-13 18:16 [edk2-platforms PATCH 0/4] ACPI MDIO support for Marvell SoCs Marcin Wojtas
2021-06-13 18:16 ` [edk2-platforms PATCH 1/4] SolidRun/Armada80x0McBin: Add ACPI MDIO description Marcin Wojtas
2021-07-09  5:51   ` Grzegorz Bernacki
2021-06-13 18:16 ` [edk2-platforms PATCH 2/4] Marvell/Cn913xDb: " Marcin Wojtas
2021-07-09  5:36   ` Grzegorz Bernacki [this message]
2021-06-13 18:16 ` [edk2-platforms PATCH 3/4] Marvell/Armada70x0Db: " Marcin Wojtas
2021-06-13 18:16 ` [edk2-platforms PATCH 4/4] Marvell/Armada80x0Db: " Marcin Wojtas
2021-06-14 21:55 ` [edk2-platforms PATCH 0/4] ACPI MDIO support for Marvell SoCs Leif Lindholm
2021-06-15  4:10   ` Jon Nettleton
2021-06-29 14:17   ` Marcin Wojtas
2021-07-12 10:51     ` Marcin Wojtas
2021-07-12 11:17       ` Jon Nettleton
2021-07-16 17:32         ` Ard Biesheuvel
2021-07-19  7:27           ` Ard Biesheuvel
2021-07-19  9:34             ` Marcin Wojtas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAA2Cew5587LctYVb+KacUju8Z_csXzWNM2e7_Y4Og+TarsvRUA@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox