From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) by mx.groups.io with SMTP id smtpd.web11.6113.1625207066123964958 for ; Thu, 01 Jul 2021 23:24:26 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@semihalf-com.20150623.gappssmtp.com header.s=20150623 header.b=dqhcXR6e; spf=none, err=SPF record not found (domain: semihalf.com, ip: 209.85.160.179, mailfrom: gjb@semihalf.com) Received: by mail-qt1-f179.google.com with SMTP id v10so5916827qto.1 for ; Thu, 01 Jul 2021 23:24:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=eOT9u8n7GecgCDxyCmtIiAqyjQWPytJdhj2Qpgdm6NE=; b=dqhcXR6ecUeGACksdUZcNEuJ8NJich/vw7NSLlO6x3hTnj57MJgFMC7LygrGeb+7y8 4teQe60PQyMstA9UaHm4Wrd/uC8V02lN+h2/dFG/XszHkx+QWuPhInINQVy6pEPq7nMt tsS1QL6ouaLTunP1Oeco/c0QK1gQty1karuLyK0ypXYaLHjc5Y1IRMuw/CRIdGGClj/c Y87RQy+SnYFmOH3vK0avucy92grKptAe+QdydY9+EWk2CbHMNMJdsAvrKS8o2w4obfeS frdWMvYgmBRo/IRCzhLd00llJJmQE/OX09CCPjD/BlB+Wr8McodP/ABfFWrHGN6rro8p gtWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=eOT9u8n7GecgCDxyCmtIiAqyjQWPytJdhj2Qpgdm6NE=; b=YiR9XYjYvmo2dja2m/Rq2zM8sldTgZv+ZZ4BVVMgFdzR8VewYTLPhsk+hcTPvJH8Ia K6R6h7scMVIKsBMgbAeCYZBJtQD/W9ii1JGCeciBQZUdzEeVCZeoO249q6lgoELuaKiJ Nw++dR7BlDTZw2bqUEOk8kAufuPQZr+xEUJkCtfq3D6rU3zyrhvCS6ezFmkyMCXNQkLs VLx70vbrLDiy/djfKJcZMLN/4K93VVkTA5g36R8UfpSdjTdhC1/TDqVlg4S9pRdXpnF/ qutLBLyiaXXfBnJCxMLk+xdI4UUxbaRG97DARUz3SOA7yu4b2KFW2FoW1c5VTMtJD3xL 4h5Q== X-Gm-Message-State: AOAM531qgMhu2emDimd3tfiykov8Cx+NIvSYdN6TaNA1FJa0VA6T2LG8 qxuY0SeiysG7n33Q4bW7MGh820b5DN+sT1kRGngGOA== X-Google-Smtp-Source: ABdhPJxTKNrZXL83U9vggnOT0BHTi83K/gRfKu0785s82s4KnllCPLPmZK+OfImMf/M6t48MYRIOTmXQIdPbJdARTZ0= X-Received: by 2002:a05:622a:1444:: with SMTP id v4mr3639567qtx.143.1625207065310; Thu, 01 Jul 2021 23:24:25 -0700 (PDT) MIME-Version: 1.0 References: <20210701092051.1057606-1-gjb@semihalf.com> <20210701092051.1057606-4-gjb@semihalf.com> In-Reply-To: From: "Grzegorz Bernacki" Date: Fri, 2 Jul 2021 08:24:14 +0200 Message-ID: Subject: Re: [edk2-platforms PATCH v5 3/4] RISC-V Platforms: add SecureBootVariableLib class resolution To: "Chang, Abner (HPS SW/FW Technologist)" Cc: "devel@edk2.groups.io" , "leif@nuviainc.com" , "ardb+tianocore@kernel.org" , "Samer.El-Haj-Mahmoud@arm.com" , "sunny.Wang@arm.com" , "mw@semihalf.com" , "upstream@semihalf.com" , "jiewen.yao@intel.com" , "jian.j.wang@intel.com" , "min.m.xu@intel.com" , "lersek@redhat.com" , "sami.mujawar@arm.com" , "afish@apple.com" , "ray.ni@intel.com" , "jordan.l.justen@intel.com" , "rebecca@bsdio.com" , "grehan@freebsd.org" , "thomas.abraham@arm.com" , "chasel.chiu@intel.com" , "nathaniel.l.desimone@intel.com" , "gaoliming@byosoft.com.cn" , "eric.dong@intel.com" , "michael.d.kinney@intel.com" , "zailiang.sun@intel.com" , "yi.qian@intel.com" , "graeme@nuviainc.com" , "rad@semihalf.com" , "pete@akeo.ie" , "Schaefer, Daniel" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, No, not yet. Thanks, Grzegorz pt., 2 lip 2021 o 06:12 Chang, Abner (HPS SW/FW Technologist) napisa=C5=82(a): > > Hi Grzegorz, > Was the entire series of patches got reviewed-by? > > Regards, > Abner > > > -----Original Message----- > > From: Grzegorz Bernacki [mailto:gjb@semihalf.com] > > Sent: Thursday, July 1, 2021 5:21 PM > > To: devel@edk2.groups.io > > Cc: leif@nuviainc.com; ardb+tianocore@kernel.org; Samer.El-Haj- > > Mahmoud@arm.com; sunny.Wang@arm.com; mw@semihalf.com; > > upstream@semihalf.com; jiewen.yao@intel.com; jian.j.wang@intel.com; > > min.m.xu@intel.com; lersek@redhat.com; sami.mujawar@arm.com; > > afish@apple.com; ray.ni@intel.com; jordan.l.justen@intel.com; > > rebecca@bsdio.com; grehan@freebsd.org; thomas.abraham@arm.com; > > chasel.chiu@intel.com; nathaniel.l.desimone@intel.com; > > gaoliming@byosoft.com.cn; eric.dong@intel.com; > > michael.d.kinney@intel.com; zailiang.sun@intel.com; yi.qian@intel.com; > > graeme@nuviainc.com; rad@semihalf.com; pete@akeo.ie; Grzegorz > > Bernacki ; Chang, Abner (HPS SW/FW Technologist) > > ; Schaefer, Daniel > > Subject: [edk2-platforms PATCH v5 3/4] RISC-V Platforms: add > > SecureBootVariableLib class resolution > > > > The edk2 patch > > SecurityPkg: Create library for setting Secure Boot variables. > > > > removes generic functions from SecureBootConfigDxe and places > > them into SecureBootVariableLib. This patch adds SecureBootVariableLib > > mapping for each RICS-V platform which uses SecureBootConfigDxe. > > > > Signed-off-by: Grzegorz Bernacki > > Reviewed-by: Abner Chang > > Reviewed-by: Daniel Schaefer > > --- > > Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc |= 1 + > > > > Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc > > | 1 + > > 2 files changed, 2 insertions(+) > > > > diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc > > b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc > > index b91823ceeb..fc5ba2a07f 100644 > > --- a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc > > +++ b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc > > @@ -122,6 +122,7 @@ > > OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf > > > > TpmMeasurementLib|SecurityPkg/Library/DxeTpmMeasurementLib/DxeTp > > mMeasurementLib.inf > > AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.= inf > > + > > SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureB > > ootVariableLib.inf > > !else > > > > TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/Tp > > mMeasurementLibNull.inf > > > > AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableL > > ibNull.inf > > diff --git > > a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.d > > sc > > b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540. > > dsc > > index 0eafe29880..71add8ff9a 100644 > > --- > > a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.d > > sc > > +++ > > b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540. > > dsc > > @@ -122,6 +122,7 @@ > > OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf > > > > TpmMeasurementLib|SecurityPkg/Library/DxeTpmMeasurementLib/DxeTp > > mMeasurementLib.inf > > AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.= inf > > + > > SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureB > > ootVariableLib.inf > > !else > > > > TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/Tp > > mMeasurementLibNull.inf > > > > AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableL > > ibNull.inf > > -- > > 2.25.1 >