* [PATCH 1/4] Silicon/SynQuacerNetsecDxe: Test the ControllerHandle is managed by this driver
2021-10-13 5:36 [PATCH 0/4] SynQuacer drivers test the ControllerHandle correctly Masami Hiramatsu
@ 2021-10-13 5:36 ` Masami Hiramatsu
2021-10-13 5:36 ` [PATCH 2/4] Silicon/SynQuacerI2cDxe: " Masami Hiramatsu
` (3 subsequent siblings)
4 siblings, 0 replies; 10+ messages in thread
From: Masami Hiramatsu @ 2021-10-13 5:36 UTC (permalink / raw)
To: Ard Biesheuvel, Leif Lindholm; +Cc: devel, Kazuhiko Sakamoto
From: Kazuhiko Sakamoto <sakamoto.kazuhiko@socionext.com>
Test the @ControllerHandle is not NULL and is actually managed by
this driver.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Kazuhiko Sakamoto <sakamoto.kazuhiko@socionext.com>
Signed-off-by: Masami Hiramatsu <masami.hiramatsu@linaro.org>
---
.../Drivers/Net/NetsecDxe/ComponentName.c | 13 +++++++++++++
.../Drivers/Net/NetsecDxe/DriverBinding.c | 1 -
.../SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.h | 1 +
3 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/ComponentName.c b/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/ComponentName.c
index 44b3daa0af..743fa88384 100644
--- a/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/ComponentName.c
+++ b/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/ComponentName.c
@@ -159,6 +159,19 @@ NetsecGetControllerName (
OUT CHAR16 **ControllerName
)
{
+ EFI_STATUS Status;
+
+ if (!ControllerHandle) {
+ return EFI_INVALID_PARAMETER;
+ }
+
+ Status = EfiTestManagedDevice (ControllerHandle,
+ gNetsecDriverBinding.DriverBindingHandle,
+ &gEdkiiNonDiscoverableDeviceProtocolGuid);
+ if (EFI_ERROR (Status)) {
+ return Status;
+ }
+
if (ChildHandle != NULL) {
return EFI_UNSUPPORTED;
}
diff --git a/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/DriverBinding.c b/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/DriverBinding.c
index 392d1b474f..fa0c415e98 100644
--- a/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/DriverBinding.c
+++ b/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/DriverBinding.c
@@ -131,7 +131,6 @@ NetsecDriverBindingStop (
}
-STATIC
EFI_DRIVER_BINDING_PROTOCOL gNetsecDriverBinding = {
NetsecDriverBindingSupported,
NetsecDriverBindingStart,
diff --git a/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.h b/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.h
index cf2abb0ab1..9b3d19c033 100644
--- a/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.h
+++ b/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.h
@@ -27,6 +27,7 @@
#include "netsec_for_uefi/pfdep.h"
extern EFI_COMPONENT_NAME2_PROTOCOL gNetsecDriverComponentName2;
+extern EFI_DRIVER_BINDING_PROTOCOL gNetsecDriverBinding;
/*--------------- Simple Network Driver entry point functions ----------------*/
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 2/4] Silicon/SynQuacerI2cDxe: Test the ControllerHandle is managed by this driver
2021-10-13 5:36 [PATCH 0/4] SynQuacer drivers test the ControllerHandle correctly Masami Hiramatsu
2021-10-13 5:36 ` [PATCH 1/4] Silicon/SynQuacerNetsecDxe: Test the ControllerHandle is managed by this driver Masami Hiramatsu
@ 2021-10-13 5:36 ` Masami Hiramatsu
2021-10-13 5:37 ` [PATCH 3/4] Silicon/AtSha204a: " Masami Hiramatsu
` (2 subsequent siblings)
4 siblings, 0 replies; 10+ messages in thread
From: Masami Hiramatsu @ 2021-10-13 5:36 UTC (permalink / raw)
To: Ard Biesheuvel, Leif Lindholm; +Cc: devel, Kazuhiko Sakamoto
From: Kazuhiko Sakamoto <sakamoto.kazuhiko@socionext.com>
Test the @ControllerHandle is not NULL and is actually managed by
this driver.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Kazuhiko Sakamoto <sakamoto.kazuhiko@socionext.com>
Signed-off-by: Masami Hiramatsu <masami.hiramatsu@linaro.org>
---
.../Drivers/SynQuacerI2cDxe/ComponentName.c | 13 +++++++++++++
.../Drivers/SynQuacerI2cDxe/DriverBinding.c | 2 +-
.../Drivers/SynQuacerI2cDxe/SynQuacerI2cDxe.h | 1 +
3 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/Silicon/Socionext/SynQuacer/Drivers/SynQuacerI2cDxe/ComponentName.c b/Silicon/Socionext/SynQuacer/Drivers/SynQuacerI2cDxe/ComponentName.c
index 9e7f189c13..ed5f11f107 100644
--- a/Silicon/Socionext/SynQuacer/Drivers/SynQuacerI2cDxe/ComponentName.c
+++ b/Silicon/Socionext/SynQuacer/Drivers/SynQuacerI2cDxe/ComponentName.c
@@ -158,6 +158,19 @@ SynQuacerI2cGetControllerName (
OUT CHAR16 **ControllerName
)
{
+ EFI_STATUS Status;
+
+ if (!ControllerHandle) {
+ return EFI_INVALID_PARAMETER;
+ }
+
+ Status = EfiTestManagedDevice (ControllerHandle,
+ gSynQuacerI2cDriverBinding.DriverBindingHandle,
+ &gEdkiiNonDiscoverableDeviceProtocolGuid);
+ if (EFI_ERROR (Status)) {
+ return Status;
+ }
+
if (ChildHandle != NULL) {
return EFI_UNSUPPORTED;
}
diff --git a/Silicon/Socionext/SynQuacer/Drivers/SynQuacerI2cDxe/DriverBinding.c b/Silicon/Socionext/SynQuacer/Drivers/SynQuacerI2cDxe/DriverBinding.c
index 4e265aacf1..912ae79d14 100644
--- a/Silicon/Socionext/SynQuacer/Drivers/SynQuacerI2cDxe/DriverBinding.c
+++ b/Silicon/Socionext/SynQuacer/Drivers/SynQuacerI2cDxe/DriverBinding.c
@@ -129,7 +129,7 @@ SynQuacerI2cDriverBindingStop (
}
-STATIC EFI_DRIVER_BINDING_PROTOCOL gSynQuacerI2cDriverBinding = {
+EFI_DRIVER_BINDING_PROTOCOL gSynQuacerI2cDriverBinding = {
SynQuacerI2cDriverBindingSupported,
SynQuacerI2cDriverBindingStart,
SynQuacerI2cDriverBindingStop,
diff --git a/Silicon/Socionext/SynQuacer/Drivers/SynQuacerI2cDxe/SynQuacerI2cDxe.h b/Silicon/Socionext/SynQuacer/Drivers/SynQuacerI2cDxe/SynQuacerI2cDxe.h
index f891e4bf2f..c6534e6972 100644
--- a/Silicon/Socionext/SynQuacer/Drivers/SynQuacerI2cDxe/SynQuacerI2cDxe.h
+++ b/Silicon/Socionext/SynQuacer/Drivers/SynQuacerI2cDxe/SynQuacerI2cDxe.h
@@ -25,6 +25,7 @@
#include <Protocol/NonDiscoverableDevice.h>
extern EFI_COMPONENT_NAME2_PROTOCOL gSynQuacerI2cDriverComponentName2;
+extern EFI_DRIVER_BINDING_PROTOCOL gSynQuacerI2cDriverBinding;
#define SYNQUACER_I2C_SIGNATURE SIGNATURE_32 ('S', 'I', '2', 'C')
#define SYNQUACER_I2C_FROM_THIS(a) CR ((a), SYNQUACER_I2C_MASTER, \
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 3/4] Silicon/AtSha204a: Test the ControllerHandle is managed by this driver
2021-10-13 5:36 [PATCH 0/4] SynQuacer drivers test the ControllerHandle correctly Masami Hiramatsu
2021-10-13 5:36 ` [PATCH 1/4] Silicon/SynQuacerNetsecDxe: Test the ControllerHandle is managed by this driver Masami Hiramatsu
2021-10-13 5:36 ` [PATCH 2/4] Silicon/SynQuacerI2cDxe: " Masami Hiramatsu
@ 2021-10-13 5:37 ` Masami Hiramatsu
2021-10-13 5:37 ` [PATCH 4/4] Silicon/ChaosKeyDxe: " Masami Hiramatsu
2021-10-27 11:21 ` [PATCH 0/4] SynQuacer drivers test the ControllerHandle correctly Leif Lindholm
4 siblings, 0 replies; 10+ messages in thread
From: Masami Hiramatsu @ 2021-10-13 5:37 UTC (permalink / raw)
To: Ard Biesheuvel, Leif Lindholm; +Cc: devel, Kazuhiko Sakamoto
From: Kazuhiko Sakamoto <sakamoto.kazuhiko@socionext.com>
Test the @ControllerHandle is not NULL and is actually managed by
this driver.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Kazuhiko Sakamoto <sakamoto.kazuhiko@socionext.com>
Signed-off-by: Masami Hiramatsu <masami.hiramatsu@linaro.org>
---
Silicon/Atmel/AtSha204a/AtSha204aDriver.h | 1 +
Silicon/Atmel/AtSha204a/ComponentName.c | 13 +++++++++++++
Silicon/Atmel/AtSha204a/DriverBinding.c | 1 -
3 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/Silicon/Atmel/AtSha204a/AtSha204aDriver.h b/Silicon/Atmel/AtSha204a/AtSha204aDriver.h
index 615959baf4..11be15b25b 100644
--- a/Silicon/Atmel/AtSha204a/AtSha204aDriver.h
+++ b/Silicon/Atmel/AtSha204a/AtSha204aDriver.h
@@ -59,6 +59,7 @@ typedef struct {
#define ATSHA204A_OPCODE_RANDOM 0x1b
extern EFI_COMPONENT_NAME2_PROTOCOL gAtSha204aDriverComponentName2;
+extern EFI_DRIVER_BINDING_PROTOCOL gI2cHwrngDriverBinding;
EFI_STATUS
AtSha204aInit (
diff --git a/Silicon/Atmel/AtSha204a/ComponentName.c b/Silicon/Atmel/AtSha204a/ComponentName.c
index eec7b9120b..cc1d970bcf 100644
--- a/Silicon/Atmel/AtSha204a/ComponentName.c
+++ b/Silicon/Atmel/AtSha204a/ComponentName.c
@@ -159,6 +159,19 @@ AtSha204aGetControllerName (
OUT CHAR16 **ControllerName
)
{
+ EFI_STATUS Status;
+
+ if (!ControllerHandle) {
+ return EFI_INVALID_PARAMETER;
+ }
+
+ Status = EfiTestManagedDevice (ControllerHandle,
+ gI2cHwrngDriverBinding.DriverBindingHandle,
+ &gEfiI2cIoProtocolGuid);
+ if (EFI_ERROR (Status)) {
+ return Status;
+ }
+
if (ChildHandle != NULL) {
return EFI_UNSUPPORTED;
}
diff --git a/Silicon/Atmel/AtSha204a/DriverBinding.c b/Silicon/Atmel/AtSha204a/DriverBinding.c
index 38ffd80df9..e278ab0554 100644
--- a/Silicon/Atmel/AtSha204a/DriverBinding.c
+++ b/Silicon/Atmel/AtSha204a/DriverBinding.c
@@ -132,7 +132,6 @@ I2cHwrngDriverBindingStop (
}
-STATIC
EFI_DRIVER_BINDING_PROTOCOL gI2cHwrngDriverBinding = {
I2cHwrngDriverBindingSupported,
I2cHwrngDriverBindingStart,
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 4/4] Silicon/ChaosKeyDxe: Test the ControllerHandle is managed by this driver
2021-10-13 5:36 [PATCH 0/4] SynQuacer drivers test the ControllerHandle correctly Masami Hiramatsu
` (2 preceding siblings ...)
2021-10-13 5:37 ` [PATCH 3/4] Silicon/AtSha204a: " Masami Hiramatsu
@ 2021-10-13 5:37 ` Masami Hiramatsu
2021-10-27 11:21 ` [PATCH 0/4] SynQuacer drivers test the ControllerHandle correctly Leif Lindholm
4 siblings, 0 replies; 10+ messages in thread
From: Masami Hiramatsu @ 2021-10-13 5:37 UTC (permalink / raw)
To: Ard Biesheuvel, Leif Lindholm; +Cc: devel, Kazuhiko Sakamoto
From: Kazuhiko Sakamoto <sakamoto.kazuhiko@socionext.com>
Test the @ControllerHandle is not NULL and is actually managed by
this driver.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Kazuhiko Sakamoto <sakamoto.kazuhiko@socionext.com>
Signed-off-by: Masami Hiramatsu <masami.hiramatsu@linaro.org>
---
Silicon/Openmoko/ChaosKeyDxe/ChaosKeyDriver.h | 1 +
Silicon/Openmoko/ChaosKeyDxe/ComponentName.c | 13 +++++++++++++
Silicon/Openmoko/ChaosKeyDxe/DriverBinding.c | 1 -
3 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/Silicon/Openmoko/ChaosKeyDxe/ChaosKeyDriver.h b/Silicon/Openmoko/ChaosKeyDxe/ChaosKeyDriver.h
index 97cfbbb755..59582b3bf9 100644
--- a/Silicon/Openmoko/ChaosKeyDxe/ChaosKeyDriver.h
+++ b/Silicon/Openmoko/ChaosKeyDxe/ChaosKeyDriver.h
@@ -38,6 +38,7 @@ typedef struct {
CR(a, CHAOSKEY_DEV, Rng, CHAOSKEY_DEV_SIGNATURE)
extern EFI_COMPONENT_NAME2_PROTOCOL gChaosKeyDriverComponentName2;
+extern EFI_DRIVER_BINDING_PROTOCOL gUsbDriverBinding;
EFI_STATUS
ChaosKeyInit (
diff --git a/Silicon/Openmoko/ChaosKeyDxe/ComponentName.c b/Silicon/Openmoko/ChaosKeyDxe/ComponentName.c
index 25117e2500..5b0f42cb67 100644
--- a/Silicon/Openmoko/ChaosKeyDxe/ComponentName.c
+++ b/Silicon/Openmoko/ChaosKeyDxe/ComponentName.c
@@ -159,6 +159,19 @@ ChaosKeyGetControllerName (
OUT CHAR16 **ControllerName
)
{
+ EFI_STATUS Status;
+
+ if (!ControllerHandle) {
+ return EFI_INVALID_PARAMETER;
+ }
+
+ Status = EfiTestManagedDevice (ControllerHandle,
+ gUsbDriverBinding.DriverBindingHandle,
+ &gEfiUsbIoProtocolGuid);
+ if (EFI_ERROR (Status)) {
+ return Status;
+ }
+
if (ChildHandle != NULL) {
return EFI_UNSUPPORTED;
}
diff --git a/Silicon/Openmoko/ChaosKeyDxe/DriverBinding.c b/Silicon/Openmoko/ChaosKeyDxe/DriverBinding.c
index e7d0d3fe56..4cbd23ad36 100644
--- a/Silicon/Openmoko/ChaosKeyDxe/DriverBinding.c
+++ b/Silicon/Openmoko/ChaosKeyDxe/DriverBinding.c
@@ -146,7 +146,6 @@ UsbHwrngDriverBindingStop (
}
-STATIC
EFI_DRIVER_BINDING_PROTOCOL gUsbDriverBinding = {
UsbHwrngDriverBindingSupported,
UsbHwrngDriverBindingStart,
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 0/4] SynQuacer drivers test the ControllerHandle correctly
2021-10-13 5:36 [PATCH 0/4] SynQuacer drivers test the ControllerHandle correctly Masami Hiramatsu
` (3 preceding siblings ...)
2021-10-13 5:37 ` [PATCH 4/4] Silicon/ChaosKeyDxe: " Masami Hiramatsu
@ 2021-10-27 11:21 ` Leif Lindholm
2021-10-27 13:55 ` [edk2-devel] " Samer El-Haj-Mahmoud
2021-10-28 0:53 ` Masami Hiramatsu
4 siblings, 2 replies; 10+ messages in thread
From: Leif Lindholm @ 2021-10-27 11:21 UTC (permalink / raw)
To: Masami Hiramatsu; +Cc: Ard Biesheuvel, devel, Kazuhiko Sakamoto
Hi Masami,
Apologies for delay.
Thank you, this set looks good.
However, you cannot make legal statements on behalf of Sakamoto-san,
only yourself. If you are happy with that, I could drop their
Signed-off-by: statements before I push. They would retain the
authorship.
Best Regards,
Leif
On Wed, Oct 13, 2021 at 14:36:43 +0900, Masami Hiramatsu wrote:
> Hello,
>
> Here are the patches to fix the SynQuacer related drivers to test
> whether the ControllerHandle is managed by that driver correctly.
> These bugs are found by edk2-test.
>
> Thank you,
>
> ---
>
> Kazuhiko Sakamoto (4):
> Silicon/SynQuacerNetsecDxe: Test the ControllerHandle is managed by this driver
> Silicon/SynQuacerI2cDxe: Test the ControllerHandle is managed by this driver
> Silicon/AtSha204a: Test the ControllerHandle is managed by this driver
> Silicon/ChaosKeyDxe: Test the ControllerHandle is managed by this driver
>
>
> Silicon/Atmel/AtSha204a/AtSha204aDriver.h | 1 +
> Silicon/Atmel/AtSha204a/ComponentName.c | 13 +++++++++++++
> Silicon/Atmel/AtSha204a/DriverBinding.c | 1 -
> Silicon/Openmoko/ChaosKeyDxe/ChaosKeyDriver.h | 1 +
> Silicon/Openmoko/ChaosKeyDxe/ComponentName.c | 13 +++++++++++++
> Silicon/Openmoko/ChaosKeyDxe/DriverBinding.c | 1 -
> .../Drivers/Net/NetsecDxe/ComponentName.c | 13 +++++++++++++
> .../Drivers/Net/NetsecDxe/DriverBinding.c | 1 -
> .../SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.h | 1 +
> .../Drivers/SynQuacerI2cDxe/ComponentName.c | 13 +++++++++++++
> .../Drivers/SynQuacerI2cDxe/DriverBinding.c | 2 +-
> .../Drivers/SynQuacerI2cDxe/SynQuacerI2cDxe.h | 1 +
> 12 files changed, 57 insertions(+), 4 deletions(-)
>
> --
> Masami Hiramatsu <masami.hiramatsu@linaro.org>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [edk2-devel] [PATCH 0/4] SynQuacer drivers test the ControllerHandle correctly
2021-10-27 11:21 ` [PATCH 0/4] SynQuacer drivers test the ControllerHandle correctly Leif Lindholm
@ 2021-10-27 13:55 ` Samer El-Haj-Mahmoud
2021-10-27 15:10 ` Leif Lindholm
2021-10-28 0:53 ` Masami Hiramatsu
1 sibling, 1 reply; 10+ messages in thread
From: Samer El-Haj-Mahmoud @ 2021-10-27 13:55 UTC (permalink / raw)
To: devel@edk2.groups.io, leif@nuviainc.com, Masami Hiramatsu
Cc: Ard Biesheuvel, Kazuhiko Sakamoto, Samer El-Haj-Mahmoud
For situations like this, maybe " Co-authored-by" can be used?
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Leif
> Lindholm via groups.io
> Sent: Wednesday, October 27, 2021 7:22 AM
> To: Masami Hiramatsu <masami.hiramatsu@linaro.org>
> Cc: Ard Biesheuvel <Ard.Biesheuvel@arm.com>; devel@edk2.groups.io;
> Kazuhiko Sakamoto <sakamoto.kazuhiko@socionext.com>
> Subject: Re: [edk2-devel] [PATCH 0/4] SynQuacer drivers test the
> ControllerHandle correctly
>
> Hi Masami,
>
> Apologies for delay.
>
> Thank you, this set looks good.
> However, you cannot make legal statements on behalf of Sakamoto-san,
> only yourself. If you are happy with that, I could drop their
> Signed-off-by: statements before I push. They would retain the
> authorship.
>
> Best Regards,
>
> Leif
>
> On Wed, Oct 13, 2021 at 14:36:43 +0900, Masami Hiramatsu wrote:
> > Hello,
> >
> > Here are the patches to fix the SynQuacer related drivers to test
> > whether the ControllerHandle is managed by that driver correctly.
> > These bugs are found by edk2-test.
> >
> > Thank you,
> >
> > ---
> >
> > Kazuhiko Sakamoto (4):
> > Silicon/SynQuacerNetsecDxe: Test the ControllerHandle is managed by
> this driver
> > Silicon/SynQuacerI2cDxe: Test the ControllerHandle is managed by this
> driver
> > Silicon/AtSha204a: Test the ControllerHandle is managed by this driver
> > Silicon/ChaosKeyDxe: Test the ControllerHandle is managed by this
> driver
> >
> >
> > Silicon/Atmel/AtSha204a/AtSha204aDriver.h | 1 +
> > Silicon/Atmel/AtSha204a/ComponentName.c | 13 +++++++++++++
> > Silicon/Atmel/AtSha204a/DriverBinding.c | 1 -
> > Silicon/Openmoko/ChaosKeyDxe/ChaosKeyDriver.h | 1 +
> > Silicon/Openmoko/ChaosKeyDxe/ComponentName.c | 13
> +++++++++++++
> > Silicon/Openmoko/ChaosKeyDxe/DriverBinding.c | 1 -
> > .../Drivers/Net/NetsecDxe/ComponentName.c | 13 +++++++++++++
> > .../Drivers/Net/NetsecDxe/DriverBinding.c | 1 -
> > .../SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.h | 1 +
> > .../Drivers/SynQuacerI2cDxe/ComponentName.c | 13
> +++++++++++++
> > .../Drivers/SynQuacerI2cDxe/DriverBinding.c | 2 +-
> > .../Drivers/SynQuacerI2cDxe/SynQuacerI2cDxe.h | 1 +
> > 12 files changed, 57 insertions(+), 4 deletions(-)
> >
> > --
> > Masami Hiramatsu <masami.hiramatsu@linaro.org>
>
>
>
>
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [edk2-devel] [PATCH 0/4] SynQuacer drivers test the ControllerHandle correctly
2021-10-27 13:55 ` [edk2-devel] " Samer El-Haj-Mahmoud
@ 2021-10-27 15:10 ` Leif Lindholm
0 siblings, 0 replies; 10+ messages in thread
From: Leif Lindholm @ 2021-10-27 15:10 UTC (permalink / raw)
To: Samer El-Haj-Mahmoud
Cc: devel@edk2.groups.io, Masami Hiramatsu, Ard Biesheuvel,
Kazuhiko Sakamoto
There is a case for that tag, but it is not this one.
I'm not asking Masami to drop his S-o-b, and Sakamoto-san maintains
their authorship (via the From: tag) - so both will be acknowledged in
the end result.
On Wed, Oct 27, 2021 at 13:55:56 +0000, Samer El-Haj-Mahmoud wrote:
> For situations like this, maybe " Co-authored-by" can be used?
>
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Leif
> > Lindholm via groups.io
> > Sent: Wednesday, October 27, 2021 7:22 AM
> > To: Masami Hiramatsu <masami.hiramatsu@linaro.org>
> > Cc: Ard Biesheuvel <Ard.Biesheuvel@arm.com>; devel@edk2.groups.io;
> > Kazuhiko Sakamoto <sakamoto.kazuhiko@socionext.com>
> > Subject: Re: [edk2-devel] [PATCH 0/4] SynQuacer drivers test the
> > ControllerHandle correctly
> >
> > Hi Masami,
> >
> > Apologies for delay.
> >
> > Thank you, this set looks good.
> > However, you cannot make legal statements on behalf of Sakamoto-san,
> > only yourself. If you are happy with that, I could drop their
> > Signed-off-by: statements before I push. They would retain the
> > authorship.
> >
> > Best Regards,
> >
> > Leif
> >
> > On Wed, Oct 13, 2021 at 14:36:43 +0900, Masami Hiramatsu wrote:
> > > Hello,
> > >
> > > Here are the patches to fix the SynQuacer related drivers to test
> > > whether the ControllerHandle is managed by that driver correctly.
> > > These bugs are found by edk2-test.
> > >
> > > Thank you,
> > >
> > > ---
> > >
> > > Kazuhiko Sakamoto (4):
> > > Silicon/SynQuacerNetsecDxe: Test the ControllerHandle is managed by
> > this driver
> > > Silicon/SynQuacerI2cDxe: Test the ControllerHandle is managed by this
> > driver
> > > Silicon/AtSha204a: Test the ControllerHandle is managed by this driver
> > > Silicon/ChaosKeyDxe: Test the ControllerHandle is managed by this
> > driver
> > >
> > >
> > > Silicon/Atmel/AtSha204a/AtSha204aDriver.h | 1 +
> > > Silicon/Atmel/AtSha204a/ComponentName.c | 13 +++++++++++++
> > > Silicon/Atmel/AtSha204a/DriverBinding.c | 1 -
> > > Silicon/Openmoko/ChaosKeyDxe/ChaosKeyDriver.h | 1 +
> > > Silicon/Openmoko/ChaosKeyDxe/ComponentName.c | 13
> > +++++++++++++
> > > Silicon/Openmoko/ChaosKeyDxe/DriverBinding.c | 1 -
> > > .../Drivers/Net/NetsecDxe/ComponentName.c | 13 +++++++++++++
> > > .../Drivers/Net/NetsecDxe/DriverBinding.c | 1 -
> > > .../SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.h | 1 +
> > > .../Drivers/SynQuacerI2cDxe/ComponentName.c | 13
> > +++++++++++++
> > > .../Drivers/SynQuacerI2cDxe/DriverBinding.c | 2 +-
> > > .../Drivers/SynQuacerI2cDxe/SynQuacerI2cDxe.h | 1 +
> > > 12 files changed, 57 insertions(+), 4 deletions(-)
> > >
> > > --
> > > Masami Hiramatsu <masami.hiramatsu@linaro.org>
> >
> >
> >
> >
>
> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 0/4] SynQuacer drivers test the ControllerHandle correctly
2021-10-27 11:21 ` [PATCH 0/4] SynQuacer drivers test the ControllerHandle correctly Leif Lindholm
2021-10-27 13:55 ` [edk2-devel] " Samer El-Haj-Mahmoud
@ 2021-10-28 0:53 ` Masami Hiramatsu
2021-11-01 17:16 ` Leif Lindholm
1 sibling, 1 reply; 10+ messages in thread
From: Masami Hiramatsu @ 2021-10-28 0:53 UTC (permalink / raw)
To: Leif Lindholm; +Cc: Ard Biesheuvel, devel, Kazuhiko Sakamoto
Hi Leif,
Thank you for your reply!
2021年10月27日(水) 20:21 Leif Lindholm <leif@nuviainc.com>:
>
> Hi Masami,
>
> Apologies for delay.
>
> Thank you, this set looks good.
> However, you cannot make legal statements on behalf of Sakamoto-san,
> only yourself. If you are happy with that, I could drop their
> Signed-off-by: statements before I push. They would retain the
> authorship.
Actually I got this patch from Sakamoto-san with the Signed-off-by, so I sent
it via my own internal tree. OK, next time I will ask Sakamoto-san to send it
by himself, or just report to me and I write the patch.
Thank you,
>
> Best Regards,
>
> Leif
>
> On Wed, Oct 13, 2021 at 14:36:43 +0900, Masami Hiramatsu wrote:
> > Hello,
> >
> > Here are the patches to fix the SynQuacer related drivers to test
> > whether the ControllerHandle is managed by that driver correctly.
> > These bugs are found by edk2-test.
> >
> > Thank you,
> >
> > ---
> >
> > Kazuhiko Sakamoto (4):
> > Silicon/SynQuacerNetsecDxe: Test the ControllerHandle is managed by this driver
> > Silicon/SynQuacerI2cDxe: Test the ControllerHandle is managed by this driver
> > Silicon/AtSha204a: Test the ControllerHandle is managed by this driver
> > Silicon/ChaosKeyDxe: Test the ControllerHandle is managed by this driver
> >
> >
> > Silicon/Atmel/AtSha204a/AtSha204aDriver.h | 1 +
> > Silicon/Atmel/AtSha204a/ComponentName.c | 13 +++++++++++++
> > Silicon/Atmel/AtSha204a/DriverBinding.c | 1 -
> > Silicon/Openmoko/ChaosKeyDxe/ChaosKeyDriver.h | 1 +
> > Silicon/Openmoko/ChaosKeyDxe/ComponentName.c | 13 +++++++++++++
> > Silicon/Openmoko/ChaosKeyDxe/DriverBinding.c | 1 -
> > .../Drivers/Net/NetsecDxe/ComponentName.c | 13 +++++++++++++
> > .../Drivers/Net/NetsecDxe/DriverBinding.c | 1 -
> > .../SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.h | 1 +
> > .../Drivers/SynQuacerI2cDxe/ComponentName.c | 13 +++++++++++++
> > .../Drivers/SynQuacerI2cDxe/DriverBinding.c | 2 +-
> > .../Drivers/SynQuacerI2cDxe/SynQuacerI2cDxe.h | 1 +
> > 12 files changed, 57 insertions(+), 4 deletions(-)
> >
> > --
> > Masami Hiramatsu <masami.hiramatsu@linaro.org>
--
Masami Hiramatsu
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 0/4] SynQuacer drivers test the ControllerHandle correctly
2021-10-28 0:53 ` Masami Hiramatsu
@ 2021-11-01 17:16 ` Leif Lindholm
0 siblings, 0 replies; 10+ messages in thread
From: Leif Lindholm @ 2021-11-01 17:16 UTC (permalink / raw)
To: Masami Hiramatsu; +Cc: Ard Biesheuvel, devel, Kazuhiko Sakamoto
On Thu, Oct 28, 2021 at 09:53:34 +0900, Masami Hiramatsu wrote:
> Hi Leif,
>
> Thank you for your reply!
>
> 2021年10月27日(水) 20:21 Leif Lindholm <leif@nuviainc.com>:
> >
> > Hi Masami,
> >
> > Apologies for delay.
> >
> > Thank you, this set looks good.
> > However, you cannot make legal statements on behalf of Sakamoto-san,
> > only yourself. If you are happy with that, I could drop their
> > Signed-off-by: statements before I push. They would retain the
> > authorship.
>
> Actually I got this patch from Sakamoto-san with the Signed-off-by, so I sent
> it via my own internal tree. OK, next time I will ask Sakamoto-san to send it
> by himself, or just report to me and I write the patch.
>
> Thank you,
For the series:
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
Pushed as 06489b36ab34..a4f52afa363c.
(I also dropped the Contributed-under: tags - we stopped using those
after the license transition to bsd+patent.)
Best Regards,
Leif
> >
> > Best Regards,
> >
> > Leif
> >
> > On Wed, Oct 13, 2021 at 14:36:43 +0900, Masami Hiramatsu wrote:
> > > Hello,
> > >
> > > Here are the patches to fix the SynQuacer related drivers to test
> > > whether the ControllerHandle is managed by that driver correctly.
> > > These bugs are found by edk2-test.
> > >
> > > Thank you,
> > >
> > > ---
> > >
> > > Kazuhiko Sakamoto (4):
> > > Silicon/SynQuacerNetsecDxe: Test the ControllerHandle is managed by this driver
> > > Silicon/SynQuacerI2cDxe: Test the ControllerHandle is managed by this driver
> > > Silicon/AtSha204a: Test the ControllerHandle is managed by this driver
> > > Silicon/ChaosKeyDxe: Test the ControllerHandle is managed by this driver
> > >
> > >
> > > Silicon/Atmel/AtSha204a/AtSha204aDriver.h | 1 +
> > > Silicon/Atmel/AtSha204a/ComponentName.c | 13 +++++++++++++
> > > Silicon/Atmel/AtSha204a/DriverBinding.c | 1 -
> > > Silicon/Openmoko/ChaosKeyDxe/ChaosKeyDriver.h | 1 +
> > > Silicon/Openmoko/ChaosKeyDxe/ComponentName.c | 13 +++++++++++++
> > > Silicon/Openmoko/ChaosKeyDxe/DriverBinding.c | 1 -
> > > .../Drivers/Net/NetsecDxe/ComponentName.c | 13 +++++++++++++
> > > .../Drivers/Net/NetsecDxe/DriverBinding.c | 1 -
> > > .../SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.h | 1 +
> > > .../Drivers/SynQuacerI2cDxe/ComponentName.c | 13 +++++++++++++
> > > .../Drivers/SynQuacerI2cDxe/DriverBinding.c | 2 +-
> > > .../Drivers/SynQuacerI2cDxe/SynQuacerI2cDxe.h | 1 +
> > > 12 files changed, 57 insertions(+), 4 deletions(-)
> > >
> > > --
> > > Masami Hiramatsu <masami.hiramatsu@linaro.org>
>
>
>
> --
> Masami Hiramatsu
^ permalink raw reply [flat|nested] 10+ messages in thread