From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f41.google.com (mail-io1-f41.google.com [209.85.166.41]) by mx.groups.io with SMTP id smtpd.web11.33558.1637999337712542111 for ; Fri, 26 Nov 2021 23:48:58 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=jsxiTaQt; spf=pass (domain: linaro.org, ip: 209.85.166.41, mailfrom: masami.hiramatsu@linaro.org) Received: by mail-io1-f41.google.com with SMTP id c3so14220059iob.6 for ; Fri, 26 Nov 2021 23:48:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=FfK11nLlqS2mEdVX5NWirFu7IBPxXNZW/dZ5rVL250A=; b=jsxiTaQtQdU9cAnRhrcl+wfuNaw3OLRfvy72UnKJx0nhhG7dIRfVjufDBhpwugDI0k CF9pJmgl4dy/TzPWRyn7YRX2B0Xyg5MHVaqmwN6nVleJOlMFcRUtxe04CUUrsiHjDZJG c2/1z3lAMvvLZyPev37zrx/FW6ljV0jkzak3na7oKHJc1BSHrhmsaHwn4jk13Qx6Yizj vQY5gTT9nuVSdkTqVz9YiR9jbw/5FkT2cx0/cokctay3v3mX+JNjGEiW78eFmt9fY/Rk cJLYv+Y/Er5CiTXmhCrcRSw2z6+Grl7VVdNmEKxGf+frM8Le3Uv9AZ1zTCSWGiV0Dk/a VMKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=FfK11nLlqS2mEdVX5NWirFu7IBPxXNZW/dZ5rVL250A=; b=mvoWntGmJSr/BVtGqec2dCYCgsMYiu9K6XC1JRH8Dt6E6RUztwxCdnW7NFh7ZwguQP 0VmQwK9R92+rBu1Roguq2yjibQAxi1xEC4fVXM8vT8vFFYsIKDpuqzzXeHW75QfhDpMJ fCdRk5MsRD7jW9g5tjpF0/OYOzra7bFjkQKVrLBOxgbYySqu0i+l2QMKlvtIhu8OouoL ZvA2oBrmSjeFtADe7MwlwHG/HzOSasEdMGJCIxbp4B8DjGkPB7OOrfBlW1RP023RucKf xjm1/oqZFkGJznctkn9J6X4M65RlCpvylYK8cumN12TtZVaMR3CU/h9sWhcRrD/a0JgA UsbA== X-Gm-Message-State: AOAM533vYsdby8EWAeEbcW1WxbGBVbr4ddwNyzdh2+orJK0fBTeZkpSS zn6wePI+4Fl4Xn+XmytKk1LwuQ847pnPyM40ja22lA== X-Google-Smtp-Source: ABdhPJzZe//4Fqt3mzuo3ad4//uKE1Iw7TQ7UEMI6lEb9lJc7nwu8oaYKXqueOOTa8RzSsZ4Y4xHPYRH0HFnpIiQa60= X-Received: by 2002:a05:6638:3183:: with SMTP id z3mr51032148jak.108.1637999336859; Fri, 26 Nov 2021 23:48:56 -0800 (PST) MIME-Version: 1.0 References: <163610419943.391624.9289897029386201296.stgit@localhost> <163610424153.391624.15870608392900932158.stgit@localhost> In-Reply-To: From: "Masami Hiramatsu" Date: Sat, 27 Nov 2021 16:48:45 +0900 Message-ID: Subject: Re: [PATCH 5/5] [edk2-platforms] Platform/DeveloperBox: Expand NvStorage sizes To: Leif Lindholm Cc: Ard Biesheuvel , devel@edk2.groups.io, Kazuhiko Sakamoto , Masahisa Kojima Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Leif, 2021=E5=B9=B411=E6=9C=8827=E6=97=A5(=E5=9C=9F) 3:19 Leif Lindholm : > > On Fri, Nov 05, 2021 at 18:24:01 +0900, Masami Hiramatsu wrote: > > Expand NvStorage Variable size and FTW spare/working size > > for the DeveloperBox platform. > > > > Since the size of the NvStorage VariableSize is not enough > > large, FWTS uefirttime test, which updates the NV > > variables in runtime, failes. This expands the size to fix > > this issue. > > Does this change erase all existing variables? Ah, indeed. It may need to erase all variables. > > If so, I think it is worth introducing this as a non-default build > option, in order to not wreck existing installations on a firmware > update. > > I think it would also be worth considering whether to update > PcdLowestSupportedFirmwareVersion. PcdFirmwareRevision > should definitely be updated. I'm not sure about this point. You meant we should have 2 different revisions like a branch? - Branch A(current version): keep the variable area size the same. - Branch B(new version): expand the variable area. And a build option will change the branch by updating the PcdFirmwareRevision? Also PcdLowestSupportedFirmwareVersion you meant is in the capsule file? Thank you, > > / > Leif > > > Signed-off-by: Masami Hiramatsu > > Reported-by: Kazuhiko Sakamoto > > --- > > .../Socionext/DeveloperBox/DeveloperBox.dsc.inc | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc b/Pla= tform/Socionext/DeveloperBox/DeveloperBox.dsc.inc > > index 0a364bc457..3baf97ecc0 100644 > > --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc > > +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc > > @@ -280,11 +280,11 @@ > > gFip006DxeTokenSpaceGuid.PcdFip006DxeMemBaseAddress|0x08000000 > > > > gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase|0x08400= 000 > > - gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize|0x00010= 000 > > - gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingBase|0x084= 10000 > > - gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingSize|0x000= 10000 > > - gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareBase|0x08420= 000 > > - gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareSize|0x00010= 000 > > + gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize|0x00080= 000 > > + gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingBase|0x084= 80000 > > + gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingSize|0x000= 80000 > > + gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareBase|0x08500= 000 > > + gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareSize|0x00080= 000 > > > > gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemId|"SNI " > > gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemTableId|0x5243415551= 4e5953 # SYNQUACR > > --=20 Masami Hiramatsu