From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-io1-f42.google.com (mail-io1-f42.google.com [209.85.166.42])
 by mx.groups.io with SMTP id smtpd.web12.9126.1639386925990119469
 for <devel@edk2.groups.io>;
 Mon, 13 Dec 2021 01:15:26 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=RS/bXEaT;
 spf=pass (domain: linaro.org, ip: 209.85.166.42, mailfrom: masami.hiramatsu@linaro.org)
Received: by mail-io1-f42.google.com with SMTP id q72so17658848iod.12
        for <devel@edk2.groups.io>; Mon, 13 Dec 2021 01:15:25 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc:content-transfer-encoding;
        bh=Q+d2af8NcqK3py97ZYi/xY4WqoZP7j5DtxRON9Qc7nY=;
        b=RS/bXEaT+bw1/daQNmvDBSZ4ZZIJjHC+3b/Um/8/5tSFzi75OwUWOfNetSabhPf1EN
         zq4YTdCMrPcHm+QnxXvWcj4fxe9txgP2W44sQcLYfOJw7LfVOYRzBLSPda9hkcoUoEZe
         TstN5frcVZz42LAjrj+Um8pp10zwI+zHrEEPQLNSKXPpmARc8m4VPYmQJRgm7+XeLd7V
         R+cC4n7DzZn/zKZjDb586IxB+V12reqCdkSj8ORgYwMmH4RYxfOwObTZhHOnW5ntVeuR
         AYIW2/rXFKzvJKw0KNe59HqpX/66M3M91RbZu2qj2OLu3lJ5ONcTrgY/cIZEhm93nvDG
         ItHA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc:content-transfer-encoding;
        bh=Q+d2af8NcqK3py97ZYi/xY4WqoZP7j5DtxRON9Qc7nY=;
        b=KELBWPCktOl+PcdVj9vcDhd/fwQjFj461eKd0OtJoKDOPSJF4HZIwC6d75j46Z0Pet
         MvwcF+Q0yDOdmUov6hgdkVw2LQxNbk/myC9K6foX3C/N7m4TlaBZM7kq+4SkmrfE3B1U
         tzH1/ReR31jqR79SWTERxDgshVd27iOSwkFZTTXoPWU1Z+Mn5VxTDZJvWXUW6pmunBgp
         a0zFgVzQFyLt6jxT86FdiKNOmqGMArfzK/awGvLbMDaBds6w/rSc8gztRxwaEW8FCt9K
         fctqQKK8uCpj/kHOVXfDFcCV8gF8C8U2mNljE46GDOaHeEYx/HZWPn5BgpGUq08pdxuz
         cK5w==
X-Gm-Message-State: AOAM533qzF3gul3QWYHcq50atnLTAzBcrvDQ9zyeOWzOKz/fCbgYE2cK
	nrTVAafGYw/I07uD8LSNlZ8C7pXs2ldnaZvC76u53obKBGS7Ew==
X-Google-Smtp-Source: ABdhPJwWchMH/mIxJ1O1UJDPY7ny+U0+BLwiOyTR9M20vSqMMJJBz44XzyKMEa4U3MKJphtrlPnkiK49JUcPDeQNBA0=
X-Received: by 2002:a05:6602:2c50:: with SMTP id x16mr31970625iov.114.1639386925145;
 Mon, 13 Dec 2021 01:15:25 -0800 (PST)
MIME-Version: 1.0
References: <163911902995.561661.9429300579159746333.stgit@localhost> <16BF521F7F10ACBB.29912@groups.io>
In-Reply-To: <16BF521F7F10ACBB.29912@groups.io>
From: "Masami Hiramatsu" <masami.hiramatsu@linaro.org>
Date: Mon, 13 Dec 2021 18:15:14 +0900
Message-ID: <CAA93ih1hQMch51Za3nsf5rPyXFL81O0QCFBt_bqgQjNWeyJqkA@mail.gmail.com>
Subject: Re: [edk2-devel] [PATCH v3 6/6] [edk2-platforms] Platform/DeveloperBox: Expand NvStorage sizes
To: devel@edk2.groups.io, masami.hiramatsu@linaro.org
Cc: Ard Biesheuvel <ardb@kernel.org>, Leif Lindholm <leif@nuviainc.com>, 
	Kazuhiko Sakamoto <sakamoto.kazuhiko@socionext.com>, 
	Masahisa Kojima <masahisa.kojima@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

2021=E5=B9=B412=E6=9C=8810=E6=97=A5(=E9=87=91) 15:51 Masami Hiramatsu via g=
roups.io
<masami.hiramatsu=3Dlinaro.org@groups.io>:

> --- a/Silicon/Socionext/SynQuacer/SynQuacer.dec
> +++ b/Silicon/Socionext/SynQuacer/SynQuacer.dec
> @@ -41,7 +41,11 @@
>    gSynQuacerTokenSpaceGuid.PcdI2cReferenceClock|62500000|UINT32|0x000000=
05
>
>    # for capsule update
> +!if $(EXPAND_NVSTORAGE) =3D=3D 1
> +  gSynQuacerTokenSpaceGuid.PcdLowestSupportedFirmwareVersion|1|UINT32|0x=
00000400
> +!else
>    gSynQuacerTokenSpaceGuid.PcdLowestSupportedFirmwareVersion|1|UINT32|0x=
00000009
> +!endif

Oops, this may cause a build error.

build.py...
/home/mhiramat/firmware/edk2-platforms/Silicon/Socionext/SynQuacer/SynQuace=
r.dec(44):
error 3000: No token space GUID or PCD name specified
!if $(EXPAND_NVSTORAGE) =3D=3D 1
(<TokenSpaceGuidCName>.<PcdCName>|<DefaultValue>|<DatumType>|<Token>)

Can't we use any macros in .dec file?

Thank you,

>
>    # for SMBIOS Type17
>    gSynQuacerTokenSpaceGuid.PcdStoredSpdDDR4Address|0|UINT32|0x0000000A
>
>
>
>=20
>
>


--=20
Masami Hiramatsu