From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f171.google.com (mail-il1-f171.google.com [209.85.166.171]) by mx.groups.io with SMTP id smtpd.web08.32876.1637988202173148231 for ; Fri, 26 Nov 2021 20:43:22 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=FdfiihZ1; spf=pass (domain: linaro.org, ip: 209.85.166.171, mailfrom: masami.hiramatsu@linaro.org) Received: by mail-il1-f171.google.com with SMTP id 15so1934390ilq.2 for ; Fri, 26 Nov 2021 20:43:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=YVaAbZyou0d7Be9yIyzIZFZpjZmpLVEvBR6VMrksfTs=; b=FdfiihZ1nOVgqonUqMq7DuMeEM+q3a6E4jhuOGOeNSwcHNmZj0wlNk1WqLvdv6qWTr lPUONV/dggj5eBR30C9dlYAJAz0ipr0nwIkUHuZSOF7co2EO0RVqNaLZdhy/AuYRi414 WMowXLKAjAHy38SCzY4FgGKEGy7Zcp3sbwS+V/1+fsA++1ajVriDbMvLfBlMAzV4vjJb UFS9N1umJmPKcSTg3kUb2IS3hpVI8YdRMZo7ZM/Z3YZGKec6YKynqjNR4m1YsCsuj4tv EMwpL9RlnbY9kkp8/Bm3BwwlIPY+Wwc+g50ef+E3p79HOERthzCajDo4v7Vx2MKHj642 EJrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=YVaAbZyou0d7Be9yIyzIZFZpjZmpLVEvBR6VMrksfTs=; b=wRiZJJD77oeiBTRG6WDdruDG+hl5ELw7Uf40fnG/UmroGFEJkydo5ObkXchNc44XEM DeyEDyI3+Pm1GjiBYnvyiuQeMSq3V4mn/k+SluhloKccA9wmGY4HIH+P0HmZymQyXYCn sUuE5piht86IqaKZbd6XjrA8Hhq6b6k4pzkVrJpwbnmYGOS2SSB+Mzcf1xojMzciQqOu w3WEruv7avTvLZy4JEJ2SDBMaXpbVNSqNzHr5DluFRwX4opzaNl1eYsL2PmPnu97rbzc QEHkfvXrhtH9jvZGeGfbUw+5QSz0MAPEGWL/AyaQh50rFUjUBdTzCzcsv8Q05ejEarM0 /DcA== X-Gm-Message-State: AOAM533g/0ZBA8HJyeOei0qbZIXEQ3FEh4sZzent163wv5/p4CiRBfTe 3VLRkR3SCEoXxnbxooW6wu6Pq9qe7+LLyVTqnD3z5Z/t1bc= X-Google-Smtp-Source: ABdhPJwykVNPQY+Nd7iWg0z1LNv/0ECVaUxArFC/WFGM9Dot5TOC+GRRwhPaAF+Fk111OtA+PlAXa3yPAPOCsX8a46g= X-Received: by 2002:a05:6e02:198e:: with SMTP id g14mr39433521ilf.204.1637988201330; Fri, 26 Nov 2021 20:43:21 -0800 (PST) MIME-Version: 1.0 References: <163610419943.391624.9289897029386201296.stgit@localhost> <163610421657.391624.390954447741641256.stgit@localhost> In-Reply-To: From: "Masami Hiramatsu" Date: Sat, 27 Nov 2021 13:43:10 +0900 Message-ID: Subject: Re: [PATCH 2/5] [edk2-platforms] Silicon/Socionext/SynQuacer: Fix GenericWatchdog interrupt number To: Leif Lindholm Cc: Ard Biesheuvel , devel@edk2.groups.io, Kazuhiko Sakamoto , Masahisa Kojima Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Leif, 2021=E5=B9=B411=E6=9C=8827=E6=97=A5(=E5=9C=9F) 2:50 Leif Lindholm : > > On Fri, Nov 05, 2021 at 18:23:36 +0900, Masami Hiramatsu wrote: > > This fixes Socionext DeveloperBox GenericWatchdog interrupt > > number to 93 instead of 94. Since the 93 is the default interrupt > > number defined in ArmPkg/ArmPkg.dec, this doesn't redefine > > gArmTokenSpaceGuid.PcdGenericWatchdogEl2IntrNum. > > > > That is one thing this patch does. > > > Signed-off-by: Masami Hiramatsu > > Reported-by: Kazuhiko Sakamoto > > --- > > .../Socionext/SynQuacer/AcpiTables/AcpiTables.inf | 1 + > > Silicon/Socionext/SynQuacer/AcpiTables/Gtdt.aslc | 6 +++--- > > 2 files changed, 4 insertions(+), 3 deletions(-) > > > > diff --git a/Silicon/Socionext/SynQuacer/AcpiTables/AcpiTables.inf b/Si= licon/Socionext/SynQuacer/AcpiTables/AcpiTables.inf > > index 96efb2d38e..886777a0fa 100644 > > --- a/Silicon/Socionext/SynQuacer/AcpiTables/AcpiTables.inf > > +++ b/Silicon/Socionext/SynQuacer/AcpiTables/AcpiTables.inf > > @@ -50,6 +50,7 @@ > > > > gArmTokenSpaceGuid.PcdGenericWatchdogControlBase > > gArmTokenSpaceGuid.PcdGenericWatchdogRefreshBase > > + gArmTokenSpaceGuid.PcdGenericWatchdogEl2IntrNum > > > > gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemRevision > > gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultCreatorRevision > > diff --git a/Silicon/Socionext/SynQuacer/AcpiTables/Gtdt.aslc b/Silicon= /Socionext/SynQuacer/AcpiTables/Gtdt.aslc > > index c811fc5a0c..b045a49efa 100644 > > --- a/Silicon/Socionext/SynQuacer/AcpiTables/Gtdt.aslc > > +++ b/Silicon/Socionext/SynQuacer/AcpiTables/Gtdt.aslc > > @@ -74,9 +74,9 @@ EFI_ACPI_6_0_GENERIC_TIMER_DESCRIPTION_TABLES Gtdt = =3D { > > // UINT32 GTxCommonF= lags > > }, > > EFI_ACPI_6_0_SBSA_GENERIC_WATCHDOG_STRUCTURE_INIT ( > > - FixedPcdGet32 (PcdGenericWatchdogRefreshBase), > > - FixedPcdGet32 (PcdGenericWatchdogControlBase), > > - 94, > > + FixedPcdGet64 (PcdGenericWatchdogRefreshBase), > > + FixedPcdGet64 (PcdGenericWatchdogControlBase), > > But it also changes these two FixedPcdGet32 calls to FixedPcdGet64. > That should be a separate patch. OK, I'll make it a separate patch. Thank you, > > / > Leif > > > + FixedPcdGet32 (PcdGenericWatchdogEl2IntrNum), > > 0), > > }; > > > > --=20 Masami Hiramatsu