From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-oi1-f169.google.com (mail-oi1-f169.google.com [209.85.167.169])
 by mx.groups.io with SMTP id smtpd.web10.13714.1689320921193362694
 for <devel@edk2.groups.io>;
 Fri, 14 Jul 2023 00:48:41 -0700
Authentication-Results: mx.groups.io;
 dkim=fail reason="signature has expired" header.i=@ventanamicro.com header.s=google header.b=aOMl9Jlk;
 spf=pass (domain: ventanamicro.com, ip: 209.85.167.169, mailfrom: rsingh@ventanamicro.com)
Received: by mail-oi1-f169.google.com with SMTP id 5614622812f47-3a3c77e0154so1251843b6e.1
        for <devel@edk2.groups.io>; Fri, 14 Jul 2023 00:48:41 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=ventanamicro.com; s=google; t=1689320920; x=1691912920;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=8NlCSBYt0rji+n4negKBHRiquePQUhDHYobjbWJpKTQ=;
        b=aOMl9JlkHnXhQvrf3laswx8hQPaQtVd94RdnoCqLBDX6/b4N5cNx6fToQ+kvVU8gVa
         Q56vwo1gi3zb6ZdsYGqZg4vR7nBgl9XKDYwpEglvqlSd4yAGuMEwpmtm3UBPRoKK4G8w
         x/0DlnbcHNN+3ZpERfzF2ufM/8Kk5wrhM1tGUARTeo8wcN2GvUh+L8ExF3pzWWIem2aG
         PwntkEOuJB7aSzZ+UXH8BzF2HzDZkWsg9nMV3+/kXtQCxobPFr/EtgyNO99aD3y6sNgx
         jhcrRkfY4cyrmG0k/MW5Sdim/KZK103NDSA1uixjHtlacs41h8xJd/UYxNJGf3sz6+pi
         KMpw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20221208; t=1689320920; x=1691912920;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=8NlCSBYt0rji+n4negKBHRiquePQUhDHYobjbWJpKTQ=;
        b=Z6/8XqWqpEfgZ7kgTYaDcmcckz41YkhUl1JhCkLvy28Xzh+x/f84deRqdl/bLJpFaB
         Nk1HDM036QcAOjx0cpx/w36563yni26FngY0XYIb5jxqWJyWaqyL2IHW9fkFY8Por/bS
         oo3nTWanK+Z0oPYdAImsP3MUvRyuVBnq1pSqJ3gmd0nHJuVV1CnOs3uhwE7SOGTH4ahF
         kJ+ranOR2hvYAkcpkzJVCqSI+KdpF1MWjYyx6h825BuGog3HYN8KStAOMr6M6h/mkSa2
         bKu21ueol84GEvNdBwCOH8ZTpLipw77YtxpYcZAIst/xjeC39PEtDrhYwBAtBJqggk9i
         J+dg==
X-Gm-Message-State: ABy/qLZXhHhyCvKnFgwBKNLhoEAQIpW/yvEzrfXGxzge90OPx3mjrTJm
	v0Ltdqa5j57IRoZl8GMYwNCVffWpqsApvkPmzYNrLmUv/6/L/e/0
X-Google-Smtp-Source: APBJJlHJqmXwWIEGwH44+t+KFNYLzxBUGeUluVcWAE31+UB+w0wS0RFbpR679+UfnZZqE0oyLPeHQW3RSMSZKGo2pi8=
X-Received: by 2002:a05:6358:919f:b0:134:ed9b:15a7 with SMTP id
 j31-20020a056358919f00b00134ed9b15a7mr4339098rwa.30.1689320920403; Fri, 14
 Jul 2023 00:48:40 -0700 (PDT)
MIME-Version: 1.0
References: <20230713164715.1734745-1-rsingh@ventanamicro.com>
 <20230713164715.1734745-3-rsingh@ventanamicro.com> <DM6PR11MB402587029369B19115F6E875CA34A@DM6PR11MB4025.namprd11.prod.outlook.com>
In-Reply-To: <DM6PR11MB402587029369B19115F6E875CA34A@DM6PR11MB4025.namprd11.prod.outlook.com>
From: Ranbir Singh <rsingh@ventanamicro.com>
Date: Fri, 14 Jul 2023 13:18:29 +0530
Message-ID: <CAA9DWXAuPsDg56qJ6ipukeG7xOd=6BBO_dAZ0R5zHUc-iVPMjA@mail.gmail.com>
Subject: Re: [PATCH v3 2/2] MdeModulePkg/Bus/Ata/AtaAtapiPassThru: Fix UNUSED_VALUE Coverity issue
To: "Wu, Hao A" <hao.a.wu@intel.com>
Cc: Ard Biesheuvel <ardb@kernel.org>, "devel@edk2.groups.io" <devel@edk2.groups.io>, "Ni, Ray" <ray.ni@intel.com>
Content-Type: multipart/alternative; boundary="0000000000005f6a4606006dada9"

--0000000000005f6a4606006dada9
Content-Type: text/plain; charset="UTF-8"

>
> To please both sides, how about:
> 1. Remove the 'Status' assignment of the return value from
> SetDriveParameters()
> Based on my findings (https://edk2.groups.io/g/devel/message/106844), the
> successful execution of SetDriveParameters() is not mandatory for
> initializing
> IDE mode hard disk device.
>

Interestingly, my very first patch for this began with this approach only.


> 2. Add DEBUG_WARN level debug message within SetDriveParameters() function
> In function SetDriveParameters, for the 2 calls of AtaNonDataCommandIn (one
> for the INITIALIZE DEVICE PARAMETERS command and the other for SET MULTIPLE
> MODE command), if the return status is not EFI_SUCCESS, add debug message
> to
> display the information.
>

These can be added if desired so.

--0000000000005f6a4606006dada9
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_quote"><blockquote class=3D"gmail_quot=
e" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204)=
;padding-left:1ex">To please both sides, how about:<br>
1. Remove the &#39;Status&#39; assignment of the return value from SetDrive=
Parameters()<br>
Based on my findings (<a href=3D"https://edk2.groups.io/g/devel/message/106=
844" rel=3D"noreferrer" target=3D"_blank">https://edk2.groups.io/g/devel/me=
ssage/106844</a>), the<br>
successful execution of SetDriveParameters() is not mandatory for initializ=
ing<br>
IDE mode hard disk device.<br></blockquote><div><br></div><div>Interestingl=
y, my very first patch for this began with this approach only.</div><div>=
=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0=
.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">2. Add DEBUG_=
WARN level debug message within SetDriveParameters() function<br>
In function SetDriveParameters, for the 2 calls of AtaNonDataCommandIn (one=
<br>
for the INITIALIZE DEVICE PARAMETERS command and the other for SET MULTIPLE=
<br>
MODE command), if the return status is not EFI_SUCCESS, add debug message t=
o<br>
display the information.<br></blockquote><div><br></div><div>These can be a=
dded if desired so.</div><div>=C2=A0</div></div></div>

--0000000000005f6a4606006dada9--