Hi Oliver,

Thanks for reviving the thread.

Fact of the matter is - I do not work in Dell anymore which is when the original set of patches were generated and also tested that Coverity flagged warnings/issues/errors indeed vanishes after applying the set of patches.

While I was there, I did not have the means to post the patches to the EDK2 Mailing list. Just to not let all those efforts go to waste, when it later became feasible for me, I sent out the patches for review. But now, I do not have any means to run the code through Coverity scan. Without that I can't guarantee that any further code change will achieve the aim with which the original set of patches were sent. If that's acceptable to you, I will try to put up a PR when possible.

Best Regards,
Ranbir Singh

On Fri, Jan 3, 2025 at 3:08 AM Oliver Smith-Denny <osde@linux.microsoft.com> wrote:
Hi Ranbir and Veeresh,

On 11/6/2023 10:28 PM, Ranbir Singh wrote:
> v1 -> v2:
>    - Rebased to latest master HEAD
>
> Ranbir Singh (2):
>    FatPkg/EnhancedFatDxe: Fix SIGN_EXTENSION Coverity issues
>    FatPkg/EnhancedFatDxe: Fix OVERFLOW_BEFORE_WIDEN Coverity issue
>
>   FatPkg/EnhancedFatDxe/DirectoryManage.c | 4 ++--
>   FatPkg/EnhancedFatDxe/DiskCache.c       | 2 +-
>   2 files changed, 3 insertions(+), 3 deletions(-)
>

I see that this patch was never merged (I don't see any response to
Laszlo's comments, which I agree with) but the GH issue is open:
https://github.com/tianocore/edk2/issues/10318.

If you want to put up a PR to address this issue, taking into account
Laszlo's review, please do so.

Thanks,
Oliver
_._,_._,_
Groups.io Links:

You receive all messages sent to this group.

View/Reply Online (#120957) | | Mute This Topic | New Topic
Your Subscription | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_