From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 3AB3594133E for ; Mon, 6 Jan 2025 06:32:44 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=cqvTjNc3vGMG23IKBGAl3a3Dcf6CiXXT/1eGDdrosGU=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240830; t=1736145163; v=1; x=1736404362; b=AvoXne+sjtLSvCAotFavF+Pkgpy1qD5P8jV6BwcoUhYfPIVXayBCuM8mDkQjCC2sWlUKWwGp QKtBEZlAqMwCC+htOvdPTlRt6EC1rn43Rhuao07tSXv7ECrxgHWUiE4dzwUnhF9KmMqfPZMjsMY EYCTDz1vG4WuoT6tpG+49uWbQ3eQC4FM4WULVEuHT93DEX2EZYYsiopxonWNy4G60FsXamYmji1 PI1qWPXRS4tJgJ6V4cVOvHGM84qmiOqHgZDECCWHxMVUVQzq/uhQjT7/LKaNjbq7fTPRI5BBHyB S9Qx1Ymhw3KbQeI3uj2njcvkNq1oqOkbHJM9L1gjWrRww== X-Received: by 127.0.0.2 with SMTP id qNmiYY7687511x47CAWxCj1p; Sun, 05 Jan 2025 22:32:42 -0800 X-Received: from mail-vs1-f43.google.com (mail-vs1-f43.google.com [209.85.217.43]) by mx.groups.io with SMTP id smtpd.web11.54127.1736145161626459457 for ; Sun, 05 Jan 2025 22:32:41 -0800 X-Received: by mail-vs1-f43.google.com with SMTP id ada2fe7eead31-4afe6a8d2e1so7533720137.1 for ; Sun, 05 Jan 2025 22:32:41 -0800 (PST) X-Gm-Message-State: 0DBGbz5kwEkuC0nnoC5TS2RKx7686176AA= X-Gm-Gg: ASbGncsut++PH65+f6AiYANKIv+NKxESwG9Ht6lLouelqIsvup45sDaMtXyuYzHcit9 G4+7n6sLv2KumQRerAsWcvRmVPu5HFwNHf7yCOwwmK7rmJ8ywizRV7ApiMFLFAeAUdF78y0g= X-Google-Smtp-Source: AGHT+IEaxYX+4kGqiPUdFxwZHIixh8c+Db45v+oss2qsSll26QMdIKLt2ubRdmbAyXewn2dmq+GtVAPmzyrysycnERM= X-Received: by 2002:a05:6102:1623:b0:4b2:9eee:666e with SMTP id ada2fe7eead31-4b2cd6e373bmr41382214137.4.1736145160623; Sun, 05 Jan 2025 22:32:40 -0800 (PST) MIME-Version: 1.0 References: <20231107062842.116670-1-rsingh@ventanamicro.com> <34f547bd-a5c0-40ac-b2b8-ef6e95301368@linux.microsoft.com> In-Reply-To: <34f547bd-a5c0-40ac-b2b8-ef6e95301368@linux.microsoft.com> From: "Ranbir Singh" Date: Mon, 6 Jan 2025 12:02:29 +0530 Message-ID: Subject: Re: [edk2-devel] [PATCH v2 0/2] BZ 4249: Fix FatPkg/EnhancedFatDxe issues pointed by Coverity To: Oliver Smith-Denny Cc: devel@edk2.groups.io, veeresh.sangolli@dellteam.com, Ranbir.Singh3@dell.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Sun, 05 Jan 2025 22:32:41 -0800 Resent-From: rsingh@ventanamicro.com Reply-To: devel@edk2.groups.io,rsingh@ventanamicro.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: multipart/alternative; boundary="00000000000093ecd2062b03cbbf" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240830 header.b=AvoXne+s; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io --00000000000093ecd2062b03cbbf Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Oliver, Thanks for reviving the thread. Fact of the matter is - I do not work in Dell anymore which is when the original set of patches were generated and also tested that Coverity flagged warnings/issues/errors indeed vanishes after applying the set of patches. While I was there, I did not have the means to post the patches to the EDK2 Mailing list. Just to not let all those efforts go to waste, when it later became feasible for me, I sent out the patches for review. But now, I do not have any means to run the code through Coverity scan. Without that I can't guarantee that any further code change will achieve the aim with which the original set of patches were sent. If that's acceptable to you, I will try to put up a PR when possible. Best Regards, Ranbir Singh On Fri, Jan 3, 2025 at 3:08=E2=80=AFAM Oliver Smith-Denny wrote: > Hi Ranbir and Veeresh, > > On 11/6/2023 10:28 PM, Ranbir Singh wrote: > > v1 -> v2: > > - Rebased to latest master HEAD > > > > Ranbir Singh (2): > > FatPkg/EnhancedFatDxe: Fix SIGN_EXTENSION Coverity issues > > FatPkg/EnhancedFatDxe: Fix OVERFLOW_BEFORE_WIDEN Coverity issue > > > > FatPkg/EnhancedFatDxe/DirectoryManage.c | 4 ++-- > > FatPkg/EnhancedFatDxe/DiskCache.c | 2 +- > > 2 files changed, 3 insertions(+), 3 deletions(-) > > > > I see that this patch was never merged (I don't see any response to > Laszlo's comments, which I agree with) but the GH issue is open: > https://github.com/tianocore/edk2/issues/10318. > > If you want to put up a PR to address this issue, taking into account > Laszlo's review, please do so. > > Thanks, > Oliver > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120957): https://edk2.groups.io/g/devel/message/120957 Mute This Topic: https://groups.io/mt/102438361/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --00000000000093ecd2062b03cbbf Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Oliver,

Thanks for reviving the thre= ad.

Fact of the matter is - I do not work in Dell = anymore which is when the original set of patches were generated and also t= ested that Coverity flagged warnings/issues/errors indeed=C2=A0vanishes aft= er applying the set of patches.

While I was there,= I did not have the means to post the patches to the EDK2 Mailing list. Jus= t to not let all those efforts go to waste, when it later became feasible= =C2=A0for me, I sent out the patches for review. But now, I do not have any= means to run the code through Coverity scan. Without that I can't guar= antee that any further code change will achieve the aim with which=C2=A0the= original set of patches were sent. If that's acceptable to you, I will= try to put up a PR when possible.

Best=C2=A0Regards,
Ranbir Singh

On Fri, Jan 3, 20= 25 at 3:08=E2=80=AFAM Oliver Smith-Denny <osde@linux.microsoft.com> wrote:
Hi Ranbir and Veeresh,

On 11/6/2023 10:28 PM, Ranbir Singh wrote:
> v1 -> v2:
>=C2=A0 =C2=A0 - Rebased to latest master HEAD
>
> Ranbir Singh (2):
>=C2=A0 =C2=A0 FatPkg/EnhancedFatDxe: Fix SIGN_EXTENSION Coverity issues=
>=C2=A0 =C2=A0 FatPkg/EnhancedFatDxe: Fix OVERFLOW_BEFORE_WIDEN Coverity= issue
>
>=C2=A0 =C2=A0FatPkg/EnhancedFatDxe/DirectoryManage.c | 4 ++--
>=C2=A0 =C2=A0FatPkg/EnhancedFatDxe/DiskCache.c=C2=A0 =C2=A0 =C2=A0 =C2= =A0| 2 +-
>=C2=A0 =C2=A02 files changed, 3 insertions(+), 3 deletions(-)
>

I see that this patch was never merged (I don't see any response to
Laszlo's comments, which I agree with) but the GH issue is open:
https://github.com/tianocore/edk2/issues/10318.
If you want to put up a PR to address this issue, taking into account
Laszlo's review, please do so.

Thanks,
Oliver
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#120957) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--00000000000093ecd2062b03cbbf--