Re: [edk2-devel] [PATCH v2 1/1] MdeModulePkg/Bus/Ata/AtaBusDxe: Fix SIGN_EXTENSION Coverity issue

["Ranbir Singh" <rsingh@ventanamicro.com>]

[-- Attachment #1: Type: text/plain, Size: 2258 bytes --]

Hi Hao,

Just bringing this one to your attention in case it has got buried down
under ...

On the same lines as the following merged today -
https://github.com/tianocore/edk2/commit/c7c1170a4568ecc0f63e14ca6a844d40f47519a9


Best Regards,
Ranbir Singh


On Mon, Jul 17, 2023 at 5:29 PM Ranbir Singh <rsingh@ventanamicro.com>
wrote:

> From: Ranbir Singh <Ranbir.Singh3@Dell.com>
>
> Line number 365 does contain a typecast with UINT32, but it is after
> all the operations (16-bit left shift followed by OR'ing) are over.
> To avoid any SIGN_EXTENSION, typecast the intermediate result after
> 16-bit left shift operation immediately with UINT32.
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4209
>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Signed-off-by: Ranbir Singh <Ranbir.Singh3@Dell.com>
> Signed-off-by: Ranbir Singh <rsingh@ventanamicro.com>
> ---
>  MdeModulePkg/Bus/Ata/AtaBusDxe/AtaPassThruExecute.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaPassThruExecute.c
> b/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaPassThruExecute.c
> index a77852bae054..57aefa04c215 100644
> --- a/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaPassThruExecute.c
> +++ b/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaPassThruExecute.c
> @@ -362,7 +362,7 @@ IdentifyAtaDevice (
>      // Check logical block size
>      //
>      if ((PhyLogicSectorSupport & BIT12) != 0) {
> -      BlockMedia->BlockSize =
> (UINT32)(((IdentifyData->logic_sector_size_hi << 16) |
> IdentifyData->logic_sector_size_lo) * sizeof (UINT16));
> +      BlockMedia->BlockSize =
> (UINT32)(((UINT32)(IdentifyData->logic_sector_size_hi << 16) |
> IdentifyData->logic_sector_size_lo) * sizeof (UINT16));
>      }
>
>      AtaDevice->BlockIo.Revision = EFI_BLOCK_IO_PROTOCOL_REVISION2;
> --
> 2.34.1
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107443): https://edk2.groups.io/g/devel/message/107443
Mute This Topic: https://groups.io/mt/100212118/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 3559 bytes --]