From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) by mx.groups.io with SMTP id smtpd.web10.702.1665003527533673313 for ; Wed, 05 Oct 2022 13:58:47 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@google.com header.s=20210112 header.b=sk4PHj13; spf=pass (domain: google.com, ip: 209.85.208.43, mailfrom: dionnaglaze@google.com) Received: by mail-ed1-f43.google.com with SMTP id y100so194828ede.6 for ; Wed, 05 Oct 2022 13:58:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=cEhL94QbyOSj2y9vGjrehGJyMPkR21qKFfZNtbgqHts=; b=sk4PHj13DLmOtuqn+HCidaDqrlI4mrXLK+dKC3zaygSni0GYIEJZ0wVM5sJOHchxnK lbyMTydWSnTYQ9upwJya0VgfTGTHnAi06UPWHVBMm999Kh9d5cU2ecUclxK+shUps+z7 nsp11tiJ8TsE+tNh508ApAAnXWOgeLdqLwNGgk87BJAn5bVgmI/4oRJq/X52INzj3w9B IUUyRyydbncpD97VpIzWBBUjlJrlUPxhGee1doRnYv29rEuaUYY94WkAcl98BPq3ACw1 9w/3b1S/KUgb5qnh3wPZnlTxDK12Zuzb3svWlYoUtTisq1tn0uR5MKmCHbAcaKAvWmFk /9Rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=cEhL94QbyOSj2y9vGjrehGJyMPkR21qKFfZNtbgqHts=; b=Iwa9sMUmI8E3pFvTh0f4+RZ43cHpG+dXgjW2wbmg1zoeQrk/irnL1M8TmQRRy1sL3a 9aO5okkBp92p7Klik5QBve5u+ayor5TSBbXZKJ1aOdxZ6R5/bZtYkJeEXKjEGW4iu0fs T7XVW6O/z8JDrZZviOdUXE2+p3BtMgFcbu4tTWcbhuNWF/M9ZZz8KcgWGZLG4h9ivpoi okr1e0dTWZfCfxPAdci8EW66FMN0rcjSOyg2UsMbx98GtNv4f+66dMLp9/R7G+7yW2Fm TslT8tlAbUaZuTZHnU6wlafG1FNSbuByggmvBJdRLX63Hed0TiTZwDyJqyjB53M1RZ2r FR1g== X-Gm-Message-State: ACrzQf3fW3byj8s+O/hya47SPi+1Mv0oski36vXqdgrWmS4iT70Tvfy8 sxTJyJoMwtBAq7g7BCYvgCMVqnk4HMkhSFdbyOn81A== X-Google-Smtp-Source: AMsMyM6OzpTsbXtlsVa1vesFuuFlFfWaUJhJPPf8DfP75x4dASAzVnvw9FlYEFzrr2o/IEZ/EDw+5lDCQq5RA8b1c5Q= X-Received: by 2002:a05:6402:34c3:b0:459:cd99:3c7c with SMTP id w3-20020a05640234c300b00459cd993c7cmr1002109edc.213.1665003525874; Wed, 05 Oct 2022 13:58:45 -0700 (PDT) MIME-Version: 1.0 References: <20221005203329.469866-1-dionnaglaze@google.com> <20221005203329.469866-4-dionnaglaze@google.com> <027865f7-6d49-6f57-5db2-95fa5b51cc2d@amd.com> In-Reply-To: <027865f7-6d49-6f57-5db2-95fa5b51cc2d@amd.com> From: "Dionna Glaze" Date: Wed, 5 Oct 2022 13:58:34 -0700 Message-ID: Subject: Re: [PATCH v7 3/7] MdeModulePkg: Notify BeforeExitBootServices in CoreExitBootServices To: Tom Lendacky Cc: devel@edk2.groups.io, Gerd Hoffmann , James Bottomley , Jiewen Yao , Ard Biesheuvel , "Min M. Xu" , Andrew Fish , "Michael D. Kinney" , Ray Ni Content-Type: text/plain; charset="UTF-8" The specification says that disabling the timer should happen right after. Ard told me it should still work this way. On Wed, Oct 5, 2022 at 1:50 PM Tom Lendacky wrote: > > On 10/5/22 15:33, Dionna Glaze wrote: > > Location of notification is has been specified in UEFI v2.9. > > > > Cc: Gerd Hoffmann > > Cc: James Bottomley > > Cc: Jiewen Yao > > Cc: Tom Lendacky > > Cc: Ard Biesheuvel > > Cc: "Min M. Xu" > > Cc: Andrew Fish > > Cc: "Michael D. Kinney" > > Cc: Ray Ni > > > > Signed-off-by: Dionna Glaze > > --- > > MdeModulePkg/Core/Dxe/DxeMain.inf | 1 + > > MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c | 6 ++++++ > > 2 files changed, 7 insertions(+) > > > > diff --git a/MdeModulePkg/Core/Dxe/DxeMain.inf b/MdeModulePkg/Core/Dxe/DxeMain.inf > > index e4bca89577..35d5bf0dee 100644 > > --- a/MdeModulePkg/Core/Dxe/DxeMain.inf > > +++ b/MdeModulePkg/Core/Dxe/DxeMain.inf > > @@ -100,6 +100,7 @@ > > gEfiEventVirtualAddressChangeGuid ## CONSUMES ## Event > > ## CONSUMES ## Event > > ## PRODUCES ## Event > > + gEfiEventBeforeExitBootServicesGuid > > gEfiEventExitBootServicesGuid > > gEfiHobMemoryAllocModuleGuid ## SOMETIMES_CONSUMES ## HOB > > gEfiFirmwareFileSystem2Guid ## CONSUMES ## GUID # Used to compare with FV's file system guid and get the FV's file system format > > diff --git a/MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c b/MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c > > index 5733f0c8ec..4683016ed7 100644 > > --- a/MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c > > +++ b/MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c > > @@ -763,6 +763,12 @@ CoreExitBootServices ( > > { > > EFI_STATUS Status; > > > > + // > > + // Notify other drivers of their last chance to use boot services > > + // before the memory map is terminated. > > + // > > + CoreNotifySignalList (&gEfiEventBeforeExitBootServicesGuid); > > Isn't this supposed to be after disabling the timer? > > Thanks, > Tom > > > + > > // > > // Disable Timer > > // -- -Dionna Glaze, PhD (she/her)