From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49])
 by mx.groups.io with SMTP id smtpd.web09.227.1664560119959758162
 for <devel@edk2.groups.io>;
 Fri, 30 Sep 2022 10:48:40 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@google.com header.s=20210112 header.b=XZ7z2xaA;
 spf=pass (domain: google.com, ip: 209.85.218.49, mailfrom: dionnaglaze@google.com)
Received: by mail-ej1-f49.google.com with SMTP id dv25so10518232ejb.12
        for <devel@edk2.groups.io>; Fri, 30 Sep 2022 10:48:39 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=google.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date;
        bh=2xDbk01QFs/afs95VT58WyyaqtoMquIXon98lv1/RTU=;
        b=XZ7z2xaA9V0orSvQe8Igq7Ef+/+kOC0HESEZbpdfYVsXi/FbjZuc2tVGKOagZcsNMK
         HNwkBmCAnweG2c5/Kiho27KmtYLHY7k5+wMizp3mfD8t22nMZvmUMpWTbrXAVb5/DUGb
         EpFzsPUu9P/LtzWaLjLg3ZM0I37ujYxr1SpFfTnxl53Ru/3n5ph0Oyvw1LSSXs00trg8
         yOYp7leWPRQHkQDBC3AYxOA+uqwytsZPgBiTNyJ1J+qdQvtKc6dh/I4Q0ocjckmDUjNg
         4ez8BBMltXgn6iAPKQgODHFea4Qtg8ynswqe4NXVyMkCjh9ib2vku49TbdlgcqvDzre+
         wQjA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date;
        bh=2xDbk01QFs/afs95VT58WyyaqtoMquIXon98lv1/RTU=;
        b=YdUY7NMgxtuJEIz9aPrC/CRgot0VktbM81QMUYezbUIpi+hmYe2gALXU6HpMIpbx0S
         RvISyUt7vO124FOQRGn1japMIyAqbVlyJz/qEZP9Iu0nuFrMgLuYfMZIDaQ5ch2a2OzN
         GHVa3g/gK5aZKFl+sQj+Vy9M3bFYodHXGM4AdB8ugP1Oo/vQ95xqYLZhFBVDv1jRzJeZ
         nN3NW5B7T8uqyaIHteYidLUgOMP3P2SHb0P5aW7CaKY6TvQG8eGK91aZppvNnh4JyZEK
         0/ILntQr1DsU80zOR1oUVYYCUe5OMFqaukUQW98/fAPlkGkVhNC2T1cnoJ0PhiEa2+Z0
         rjEA==
X-Gm-Message-State: ACrzQf3tICSQkNjXjtvi6HQO7xk/NRgIahtV+uyQzvr5e1bBBdkxFeps
	LZlGEa9rCxZp2Gv38oUz1SZL2sY5uAnHlWTw5VZKCA==
X-Google-Smtp-Source: AMsMyM5Xhc9LszaS/KoEn3S05uHJ5VYRNXxopbNpXoaET44opVP9BQw8BVrY0NI3GlfCGgu9lZOzPjKYv0NYpv7M3yY=
X-Received: by 2002:a17:906:fe46:b0:73d:939a:ec99 with SMTP id
 wz6-20020a170906fe4600b0073d939aec99mr7392229ejb.169.1664560118296; Fri, 30
 Sep 2022 10:48:38 -0700 (PDT)
MIME-Version: 1.0
References: <20220928153323.2583389-1-dionnaglaze@google.com>
 <20220928153323.2583389-2-dionnaglaze@google.com> <584ccb31-f5c6-eba3-c44e-85ceaa6a7d82@amd.com>
In-Reply-To: <584ccb31-f5c6-eba3-c44e-85ceaa6a7d82@amd.com>
From: "Dionna Glaze" <dionnaglaze@google.com>
Date: Fri, 30 Sep 2022 10:48:27 -0700
Message-ID: <CAAH4kHZYvKmwYuzqJV0cwqUf+iqjd=fR+AhThpO48JNN-jTjeQ@mail.gmail.com>
Subject: Re: [PATCH v4 1/6] OvmfPkg: Realize EfiMemoryAcceptProtocol in AmdSevDxe
To: Tom Lendacky <thomas.lendacky@amd.com>
Cc: devel@edk2.groups.io, Gerd Hoffmann <kraxel@redhat.com>, 
	James Bottomley <jejb@linux.ibm.com>, Jiewen Yao <jiewen.yao@intel.com>, 
	Sophia Wolf <phiawolf@google.com>
Content-Type: text/plain; charset="UTF-8"

> > +{
> > +  MemEncryptSevSnpPreValidateSystemRam (
> > +    StartAddress,
> > +    EFI_SIZE_TO_PAGES (Size)
>
> Sorry, I forgot to ask this earlier in the series, but is StartAddress
> guaranteed to be page-aligned and Size a multiple of 4KB? Should there be
> any asserts for those just in case?
>
> Also, can Size be 0? In which case MemEncryptSevSnpPreValidateSystemRam()
> shouldn't be called?
>

It shouldn't happen, but I'll return EFI_INVALID_PARAMETER on those conditions.


> > +  Status = gBS->InstallProtocolInterface (
> > +                  &mAmdSevDxeHandle,
> > +                  &gEfiMemoryAcceptProtocolGuid,
> > +                  EFI_NATIVE_INTERFACE,
> > +                  &mMemoryAcceptProtocol
> > +                  );
>
> Should this only be installed for an SNP guest, e.g. put within the
> "if (MemEncryptSevSnpIsEnabled ()) {" check?
>
> Maybe use ASSERT_EFI_ERROR (Status)?
>

Will do, thanks for your review.

-- 
-Dionna Glaze, PhD (she/her)