From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 00B35AC1AD4 for ; Wed, 1 May 2024 23:19:31 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=UbVFP5SASa4qB/VHhK4KxzBkyEfQxmQbUsqf4j2qibk=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20240206; t=1714605570; v=1; b=1tMkpiaKFAssOqDAs+e1c1ns9erRztinoEL0DcXXniFBgjYVBsxpuk/lOCaLkoOnyxFZx6DM X6vg+JUF7ITl+JfyN3IcDLOopOg8Yq1/sfAlHF2k8EDXnTzHBd9Z7FBobdrTDlMVCxP4QDeVQ0N VsQP5TLIIEiO82iq0dNvxj/54Fscbx5lIZYd6zqI/zXB3GGJiRylcTIy91zFFnzLfC2FnzhcpDt Y7wshK3Zle9vUxFNdvOABjA9WawcfI7w6ChttwKFSZNLkUycj6k4sd3BkLCbf1T2Ws/wOyEhlL5 HIfQa/VdB17c3YRab8GIvmIio+jl2+VH3zGeSLdKZbgog== X-Received: by 127.0.0.2 with SMTP id saxoYY7687511x9Kv5G2ygFE; Wed, 01 May 2024 16:19:30 -0700 X-Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) by mx.groups.io with SMTP id smtpd.web10.915.1714605569500187342 for ; Wed, 01 May 2024 16:19:29 -0700 X-Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-572a1b3d6baso2536a12.1 for ; Wed, 01 May 2024 16:19:29 -0700 (PDT) X-Gm-Message-State: 8scbNJWnFJPdIM5IsvVIU7Q5x7686176AA= X-Google-Smtp-Source: AGHT+IH+1+6KiQrOTx/XEN+KHQSGO2OKO0TF7bnHyT3+UmjX8NSABIk9PGhdffHHNhL3gpY1CXgnh8V9uHszHvuwIvI= X-Received: by 2002:a50:d685:0:b0:572:583f:cc4c with SMTP id 4fb4d7f45d1cf-572bdc55ea6mr35263a12.5.1714605567484; Wed, 01 May 2024 16:19:27 -0700 (PDT) MIME-Version: 1.0 References: <076697e5-a594-40a7-8100-767d6a2f7520@quicinc.com> In-Reply-To: <076697e5-a594-40a7-8100-767d6a2f7520@quicinc.com> From: "Dionna Glaze via groups.io" Date: Wed, 1 May 2024 16:19:14 -0700 Message-ID: Subject: Re: [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024 To: devel@edk2.groups.io, quic_llindhol@quicinc.com Cc: michael.d.kinney@intel.com, "rfc@edk2.groups.io" , "Andrew Fish (afish@apple.com)" Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 01 May 2024 16:19:29 -0700 Resent-From: dionnaglaze@google.com Reply-To: devel@edk2.groups.io,dionnaglaze@google.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=1tMkpiaK; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On Wed, May 1, 2024 at 11:12=E2=80=AFAM Leif Lindholm via groups.io wrote: > > On 2024-05-01 18:43, Michael D Kinney wrote: > > Hello, > > > > I would like to propose that TianoCore move all code review from email > > based code reviews to GitHub Pull Requests based code reviews. > > > > The proposed date to switch would be immediately after the next stable > > tag which is currently scheduled for May 24, 2024. > > Thanks Mike. > > I'm in favour of this change, and the date. > > I still want us to try to figure out how to retain review history beyond > what github decides we need, but I don't think it justifies indefinitely > delaying the switchover. And frankly, it will be easier to experiment > with what works and not after the switch. +1. UI-based interactions don't export well for archival-permalinking reasons, and Github archive behavior is for repositories only, not the reviews. But yes, wouldn't want to delay for a bot to echo conversations to devel@edk2.groups.io or some other solution. > > / > Leif > > > Updates to the following Wiki page would be required to describe the > > required process when using GitHub Pull Requests for all code review > > related activity. > > > > https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Devel= opment-Process > > > > A couple examples of the changes that would need to be documented are: > > > > * All contributors, maintainers, and reviewers must have GitHub IDs. It looks like this is already resolved for the existing Maintainers.txt with the `[username]` syntax, but I don't see any explanation of that expectation. Seems fine to me. > > * The commit message would no longer require Cc:, Reviewed-by:, Acked-b= y: > > or Tested-by: tags. The only required tag would be Signed-off-by. > > * The Pull Request submitter is required to invite the required > > maintainers and reviewers to the pull request. This is the same > > set of maintainers and reviewers that are required to be listed in > > Cc: tags in today's process. This is not configured on tianocore/edk2 at the moment. I have no way to invite a reviewer. Is this a planned fix? > > * Maintainers are responsible for verifying that all conversations in > > the code review are resolved and that all review approvals from the > > required set of maintainers are present before setting the 'push' la= bel. > > > > > > Please provide feedback > > 1) If you are not in favor of this change. > > 2) If you are not in favor of the proposed date of this change. > > 3) On the process changes you would like to see documented in the Wiki > > pages related to using GitHub Pull Request based code reviews. > > > > There is some prototype work to automate/simplify some of the PR based > > code review process steps. Those could be added over time as resources > > are available to finish and support them. > > > > Best regards, > > > > Mike > > > > > > > > > > > > > >=20 > > --=20 -Dionna Glaze, PhD, CISSP (she/her) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118483): https://edk2.groups.io/g/devel/message/118483 Mute This Topic: https://groups.io/mt/105847510/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-