From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) by mx.groups.io with SMTP id smtpd.web10.14081.1664477422022528486 for ; Thu, 29 Sep 2022 11:50:22 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@google.com header.s=20210112 header.b=fwJvfHIS; spf=pass (domain: google.com, ip: 209.85.208.51, mailfrom: dionnaglaze@google.com) Received: by mail-ed1-f51.google.com with SMTP id a13so3211153edj.0 for ; Thu, 29 Sep 2022 11:50:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date; bh=XT9hxUKlH9xlDZX2MZYpX1ZcvKpN0KHrwdmIuQjdYt0=; b=fwJvfHISUR/wmW1t/0z4oW3/5/kRcwduiHjK2Sr3rIEZ9QMXGHQgKg/Kkhxr/XUOjQ cgQM3R6nSNQKkYR2i68mjI9D8r9iIRxrAZaUx2qzBvSXcM1ZpzGqjw9wkmZU7iU7FZkJ EZ2UVvUDNcgFrgQ+yfClRkOiIQM9vSNiwoPaz0ub5eCTvc/VkTPXDj/MwQcrnPoYENDG LNJGD1edRxCRcoX1Q1uQ1aeppd7VCFARcqWGHvc3jrFgPQM1LIEElhB2Vyj0OlId78ck Pwxo0wYUCY59Z8Abq5cH58R+BSYZ8K8owyzMNhfhBfGj95qh22QDBMn+1QG0TQTGKvfG IrqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=XT9hxUKlH9xlDZX2MZYpX1ZcvKpN0KHrwdmIuQjdYt0=; b=QdQFXUn5gwwbna+uM1hLqlwf4xuBOiSgLsfz1XSR2Asut8QxiRXDXgqS6nZEgSoonI RiH1JMV+2nN/UJThIschqBszbYJkEYPCed7S4DmBMXS8NScpI9VQrUkH04oQT08Eagx9 Xll9ViYQjcd837MFd/5TDI8J2tE5jXaZaYz+kLaHtdwpBk8nJmgPoakArQ0BSdANCnm3 HPFbf3o2Xf7Rb2+sCMVr1yI2WvqaItSZ6DiPlC4oy0nlFjZPekOsczhIC1DsGl7iGqzI TEo7+vxZDs6eP+mHTFj3UX6r+9BtpRZ5BtvcKKUYOImUou5+FzZtvqDVzEzVt5p502Zd Vg/w== X-Gm-Message-State: ACrzQf3xv43hIi+OmSPK6l5qzJOZ4DU27ZEYJ7AyxfA8kEokZ5uTB5V6 rsqWXmgOOJ8wIwLItnHmH6aPTqhsbn+ToQ2Kp8vNSg== X-Google-Smtp-Source: AMsMyM6/sbTlfT3wcWDk82j4LEaPx7Zq4VdgHTTTdKiMN6Db1C4PW88eR45AiHhYJ2MtXQEMp3nE+7pcsjgvpZL3bCE= X-Received: by 2002:a05:6402:40cc:b0:452:697e:da18 with SMTP id z12-20020a05640240cc00b00452697eda18mr4516403edb.288.1664477420196; Thu, 29 Sep 2022 11:50:20 -0700 (PDT) MIME-Version: 1.0 References: <20220928153323.2583389-1-dionnaglaze@google.com> <20220928153323.2583389-4-dionnaglaze@google.com> In-Reply-To: From: "Dionna Glaze" Date: Thu, 29 Sep 2022 11:50:09 -0700 Message-ID: Subject: Re: [PATCH v4 3/6] OvmfPkg: set PcdEnableUnacceptedMemory to FALSE To: Ard Biesheuvel Cc: devel@edk2.groups.io, Gerd Hoffmann , James Bottomley , Jiewen Yao , Tom Lendacky Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > Generally, we tend to rely on the DEC default for new PCDs if we're > not deviating from it. > If there is no specific reason to deviate from this here, I think we > can drop this patch. > > Or is this also needed to declare them as the right type? In that > case, I think you can drop the hunks that touch non-CC platforms. > I probably did something wrong. Without this patch, the protocol patch with PcdSetBoolS fails to build. INFO - In file included from /usr/local/google/home/dionnaglaze/gitrepos/edk2/Build/OvmfX64/DEBUG_GCC5/X= 64/MdeModulePkg/Core/Dxe/DxeMain/DEBUG/AutoGen.h:17, INFO - from : INFO - /usr/local/google/home/dionnaglaze/gitrepos/edk2/MdeModulePkg/Core/D= xe/Mem/Page.c: In function =E2=80=98CoreEnableUnacceptedMemory=E2=80=99: INFO - /usr/local/google/home/dionnaglaze/gitrepos/edk2/MdePkg/Include/Libr= ary/PcdLib.h:549:40: error: implicit declaration of function =E2=80=98_PCD_SET_MODE_BOOL_S_PcdAcceptAllUnacceptedMemory=E2=80=99 [-Werror=3Dimplicit-function-declaration] INFO - 549 | #define PcdSetBoolS(TokenName, Value) _PCD_SET_MODE_BOOL_S_##TokenName ((Value)) INFO - | ^~~~~~~~~~~~~~~~~~~~~ INFO - /usr/local/google/home/dionnaglaze/gitrepos/edk2/MdeModulePkg/Core/D= xe/Mem/Page.c:2232:10: note: in expansion of macro =E2=80=98PcdSetBoolS=E2=80=99 INFO - 2232 | return PcdSetBoolS(PcdAcceptAllUnacceptedMemory, FALSE); INFO - | ^~~~~~~~~~~ INFO - cc1: all warnings being treated as errors INFO - make: *** [GNUmakefile:452: /usr/local/google/home/dionnaglaze/gitrepos/edk2/Build/OvmfX64/DEBUG_GCC5/X= 64/MdeModulePkg/Core/Dxe/DxeMain/OUTPUT/Mem/Page.obj] Error 1 INFO - What's the right way to do this? --=20 -Dionna Glaze, PhD (she/her)