From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by mx.groups.io with SMTP id smtpd.web11.3366.1675192705129179632 for ; Tue, 31 Jan 2023 11:18:25 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@google.com header.s=20210112 header.b=lqSJ58b0; spf=pass (domain: google.com, ip: 209.85.216.42, mailfrom: dionnaglaze@google.com) Received: by mail-pj1-f42.google.com with SMTP id n20-20020a17090aab9400b00229ca6a4636so20201576pjq.0 for ; Tue, 31 Jan 2023 11:18:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=GO/lxt1IcoAS5gGdr43Ty7fuCkZFFfnRE8Hggj/n5rI=; b=lqSJ58b01FXYaI7/lZG53we6/UDmifVVlWC/Q1+XcJCIjxC5YdpyOANHzfuQIS4aCX FJnvwiYYblMho6JztFs15Le5LTyOxBRf3hAdOTuxh25ynhzU88OpkQ298+orERkRPp/V 4MMqjZVR/wAW8Z/tICxdfe89XeTv5dJ+yOfYImrVw/pTY0HvZwYfd1slkTJQjcf0t/BU mq4R4U9I6EquW6gn9+cs116ryGT4qFxlrjfb4lulbqRbhZPmCRFQN6fC6UZvy2tBIhaq deWc6mLZOrmpgfKYAK5Bi0x/kpjgI7gsavKgx30etXWwcnsB5a8mUcS4tBkslqjoNIDp jLPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GO/lxt1IcoAS5gGdr43Ty7fuCkZFFfnRE8Hggj/n5rI=; b=DPUdDQMZwJhga6ycBv7JOuCCD7QyM/fRRo0ZyZ/xvyyBwziNPQNQT8AIpAzwh/U0am UmWZFy9RFYycRZn1iOUJuMTnm3KIGXvYeZ9flceW3/FkT56XpHvJKfICEp4B3cRU+XkY CSAaUt1TdjEz8gsYZMll5sCiNoZs/TLrk6eNH1ZQ8li5xYYLKNF937xiHyJxiglSnZmX xpcwp6YgC9eb3gVwaDqylQbpgqMQ9MhLY3hyt/naeRYRV/PYNQbffoGOESVK4ZuY4bsf JdhLkN3RsNHGAwWBPbnZ+btzgzUD6pafL6EtKhf1VjsgG5e1wKUUjp2CYtkAdEXP9uk+ EmtQ== X-Gm-Message-State: AO0yUKVzwod166B+r9K93/sjTNmEDU+ACdDVfU60pRInxQClclz8zKDR HGBgdmH+ZYHcXcysl4anw/FyIxQ+t4PlqZG4l5DjbDoXUYIsuXSXskE= X-Google-Smtp-Source: AK7set+AtbvcSIQvjMDo53g50ZrCY1Qj+fk1VD4unC1NcwRXyKLQOwwCFyCc/ZFmVuGzja9a8o/mDEUoqSx9wfOeQcc= X-Received: by 2002:a17:903:1249:b0:198:99b5:cabf with SMTP id u9-20020a170903124900b0019899b5cabfmr608423plh.25.1675192703858; Tue, 31 Jan 2023 11:18:23 -0800 (PST) MIME-Version: 1.0 References: <20230131190837.354950-1-dionnaglaze@google.com> In-Reply-To: <20230131190837.354950-1-dionnaglaze@google.com> From: "Dionna Glaze" Date: Tue, 31 Jan 2023 11:18:12 -0800 Message-ID: Subject: Re: [PATCH] OvmfPkg: Fix SevMemoryAcceptance memory attributes To: devel@edk2.groups.io Cc: Ard Biesheuvel , Erdem Aktas , James Bottomley , Jiewen Yao , Min Xu , Tom Lendacky , Michael Roth Content-Type: text/plain; charset="UTF-8" > > efi: mem94: [Conventional| | |CC| | | | | | | | | | | ] > range=[0x0000000100000000-0x000000023fffffff] (5120MB) > > This does not have the cache capabilities one would expect for system > memory, UC|WC|WT|WB. > > After this change, the same entry becomes > > efi: mem94: [Conventional| | |CC| | | | | | | |WB|WT|WC|UC] > range=[0x0000000100000000-0x000000023fffffff] (5120MB) > > This has all the expected attributes. > This change is made given a request from Ard. The CC capability is not applied to other system memory ranges that probably should also have that capability, given that it's encrypted and accepted. I haven't considered carefully where EFI_MEMORY_CPU_CRYPTO should be added to conventional memory, given the acceptance happens before DXE initializes. Perhaps CoreConvertResourceDescriptorHobAttributesToCapabilities? This is more of a question to Ard and Thomas. -- -Dionna Glaze, PhD (she/her)