Re: [edk2-devel] [edk2-platforms PATCH v1 0/1] BoardModulePkg: Copy device path

["Dionna Glaze" <dionnaglaze@google.com>]

Hi Abdul, I'm not a maintainer, just a contributor. I thought I'd pop
in with an observation though. I'm not seeing any diffs in these
emails. I'm not going to click a suspicious-looking link either.
Likely other folks have the same reservation. Have you read the
contributor guidelines on how to send in patches?

https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process

On Thu, Oct 13, 2022 at 8:12 AM Attar, AbdulLateef (Abdul Lateef) via
groups.io <AbdulLateef.Attar=amd.com@groups.io> wrote:
>
> [Public]
>
> Review please
>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Attar, AbdulLateef (Abdul Lateef) via groups.io
> Sent: 16 September 2022 12:58
> To: devel@edk2.groups.io; Eric Dong <eric.dong@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>
> Subject: Re: [edk2-devel] [edk2-platforms PATCH v1 0/1] BoardModulePkg: Copy device path
>
> [Public]
>
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
>
> [Public]
>
> Hello Maintainers, Reviewers,
>         Could you please review the patch?
> Thanks
> AbduL
>
> -----Original Message-----
> From: Attar, AbdulLateef (Abdul Lateef)
> Sent: 13 July 2022 09:49
> To: 'devel@edk2.groups.io' <devel@edk2.groups.io>; 'Eric Dong' <eric.dong@intel.com>; 'Liming Gao' <gaoliming@byosoft.com.cn>
> Subject: RE: [edk2-devel] [edk2-platforms PATCH v1 0/1] BoardModulePkg: Copy device path
>
> Maintainers, Reviewers,
>  please review the patch.
> Thanks
> AbduL
>
>
> -----Original Message-----
> From: Attar, AbdulLateef (Abdul Lateef)
> Sent: 25 April 2022 12:45
> To: devel@edk2.groups.io; Eric Dong <eric.dong@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>
> Subject: RE: [edk2-devel] [edk2-platforms PATCH v1 0/1] BoardModulePkg: Copy device path
>
> Hi,
>    Please review the patch.
> Thanks
> AbduL
>
> -----Original Message-----
> From: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>
> Sent: 05 April 2022 11:25
> To: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; Eric Dong <eric.dong@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>
> Subject: RE: [edk2-devel] [edk2-platforms PATCH v1 0/1] BoardModulePkg: Copy device path
>
> [Public]
>
> Hi,
>    Could you please review the patch?
> Thanks
> AbduL
>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Abdul Lateef Attar via groups.io
> Sent: 15 March 2022 10:16
> To: devel@edk2.groups.io
> Cc: Eric Dong <eric.dong@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>
> Subject: [edk2-devel] [edk2-platforms PATCH v1 0/1] BoardModulePkg: Copy device path
>
> [CAUTION: External Email]
>
> (Resending patch with [edk2-platforms] prefix with correct emailid).
> GCC compiler puts the DevicePath PCDs to the read-only section. During boot if try to process the device path after PtrGetPtr it throws a page fault exception.
>
> Hence making a local copy using DuplicateDevicePath() to avoid the page fault exception.
>
> REF : https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fabdattar%2Fedk2-platforms%2Ftree%2FBoardModulePkg&amp;data=05%7C01%7CAbdulLateef.Attar%40amd.com%7C8ed1e10f30a44c51ed8808da97e873c5%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637989321879784020%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=GL91Bvyavwj0eK%2F81WXVp7LDVSu2MHJudT%2BdNIa99jU%3D&amp;reserved=0
>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>
> Abdul Lateef Attar (1):
>   BoardModulePkg: Copy device path before processing
>
>  Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.c | 19 ++++++++++++++-----
>  1 file changed, 14 insertions(+), 5 deletions(-)
>
> --
> 2.25.1
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> 
>
>


-- 
-Dionna Glaze, PhD (she/her)