From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) by mx.groups.io with SMTP id smtpd.web09.881.1665691737594595677 for ; Thu, 13 Oct 2022 13:08:57 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@google.com header.s=20210112 header.b=kz/oj/8C; spf=pass (domain: google.com, ip: 209.85.218.45, mailfrom: dionnaglaze@google.com) Received: by mail-ej1-f45.google.com with SMTP id d26so6262392ejc.8 for ; Thu, 13 Oct 2022 13:08:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=OTa7Ovmn6r4La2bFKW7i9HFOW9sMz8ZLVJEN2UJuhWc=; b=kz/oj/8CXflqaL0AgDUO1mTCfUzd5ronDBZwdLouAEg9GxNPY1moYOYn2cP7AEwp3+ mRMIYzdv7H4qg2ZcZ40JGhTHZd9A9ntr9PY53MAex6zGX1Er3BKU722Y84ovkVnjKAc7 zs6ank1RDdrGmsSbZglnyj2foHik0WpfPnP07XyKfwAhR7kmz0IvqdPH5urASgJYSEOy ySVD68y4vas+ii6bmkOm65UO19Bys616cKF33AEk/7iDI7a2XpGiEUhafydjxhBE1zMf 4zE1zk+7HilByrSa9qJ36l9T4rpI+4XqYgl/BISSC6gfIwLaGoO2rHAZGbREBAvnzd/G adOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OTa7Ovmn6r4La2bFKW7i9HFOW9sMz8ZLVJEN2UJuhWc=; b=6fSIqwh492a0MpyPONqbGuSnwLiWQtCl7FK/5rntPeAjqLZjuOiYiRnOKLHDsn8S9A sNvXss5zMfG+Sp75yTFwA8qAQu7c+8ofDCz/LAWzfJhNz86+/0asqO7sls4aK6YJUX+C O0uHb/zwR8bVTrrBDtyxuoMcMAKnWqVkCkReqMQQIZUovdumbaOPKOztEqmSZzo7s1TT ZOKnIFZg4AP3jv5wAc96FPmDwlmZueLYbh+E95h7H3kf/IUzq+KpAW5chzik+bONNy3k xJWUaSPDFWdyVQFyTqN05jOMX5FN9WiT/g9azqUk5QL+AWvxiK56Nx8MwsG4ABkkzYaf I5Bw== X-Gm-Message-State: ACrzQf0vUjfW+kU5qly8vRKyHfH7Ze35GIpVZfUIJjvRrC4TMoIIe0Ij ROqzWreWe9RM+ov+ce19q0I79AP9Qul1ENq/YtW3U8RmoKl4np0J X-Google-Smtp-Source: AMsMyM534wC0mUz6tyL1tIwycvkaKcr6TKIbKvOgukv1BXw360a1y3NDNdEey2z22WnY4Sya7hm63TO4WP/g1mh9V3U= X-Received: by 2002:a17:907:971e:b0:78d:e7ed:7585 with SMTP id jg30-20020a170907971e00b0078de7ed7585mr1070940ejc.258.1665691735764; Thu, 13 Oct 2022 13:08:55 -0700 (PDT) MIME-Version: 1.0 References: <16DC746BF95A26AB.23353@groups.io> In-Reply-To: From: "Dionna Glaze" Date: Thu, 13 Oct 2022 13:08:44 -0700 Message-ID: Subject: Re: [edk2-devel] [edk2-platforms PATCH v1 0/1] BoardModulePkg: Copy device path To: devel@edk2.groups.io, AbdulLateef.Attar@amd.com Cc: Eric Dong , Liming Gao Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Abdul, I'm not a maintainer, just a contributor. I thought I'd pop in with an observation though. I'm not seeing any diffs in these emails. I'm not going to click a suspicious-looking link either. Likely other folks have the same reservation. Have you read the contributor guidelines on how to send in patches? https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Pr= ocess On Thu, Oct 13, 2022 at 8:12 AM Attar, AbdulLateef (Abdul Lateef) via groups.io wrote: > > [Public] > > Review please > > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Attar, Abd= ulLateef (Abdul Lateef) via groups.io > Sent: 16 September 2022 12:58 > To: devel@edk2.groups.io; Eric Dong ; Liming Gao > Subject: Re: [edk2-devel] [edk2-platforms PATCH v1 0/1] BoardModulePkg: C= opy device path > > [Public] > > Caution: This message originated from an External Source. Use proper caut= ion when opening attachments, clicking links, or responding. > > > [Public] > > Hello Maintainers, Reviewers, > Could you please review the patch? > Thanks > AbduL > > -----Original Message----- > From: Attar, AbdulLateef (Abdul Lateef) > Sent: 13 July 2022 09:49 > To: 'devel@edk2.groups.io' ; 'Eric Dong' ; 'Liming Gao' > Subject: RE: [edk2-devel] [edk2-platforms PATCH v1 0/1] BoardModulePkg: C= opy device path > > Maintainers, Reviewers, > please review the patch. > Thanks > AbduL > > > -----Original Message----- > From: Attar, AbdulLateef (Abdul Lateef) > Sent: 25 April 2022 12:45 > To: devel@edk2.groups.io; Eric Dong ; Liming Gao > Subject: RE: [edk2-devel] [edk2-platforms PATCH v1 0/1] BoardModulePkg: C= opy device path > > Hi, > Please review the patch. > Thanks > AbduL > > -----Original Message----- > From: Attar, AbdulLateef (Abdul Lateef) > Sent: 05 April 2022 11:25 > To: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef) ; Eric Dong ; Liming Gao > Subject: RE: [edk2-devel] [edk2-platforms PATCH v1 0/1] BoardModulePkg: C= opy device path > > [Public] > > Hi, > Could you please review the patch? > Thanks > AbduL > > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Abdul Late= ef Attar via groups.io > Sent: 15 March 2022 10:16 > To: devel@edk2.groups.io > Cc: Eric Dong ; Liming Gao > Subject: [edk2-devel] [edk2-platforms PATCH v1 0/1] BoardModulePkg: Copy = device path > > [CAUTION: External Email] > > (Resending patch with [edk2-platforms] prefix with correct emailid). > GCC compiler puts the DevicePath PCDs to the read-only section. During bo= ot if try to process the device path after PtrGetPtr it throws a page fault= exception. > > Hence making a local copy using DuplicateDevicePath() to avoid the page f= ault exception. > > REF : https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2= Fgithub.com%2Fabdattar%2Fedk2-platforms%2Ftree%2FBoardModulePkg&data=3D= 05%7C01%7CAbdulLateef.Attar%40amd.com%7C8ed1e10f30a44c51ed8808da97e873c5%7C= 3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637989321879784020%7CUnknown%7CT= WFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%= 3D%7C3000%7C%7C%7C&sdata=3DGL91Bvyavwj0eK%2F81WXVp7LDVSu2MHJudT%2BdNIa9= 9jU%3D&reserved=3D0 > > Cc: Eric Dong > Cc: Liming Gao > > Abdul Lateef Attar (1): > BoardModulePkg: Copy device path before processing > > Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.c = | 19 ++++++++++++++----- > 1 file changed, 14 insertions(+), 5 deletions(-) > > -- > 2.25.1 > > > > > > > > > > > > > > >=20 > > --=20 -Dionna Glaze, PhD (she/her)