From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) by mx.groups.io with SMTP id smtpd.web09.14077.1664475277962817757 for ; Thu, 29 Sep 2022 11:14:38 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@google.com header.s=20210112 header.b=WlFrqpFA; spf=pass (domain: google.com, ip: 209.85.208.49, mailfrom: dionnaglaze@google.com) Received: by mail-ed1-f49.google.com with SMTP id a13so3096720edj.0 for ; Thu, 29 Sep 2022 11:14:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=ShpQIhgMhg/kkcGF2SDhc6qJLUgmLx+Gm2PGB6XWgoA=; b=WlFrqpFAlYNgDjvxXdPfJVhdiw7ESIDym0lQYJUdyHXE3GpmP1VkqcmW7jqtx9RCDt TCRN5BY+fgW2IiV5OHU1gRtKM3L/FNJq8W9U+32x/F4UydwA/KKo8Ls8gqlgrZ/RfvIO 0qsdrgIf/ieOAHW3TTkWEP6KuTd4Lfci0+K3U7Taig8BIxZi+343pYTYfoqrUHmL2ONC CV9ph+5O/Rb+zm6ahfrajgjSe7rQv/JenLCMecje6e7M0dFgwQDz6gTo7ymJQGTb6UlM 9tfyWuCkuKddzD/8ZidMI9E487KWzyGp5Ffa5YseeTTzzCIqkB/srsoU4nkLITiZEZbV W3mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=ShpQIhgMhg/kkcGF2SDhc6qJLUgmLx+Gm2PGB6XWgoA=; b=iG3z+9rtSgvh8m0fOcrsrVmiF75AMVON6IL4grx8W06E9SpZi2gnaLZK1SqtR7/9RE PittUmuL7jZ2S+ccq3UsY1Ea12qlfGTZS3ZdbX8r5frUP6uOUi54twF3yAPuX2OReZmL 9/+eowUCTJXSt+NVCD4BFFpv/GQkYxqsZr248+Ic0wyJQopMexEHz0Tf7dTowgkkTrVx t53RRdQKGiA2/Ichu6NDpzvpYKsRCElOEwBpJZJ8mWyHfYiz1njNDB+QS/7E28bmacCT xX7lUSYFRHQ9MXZb/7FxvDW1eq9oqnRdoh7XRU103X2IQagmzGbReOM/6neJaiMGmHwQ zgPg== X-Gm-Message-State: ACrzQf1k5S2Zowfg7hOjOzJ/knMHgTPWUUP31k/9CO2HbNQ1Np+NHOW/ WVktj65dvq3BIGQEdGW8oVzYfJ0hBrARXzcNJgru4g== X-Google-Smtp-Source: AMsMyM51xYxpD1kcYWL2KBIJEreSRkK5YeUOge08jB0x9BH1E0alFaJgW8ZzQ+nLn/14t/1YYOUkXwpgbfAh6zqPmvk= X-Received: by 2002:aa7:dc0d:0:b0:443:e1ca:bdb1 with SMTP id b13-20020aa7dc0d000000b00443e1cabdb1mr4510451edu.62.1664475276312; Thu, 29 Sep 2022 11:14:36 -0700 (PDT) MIME-Version: 1.0 References: <20220928153323.2583389-1-dionnaglaze@google.com> <20220928153323.2583389-5-dionnaglaze@google.com> In-Reply-To: From: "Dionna Glaze" Date: Thu, 29 Sep 2022 11:14:25 -0700 Message-ID: Subject: Re: [edk2-devel] [PATCH v4 4/6] MdeModulePkg: DxeMain accepts all memory at EBS if needed To: "Ni, Ray" Cc: "devel@edk2.groups.io" , Gerd Hoffmann , James Bottomley , "Yao, Jiewen" , Tom Lendacky , Ard Biesheuvel Content-Type: text/plain; charset="UTF-8" > > Can you explain a bit more why this PCD is needed? > I'll expand the comment further, but essentially we need a bit in the firmware to persist from a call into a protocol to the eventual call to ExitBootServices. If we needed offline persistence, then we'd need to standardize a new bit in the OsIndications variable. We don't so we make due with a Pcd. > > I am not following the logic here 100%. As far as I can tell, if > accepting all memory succeeded without errors, ExitBootServices() > returns with EFI_SUCCESS, even though it has modified the memory map. > This means the actual memory map is out of sync with the last > GetMemoryMap() call performed by the OS loader before it called > ExitBootServices(), and so it will still contain unaccepted memory, > right? Ah yes you're right, I missed that part. I'll change it to return EFI_WARN_STALE_DATA if any memory region gets accepted, and force a failure in DxeMain if the status is an error or that warning. -- -Dionna Glaze, PhD (she/her)