From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172])
 by mx.groups.io with SMTP id smtpd.web10.1808.1631322906751081014
 for <devel@edk2.groups.io>;
 Fri, 10 Sep 2021 18:15:06 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@google.com header.s=20210112 header.b=Y933V9v9;
 spf=pass (domain: google.com, ip: 209.85.215.172, mailfrom: erdemaktas@google.com)
Received: by mail-pg1-f172.google.com with SMTP id e7so3411932pgk.2
        for <devel@edk2.groups.io>; Fri, 10 Sep 2021 18:15:06 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=google.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=U/bypAIJR14PKr6nNtQ29B74Nh/66smQqquuiyHiN7U=;
        b=Y933V9v9CCMWXuVYaf8SDVlcoG7LKSptYMnuws2BmKq7qprBsZGTWCgOAIMCJ7bBvP
         lBQYACLK49wn3ZfS7VxWqPzccU1RX6awoxAwQHLnm92d9sY5xs7S8iRRMeXb1oeZWDLn
         pkohhqKavWIYMh5+s1JMDRwh+wqW6GU09UOi2H+TlS2NCfjO28ZLgz8YmB9leXq6Ag6f
         ZdM6NIhejO3QivmdJhYQSmg9WrotpwBjRJbDfCXIvEhc6PxH16pOU0necJsolXZ1Y/FE
         djpzcsfpnz1p2wDcSuQc2PVPc6WB2Cm/NVjeIKqA7Le0UKxZqtdcFxXgigLGDxexGQdM
         WJhA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=U/bypAIJR14PKr6nNtQ29B74Nh/66smQqquuiyHiN7U=;
        b=eeIjB3ywwg0wRDLnwPu40N1Lu//orn8C24P6QSH6gnPMtM9+8kAMZKQkfjXzt30Zbj
         tpr6PwGwJtpnVlIaX6J5OZYqH3CtLYssZEZ/5S4xNDo00YtnH++0kOf3BbWIHAHdcfHq
         WYdZ70rBiyXSlgHjdWM5Xa8ylFWsLscW866Dlifmv3WxEdEst2gLXO2UFiyihaeXVXja
         MKAtHNaLh7ns7pXx/gwyiMIeuMcAc0voKfI+bN1Hdpd+/9UpSibVfDvVSrEufzWInydZ
         BgDzgqsOlypwFlmBWEZDm5bZK4VtubOwTb/Cyb0RdFHg/7eEHgrqS8hnOUhEynXeQsak
         Tlgw==
X-Gm-Message-State: AOAM530uxwf+UHxWDON3+5LbRZ4VPnlKt4AKUBd19e60ilmZl+VIsEu0
	dYb4GScsIPZezhbYVcXzS9TTfiR9zk0cG0vruCZw4g==
X-Google-Smtp-Source: ABdhPJx60ykEasgEpEkjCxT/XABFqxjqL5Q7iy17Rg0NQykiiMMw5AsyBm6pYy/lVBWd9Ru9E9Z3odBR8Sf6yTJhIkQ=
X-Received: by 2002:a62:520e:0:b0:3e2:1c21:f1ba with SMTP id
 g14-20020a62520e000000b003e21c21f1bamr324419pfb.78.1631322906048; Fri, 10 Sep
 2021 18:15:06 -0700 (PDT)
MIME-Version: 1.0
References: <cover.1628767741.git.min.m.xu@intel.com> <c574d1e106a9b10d99b0d294891a32ee2b0c414a.1628767741.git.min.m.xu@intel.com>
In-Reply-To: <c574d1e106a9b10d99b0d294891a32ee2b0c414a.1628767741.git.min.m.xu@intel.com>
From: "Erdem Aktas" <erdemaktas@google.com>
Date: Sat, 11 Sep 2021 04:14:54 +0300
Message-ID: <CAAYXXYxjARUXvPMTGpVZQumnk8GDS1+z4PVBJ9AcmTDC4cr3ew@mail.gmail.com>
Subject: Re: [PATCH 05/23] MdePkg: Add TdxProbeLib to probe Intel Tdx
To: Min Xu <min.m.xu@intel.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>, Michael D Kinney <michael.d.kinney@intel.com>, 
	Liming Gao <gaoliming@byosoft.com.cn>, Zhiguang Liu <zhiguang.liu@intel.com>, 
	Brijesh Singh <brijesh.singh@amd.com>, James Bottomley <jejb@linux.ibm.com>, 
	Jiewen Yao <jiewen.yao@intel.com>, Tom Lendacky <thomas.lendacky@amd.com>
Content-Type: text/plain; charset="UTF-8"

On Thu, Aug 12, 2021 at 2:57 PM Min Xu <min.m.xu@intel.com> wrote:
> +
> +#include <Library/BaseLib.h>
> +#include "InternalTdxProbe.h"
> +
> +/**
> +  TDX only works in X64. So allways return -1 to indicate Non-Td.
s/allways/always

Also, -1 or 1? PROBE_NOT_TD_GUEST is defined as 1.