From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179])
 by mx.groups.io with SMTP id smtpd.web09.1894.1631322846639799971
 for <devel@edk2.groups.io>;
 Fri, 10 Sep 2021 18:14:06 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@google.com header.s=20210112 header.b=dvOd40D6;
 spf=pass (domain: google.com, ip: 209.85.210.179, mailfrom: erdemaktas@google.com)
Received: by mail-pf1-f179.google.com with SMTP id j6so3110536pfa.4
        for <devel@edk2.groups.io>; Fri, 10 Sep 2021 18:14:06 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=google.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=KHoimZ72FurgtaPlEwPmFqbgU+sNzKwKAM7xxooG5rg=;
        b=dvOd40D6Z7TAH2oMqEEtMJIsXJGAG97xtTNQPppi7B7NXRn9swBr1Fzs0yFVRtdNOL
         YiMTBYm+3ow83VkcOgPmXTZ3MHG21UIx6iDBB66VoPC+mDsKkKvj1cpcCoMdlrZbVCnf
         tzJDjC0iq0/+XiKpsB97ytoK7nKo5eP71FYbuz2VBc4tHF2gW1Jr9+I9eBjPxpudB3Ms
         Oo749IH1tdWD3Jcaxa84nowqjwlmTkRd+WQei9sU952DBvJfkdda/GGy20g3C+g2c7cB
         xhHhzvfjStq+vpt/KYVHYBbG5Kd9aOwd6ZMFW3EiiFFyNqjvltocUe2xBcW0MxHofVqJ
         c3vg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=KHoimZ72FurgtaPlEwPmFqbgU+sNzKwKAM7xxooG5rg=;
        b=2DeZLBPsXi4UDpWrctiOO0ke8j1tLCR2m8meMr92u+5PsB1WQ1hxkF47UM2DFiskmX
         lLlSF9RJdlQaBoaSRwPjf/eTOD1M5Wi2pbY2d4yZ9wYlseCOKhBodjGkCpTElHLeSk5u
         58iZ4W5zu/qQR9ZQLBDNqtr3ALqnsuFTtjD5Be1tZTJmcEk0M1YQLKXIUImkrNNxDNHJ
         Clc8xw4w+K/Td4jTwDBstR+UHpXRxGKkCxzrH530U+fGyAVttnRyZ50DvmUPtUohfhSc
         ruZPE5xuLo9sM6S5TsbujeKRL9seNY85GOgZYXcQ6+GvDhukwI9wzntTzVO8U/OxxzfR
         AU7w==
X-Gm-Message-State: AOAM530F4fZMNRu0eV0HqxDBmAEpP1E+EBigV9+iSN+nbcekaxZWc6pr
	RD9Xp0s7O8PHKMHg4eyz25cDU8CvR63JAQOSsIjY6A==
X-Google-Smtp-Source: ABdhPJxexHXmOys1pFbX84rfVMP4g9oCuSZvJ7yh84IRxKgvJCDrvvxCcgmZun4HqxUwmVurePfhAa+b3mR+39a3XlY=
X-Received: by 2002:a63:a80c:: with SMTP id o12mr452061pgf.422.1631322845820;
 Fri, 10 Sep 2021 18:14:05 -0700 (PDT)
MIME-Version: 1.0
References: <cover.1628767741.git.min.m.xu@intel.com> <fa60c4117988f65a76f7422b2beae0f9425615d9.1628767741.git.min.m.xu@intel.com>
In-Reply-To: <fa60c4117988f65a76f7422b2beae0f9425615d9.1628767741.git.min.m.xu@intel.com>
From: "Erdem Aktas" <erdemaktas@google.com>
Date: Sat, 11 Sep 2021 04:13:54 +0300
Message-ID: <CAAYXXYyhg=0KUV4+_bS+VO-_VzeA9HhRW8utrLds8FXYnuTDiQ@mail.gmail.com>
Subject: Re: [PATCH 02/23] OvmfPkg/Sec: Update the check logic in SevEsIsEnabled
To: Min Xu <min.m.xu@intel.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>, Ard Biesheuvel <ardb+tianocore@kernel.org>, 
	Jordan Justen <jordan.l.justen@intel.com>, Brijesh Singh <brijesh.singh@amd.com>, 
	James Bottomley <jejb@linux.ibm.com>, Jiewen Yao <jiewen.yao@intel.com>, 
	Tom Lendacky <thomas.lendacky@amd.com>
Content-Type: text/plain; charset="UTF-8"

On Thu, Aug 12, 2021 at 2:57 PM Min Xu <min.m.xu@intel.com> wrote:
>
> RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
>
> SevEsIsEnabled return TRUE if SevEsWorkArea->SevEsEnabled is non-zero.
s/return/returns

> It is correct when SevEsWorkArea is only used by SEV. After Intel TDX
> is enabled in Ovmf, the SevEsWorkArea is shared by TDX and SEV. (This
> is to avoid the waist of memory region in MEMFD). The value of
s/waist/waste