From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by mx.groups.io with SMTP id smtpd.web12.572.1621275914859476461 for ; Mon, 17 May 2021 11:25:14 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@google.com header.s=20161025 header.b=qDS/Kg6g; spf=pass (domain: google.com, ip: 209.85.215.169, mailfrom: erdemaktas@google.com) Received: by mail-pg1-f169.google.com with SMTP id m124so5203005pgm.13 for ; Mon, 17 May 2021 11:25:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6v/CFLyLQi0ChSdisBwKDqreJ5ZoEaFum5K8Tg9TIxs=; b=qDS/Kg6g0XV9D9yO8RQQqmc4ah3+vqtm7YxMVGLufowD2sFgjfLC9eTTI3UKxs9dLP XwSFpGq0FYu7Xq2yYq3o+DiVkduBclahcrABtaNi1wtBRH7RTE14HaKgvGBUuX7WeVlP paQwTj8Pb4dH9dlhf5uq5LyJFTYBDPdGuDslqi7vS2nOXYzid+wnFvgPKCqijHzAKHKf 347OJLYs+7NkKvddG0zxAdVr2jsQfFeHWGr772f5hDi8DKMT3mYpJCWXe/BGmH5ue9UX 7UAHoNRp06uNruEUGKjoyyknjV4XCzikVOAE6KfxQ1SglQ84clp1NZA4rBBhsKKk6db5 m9/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6v/CFLyLQi0ChSdisBwKDqreJ5ZoEaFum5K8Tg9TIxs=; b=p8Ezt/JslF6/Dh1RbEWWxuTEyBK6lDHQX5mIkUNQtccT6vuacByvyg/J6q+1q1SlDq NfUHE9TXJZ9lifF2Nv0rnKUfJUK7t/iZnGbZp7Z+7TEwjf9TLSb2TTNkBbwBNNX5SNCi su5RG5i3p6FWQg425rSdp/Ru2plr3OjObPU20FCQkpIpjbi+Ft7Xj0tiprNW13UtS+YK 6fp+MJyzGgb5jRg2bhNXuR52L/8Q4jP6sNIfJdzz3wYK0xZm7t2yXpY4WyUmtTwcLnEE n3lJcC1w88394Y+GE7Cel3fe39aJhgtqdyrIxmCWrxXcgNXRaRwoFS3ivJF3AHc80+If AJ8g== X-Gm-Message-State: AOAM532BMXtS+OBkI1lrivVpSiRrjiAWcV67o+i8pJIAKMB0vsgQBmqz PO5872ishCS6DQQi2oGS1crKu/7e8WpLKPQvachqcA== X-Google-Smtp-Source: ABdhPJzZyRxMxnWfr1E4/SmK82pZa9fazHnTNJQwmc4LbrVvju2VQ3hqEtNjyg4oBYtQlT90oPm/uKiopDi0GOLex5s= X-Received: by 2002:aa7:864f:0:b029:2d5:7923:2753 with SMTP id a15-20020aa7864f0000b02902d579232753mr951917pfo.4.1621275914075; Mon, 17 May 2021 11:25:14 -0700 (PDT) MIME-Version: 1.0 References: <20210512234615.1726-1-brijesh.singh@amd.com> <20210512234615.1726-5-brijesh.singh@amd.com> In-Reply-To: <20210512234615.1726-5-brijesh.singh@amd.com> From: "Erdem Aktas" Date: Mon, 17 May 2021 11:25:03 -0700 Message-ID: Subject: Re: [PATCH v2 04/13] MdePkg/Register/Amd: define GHCB macro for Register GPA structure To: Brijesh Singh Cc: devel@edk2.groups.io, James Bottomley , Min Xu , Jiewen Yao , Tom Lendacky , Jordan Justen , Ard Biesheuvel , Laszlo Ersek , Michael D Kinney , Liming Gao , Zhiguang Liu Content-Type: text/plain; charset="UTF-8" I verified that the values align with the GHCB spec publication: #56421 Revision: 2.00 Just one question: is there any reason why GHCB_* defines are decimal while the SVM_EXIT_* are all in hexadecimal? Does EDK2 have any preference? Reviewed-by: Erdem Aktas -Erdem On Wed, May 12, 2021 at 4:46 PM Brijesh Singh wrote: > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > An SEV-SNP guest is required to perform the GHCB GPA registration. See > the GHCB specification for further details. > > Cc: James Bottomley > Cc: Min Xu > Cc: Jiewen Yao > Cc: Tom Lendacky > Cc: Jordan Justen > Cc: Ard Biesheuvel > Cc: Laszlo Ersek > Cc: Erdem Aktas > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Reviewed-by: Laszlo Ersek > Reviewed-by: Liming Gao > Signed-off-by: Brijesh Singh > --- > MdePkg/Include/Register/Amd/Fam17Msr.h | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/MdePkg/Include/Register/Amd/Fam17Msr.h b/MdePkg/Include/Register/Amd/Fam17Msr.h > index cdb8f588ccf8..542e4cdf4782 100644 > --- a/MdePkg/Include/Register/Amd/Fam17Msr.h > +++ b/MdePkg/Include/Register/Amd/Fam17Msr.h > @@ -53,6 +53,11 @@ typedef union { > UINT64 Features:52; > } GhcbHypervisorFeatures; > > + struct { > + UINT64 Function:12; > + UINT64 GuestFrameNumber:52; > + } GhcbGpaRegister; > + > VOID *Ghcb; > > UINT64 GhcbPhysicalAddress; > @@ -62,6 +67,8 @@ typedef union { > #define GHCB_INFO_SEV_INFO_GET 2 > #define GHCB_INFO_CPUID_REQUEST 4 > #define GHCB_INFO_CPUID_RESPONSE 5 > +#define GHCB_INFO_GHCB_GPA_REGISTER_REQUEST 18 > +#define GHCB_INFO_GHCB_GPA_REGISTER_RESPONSE 19 > #define GHCB_HYPERVISOR_FEATURES_REQUEST 128 > #define GHCB_HYPERVISOR_FEATURES_RESPONSE 129 > #define GHCB_INFO_TERMINATE_REQUEST 256 > -- > 2.17.1 >