public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Phillip Tennen <phillip@axleos.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>,
	 Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Jiewen Yao <jiewen.yao@intel.com>,
	devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH v2 1/1] OvmfPkg: OVMF supports USB mouses
Date: Mon, 8 Apr 2024 08:53:10 +0100	[thread overview]
Message-ID: <CAAi_9z4FXr9YWK7CnFn-_0bDnVdKKDiqPfpyQpKD2Fp7-0t20A@mail.gmail.com> (raw)
In-Reply-To: <dhi3aftt2jty6rbm4myuoave5jhubr3mfpd7ko5galwqk776fa@ja2jovkhvyks>

[-- Attachment #1: Type: text/plain, Size: 1807 bytes --]

Hi, thank you for taking a look at the patch!

This patch can be verified to be working with this app (which was the
motivation for submitting this):
https://github.com/codyd51/uefirc/releases/tag/1.0.1.

I am happy to switch to a tablet device if that's a clearer choice (pending
environment setup/line ending issues on my end while generating the patch).

I am also happy to add this to other Omvf variants, but am less confident in
my ability to test those.

All the best,
Phillip

On Mon, Apr 8, 2024 at 8:35 AM Gerd Hoffmann <kraxel@redhat.com> wrote:

> On Sat, Apr 06, 2024 at 02:41:54PM +0200, Heinrich Schuchardt wrote:
> > From: Phillip Tennen <phillip@axleos.com>
> >
> > From: Phillip Tennen <phillip@axleos.com>
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4747
> >
> > UsbMouseDxe was missing from the OVMF build description, so=20
> > the Simple Pointer Protocol wasn't usable from within QEMU.
>
> What is the use case?
>
> How can this be tested?  As far I know neither the edk2 setup utility
> (aka UiApp) nor typical OS boot loaders have mouse support ...
>
> Also note that virtual machines typically do *not* have a mouse but a
> tablet device, so UsbMouseAbsolutePointerDxe looks like the more
> sensible choice to me.
>
> >  OvmfPkg/OvmfPkgX64.dsc | 1 +
> >  OvmfPkg/OvmfPkgX64.fdf | 1 +
>
> What about the other ovmf variants?
>
> take care,
>   Gerd
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117539): https://edk2.groups.io/g/devel/message/117539
Mute This Topic: https://groups.io/mt/105365480/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 3000 bytes --]

  reply	other threads:[~2024-04-09  6:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-06 12:41 [edk2-devel] [PATCH v2 1/1] OvmfPkg: OVMF supports USB mouses Heinrich Schuchardt
2024-04-08  7:35 ` Gerd Hoffmann
2024-04-08  7:53   ` Phillip Tennen [this message]
2024-04-09 11:55     ` Gerd Hoffmann
2024-04-09 12:50       ` Ard Biesheuvel
2024-04-09 15:51       ` Pedro Falcato
2024-04-10  8:54         ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAi_9z4FXr9YWK7CnFn-_0bDnVdKKDiqPfpyQpKD2Fp7-0t20A@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox