From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id C7C0C740032 for ; Tue, 9 Apr 2024 06:29:31 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=biZpPjtULPUfPSFdHbZ+b6X37uV4SzSPHt3uAtkqSi8=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240206; t=1712644170; v=1; b=AIbfYvKzmhQBRH/7LHiLBHJgLH+FqT8mGX+vOJ2ZJsQkdLs9GyEn4KiE45C//EIE10Ib467q tfroanqmDJ+kL58FDtuJ39AI/HZJuEHltLAAG4l5GTMNvYPuyp1g3bAQeSLa0GoNYxnpwHsIGOZ WNuHG89eFX+t1X1Gqt2abDE1mkR466ZAgfrfuTniHmqL5gZWuhwc4yHXvdI/e75mZba5Z+an3xd MJjKqHiKCgyYHT8lX5RHYRwHwIh0nnWaV6I1nOkfyR/UmKR4r8YPoaY/z6fv7OgevIsQmkLAesf SxtbA4VXKDF0DbK5eSw3/VoaVTPRnyQCnE1uwTMeT+/Nw== X-Received: by 127.0.0.2 with SMTP id CE7OYY7687511xvgCMexNMGP; Mon, 08 Apr 2024 23:29:30 -0700 X-Received: from mail-vs1-f41.google.com (mail-vs1-f41.google.com [209.85.217.41]) by mx.groups.io with SMTP id smtpd.web10.100997.1712562803166045212 for ; Mon, 08 Apr 2024 00:53:23 -0700 X-Received: by mail-vs1-f41.google.com with SMTP id ada2fe7eead31-479c9c2d2b0so1179367137.0 for ; Mon, 08 Apr 2024 00:53:23 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCWNGAYQZ1CeOkmsxv2k4A99FZqw1pjpfTOFRtRAUm+4/oUlc+EkkPPj5fbZOg6C1DrVFnUz02a6W04GeX/1HaZHVEHMnA== X-Gm-Message-State: HcKvcdbbIpeEsXmhHzltHDh3x7686176AA= X-Google-Smtp-Source: AGHT+IGczsQWGqbScxlhweoQ8DIR8zxR/AyvWJV3KD5aCX3T6Cu+QcJu6tgeyIk2eI08nYoMoSQ6Nw== X-Received: by 2002:a05:6102:5108:b0:479:eb46:f740 with SMTP id bm8-20020a056102510800b00479eb46f740mr3304121vsb.20.1712562802035; Mon, 08 Apr 2024 00:53:22 -0700 (PDT) X-Received: from mail-ua1-f54.google.com (mail-ua1-f54.google.com. [209.85.222.54]) by smtp.gmail.com with ESMTPSA id dh27-20020a056102579b00b0047693848798sm1236053vsb.24.2024.04.08.00.53.21 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Apr 2024 00:53:21 -0700 (PDT) X-Received: by mail-ua1-f54.google.com with SMTP id a1e0cc1a2514c-7e3b3e33aa7so1288091241.3 for ; Mon, 08 Apr 2024 00:53:21 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCWEfqRFF7/noQQP+srxnMrkcIqMUpVn3CkkycSAmdX87+dNNjnme4la3Qm7WQiQAC9eQmX3jnPaFAkDQSbIZDH+gCSjtA== X-Received: by 2002:a05:6102:32d2:b0:47a:bdb:544e with SMTP id o18-20020a05610232d200b0047a0bdb544emr568002vss.27.1712562801500; Mon, 08 Apr 2024 00:53:21 -0700 (PDT) MIME-Version: 1.0 References: <20240406124154.17978-1-heinrich.schuchardt@canonical.com> In-Reply-To: From: Phillip Tennen Date: Mon, 8 Apr 2024 08:53:10 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v2 1/1] OvmfPkg: OVMF supports USB mouses To: Gerd Hoffmann Cc: Heinrich Schuchardt , Ard Biesheuvel , Jiewen Yao , devel@edk2.groups.io Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 08 Apr 2024 23:29:30 -0700 Resent-From: phillip@axleos.com Reply-To: devel@edk2.groups.io,phillip@axleos.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: multipart/alternative; boundary="0000000000007073a706159119ba" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=AIbfYvKz; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=axleos.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --0000000000007073a706159119ba Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, thank you for taking a look at the patch! This patch can be verified to be working with this app (which was the motivation for submitting this): https://github.com/codyd51/uefirc/releases/tag/1.0.1. I am happy to switch to a tablet device if that's a clearer choice (pending environment setup/line ending issues on my end while generating the patch). I am also happy to add this to other Omvf variants, but am less confident i= n my ability to test those. All the best, Phillip On Mon, Apr 8, 2024 at 8:35=E2=80=AFAM Gerd Hoffmann wr= ote: > On Sat, Apr 06, 2024 at 02:41:54PM +0200, Heinrich Schuchardt wrote: > > From: Phillip Tennen > > > > From: Phillip Tennen > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4747 > > > > UsbMouseDxe was missing from the OVMF build description, so=3D20 > > the Simple Pointer Protocol wasn't usable from within QEMU. > > What is the use case? > > How can this be tested? As far I know neither the edk2 setup utility > (aka UiApp) nor typical OS boot loaders have mouse support ... > > Also note that virtual machines typically do *not* have a mouse but a > tablet device, so UsbMouseAbsolutePointerDxe looks like the more > sensible choice to me. > > > OvmfPkg/OvmfPkgX64.dsc | 1 + > > OvmfPkg/OvmfPkgX64.fdf | 1 + > > What about the other ovmf variants? > > take care, > Gerd > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117539): https://edk2.groups.io/g/devel/message/117539 Mute This Topic: https://groups.io/mt/105365480/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --0000000000007073a706159119ba Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi, thank you for taking a look at t= he patch!

This patch can be verified to be working with this app (wh= ich was the
motivation for submitting this):
https://github.com/codyd51/uefirc/= releases/tag/1.0.1.

I am happy to switch to a tablet device if = that's a clearer choice (pending
environment setup/line ending issue= s on my end while generating the patch).

I am also happy to add this= to other Omvf variants, but am less confident in
my ability to test tho= se.

All the best,=C2=A0
Phillip

On Mon, Apr 8, 2= 024 at 8:35=E2=80=AFAM Gerd Hoffmann <kraxel@redhat.com> wrote:
On Sat, Apr 0= 6, 2024 at 02:41:54PM +0200, Heinrich Schuchardt wrote:
> From: Phillip Tennen <phillip@axleos.com>
>
> From: Phillip Tennen <phillip@axleos.com>
>
> REF: https://bugzilla.tianocore.org/show_b= ug.cgi?id=3D4747
>
> UsbMouseDxe was missing from the OVMF build description, so=3D20
> the Simple Pointer Protocol wasn't usable from within QEMU.

What is the use case?

How can this be tested?=C2=A0 As far I know neither the edk2 setup utility<= br> (aka UiApp) nor typical OS boot loaders have mouse support ...

Also note that virtual machines typically do *not* have a mouse but a
tablet device, so UsbMouseAbsolutePointerDxe looks like the more
sensible choice to me.

>=C2=A0 OvmfPkg/OvmfPkgX64.dsc | 1 +
>=C2=A0 OvmfPkg/OvmfPkgX64.fdf | 1 +

What about the other ovmf variants?

take care,
=C2=A0 Gerd

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#117539) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--0000000000007073a706159119ba--