From: "Ross Burton" <ross@burtonini.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Gao, Liming" <gaoliming@byosoft.com.cn>,
Pedro Falcato <pedro.falcato@gmail.com>,
"Feng, Bob C" <bob.c.feng@intel.com>,
"Chen, Christine" <yuwei.chen@intel.com>
Subject: Re: [edk2-devel] [PATCH] BaseTools/Brotli: update to latest brotli submodule
Date: Thu, 23 Dec 2021 22:53:22 +0000 [thread overview]
Message-ID: <CAAnfSTtctdFCPaWkwRAuebYMsDUAvqk1Z6+Es1TDN3FcNEc+-Q@mail.gmail.com> (raw)
In-Reply-To: <SA2PR11MB493898EFDFD0637954EEC1A0D27E9@SA2PR11MB4938.namprd11.prod.outlook.com>
My original PR has passed CI: https://github.com/tianocore/edk2/pull/2231
Ross
On Thu, 23 Dec 2021 at 22:35, Kinney, Michael D
<michael.d.kinney@intel.com> wrote:
>
> Hi Ross,
>
> This PR is showing CI failures with VS2019
>
> https://dev.azure.com/tianocore/11ea4a10-ac9f-4e5f-8b13-7def1f19d478/_apis/build/builds/36559/logs/178
>
> 2021-12-23T00:53:44.7544282Z PROGRESS - Running Build DEBUG
> 2021-12-23T00:54:36.3840067Z ERROR - Compiler #2059 from C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\include\vcruntime_string.h(67): syntax error: '('
> 2021-12-23T00:54:36.3841683Z ERROR - Compiler #2146 from C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\include\vcruntime_string.h(67): syntax error: missing ')' before identifier 'UINTN'
> 2021-12-23T00:54:36.3845453Z WARNING - Compiler #4029 from C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\include\vcruntime_string.h(67): declared formal parameter list different from definition
> 2021-12-23T00:54:36.3847199Z ERROR - Compiler #2059 from C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\include\vcruntime_string.h(67): syntax error: ')'
> 2021-12-23T00:54:36.3851318Z ERROR - Compiler #2059 from C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\include\vcruntime_string.h(67): syntax error: '<parameter-list>'
> 2021-12-23T00:54:36.3853972Z WARNING - Compiler #4205 from C:\Program Files (x86)\Windows Kits\10\include\10.0.22000.0\ucrt\corecrt_memcpy_s.h(45): nonstandard extension used: static function declaration in function scope
> 2021-12-23T00:54:36.3858517Z WARNING - Compiler #4020 from C:\Program Files (x86)\Windows Kits\10\include\10.0.22000.0\ucrt\corecrt_memcpy_s.h(54): 'SetMem': too many actual parameters
> 2021-12-23T00:54:36.3861595Z WARNING - Compiler #4020 from d:\a\1\s\MdeModulePkg\Library\BrotliCustomDecompressLib\brotli\c\common\shared_dictionary.c(103): 'SetMem': too many actual parameters
> 2021-12-23T00:54:36.3864836Z WARNING - Compiler #4020 from d:\a\1\s\MdeModulePkg\Library\BrotliCustomDecompressLib\brotli\c\common\shared_dictionary.c(496): 'SetMem': too many actual parameters
> 2021-12-23T00:54:36.3867350Z ERROR - Compiler #1077 from NMAKE : fatal '"C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\bin\Hostx86\x86\cl.exe"' : return code '0x2'
> 2021-12-23T00:54:36.3870885Z ERROR - Compiler #7000 from : Failed to execute command
> 2021-12-23T00:54:36.3873160Z ERROR - EDK2 #002 from : Failed to build module
> 2021-12-23T00:54:36.3878035Z CRITICAL - Build failed
>
> Can you please resolve and update the PR.
>
> Thanks,
>
> Mike
>
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ross Burton
> > Sent: Thursday, December 23, 2021 2:02 AM
> > To: Gao, Liming <gaoliming@byosoft.com.cn>
> > Cc: Pedro Falcato <pedro.falcato@gmail.com>; edk2-devel-groups-io <devel@edk2.groups.io>; Feng, Bob C <bob.c.feng@intel.com>;
> > Chen, Christine <yuwei.chen@intel.com>
> > Subject: Re: [edk2-devel] [PATCH] BaseTools/Brotli: update to latest brotli submodule
> >
> > On Thu, 23 Dec 2021 at 00:48, gaoliming <gaoliming@byosoft.com.cn> wrote:
> > > Create PR https://github.com/tianocore/edk2/pull/2346 for this patch.
> >
> > There are now *three* PRs on GitHub to solve this issue, which is a
> > build breaker for anyone using a new GCC.
> >
> > Can someone please merge the fix?
> >
> > Ross
> >
> >
> >
> >
>
next prev parent reply other threads:[~2021-12-23 22:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-20 16:55 [PATCH] BaseTools/Brotli: update to latest brotli submodule Ross Burton
2021-12-20 17:01 ` [edk2-devel] " Pedro Falcato
2021-12-23 0:48 ` 回复: " gaoliming
2021-12-23 10:02 ` Ross Burton
2021-12-23 22:34 ` Michael D Kinney
2021-12-23 22:53 ` Ross Burton [this message]
2021-12-24 1:42 ` 回复: " gaoliming
2022-01-11 14:37 ` Bob Feng
2022-01-11 23:45 ` Pedro Falcato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAnfSTtctdFCPaWkwRAuebYMsDUAvqk1Z6+Es1TDN3FcNEc+-Q@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox