From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id E97C57803D7 for ; Thu, 19 Oct 2023 14:38:09 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=6RwWALKiykFvbqk4+xu1bWRa2gSZTlxa4meVe4YsOJU=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1697726288; v=1; b=Tg+Y62R/I+2EEv8EE/d/wX2sXczTbjtNmY7VfqIW0y5tJ5Cx4r/n0nq0LsDV+cU4x+sVJSP6 GICQQ10VJ/OhbZhcfQcP5y/Y9GtIivsdIGkHsoBU107eCJuWWzN3egFPdATwoWekVDtbCjQwWB7 XJoHhtxcTKVF38VA4PugARXE= X-Received: by 127.0.0.2 with SMTP id 4VZ3YY7687511xvngpZuYJJM; Thu, 19 Oct 2023 07:38:08 -0700 X-Received: from mail-yb1-f177.google.com (mail-yb1-f177.google.com [209.85.219.177]) by mx.groups.io with SMTP id smtpd.web10.29633.1697726287540311838 for ; Thu, 19 Oct 2023 07:38:07 -0700 X-Received: by mail-yb1-f177.google.com with SMTP id 3f1490d57ef6-d9ad67058fcso8604168276.1 for ; Thu, 19 Oct 2023 07:38:07 -0700 (PDT) X-Gm-Message-State: PLNea8KXqrW9VJJCQQC23kJdx7686176AA= X-Google-Smtp-Source: AGHT+IGpL9DfWrcqg+ugvOy/r28h8h452luVh1QGk3zETtzpersUMjv3JZYNEmHel4pDcKQAt4hOJtLMCUeNpEtaY6g= X-Received: by 2002:a25:cad0:0:b0:d81:894b:28e4 with SMTP id a199-20020a25cad0000000b00d81894b28e4mr2887395ybg.51.1697726286579; Thu, 19 Oct 2023 07:38:06 -0700 (PDT) MIME-Version: 1.0 References: <20231017121755.190285-1-dhaval@rivosinc.com> <20231017121755.190285-3-dhaval@rivosinc.com> <5466efed-8dd4-1b8a-2bce-d0f324532f27@redhat.com> <53a05d2b-7288-8d6e-d338-f09bb2c16a7b@redhat.com> In-Reply-To: <53a05d2b-7288-8d6e-d338-f09bb2c16a7b@redhat.com> From: "Dhaval Sharma" Date: Thu, 19 Oct 2023 20:07:55 +0530 Message-ID: Subject: Re: [edk2-devel] [PATCH v5 2/2] OvmfPkg/RiscVVirt: Override for RV CPU Features To: devel@edk2.groups.io, lersek@redhat.com Cc: Oliver Steffen Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,dhaval@rivosinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: multipart/alternative; boundary="0000000000003ce6ae060812b447" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="Tg+Y62R/"; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --0000000000003ce6ae060812b447 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable It was introduced in 2.39 it seems. GCC 12 onwards contains this binutils version as per my understanding. This version was released quite long back. I can double check by submitting it through edk2 CI to ensure it works. Current CI version is already GCC 12. On Thu, Oct 19, 2023 at 5:47=E2=80=AFPM Laszlo Ersek wr= ote: > On 10/19/23 11:22, Laszlo Ersek wrote: > > On 10/19/23 08:48, Dhaval Sharma wrote: > > >> (11) I agree that we should use symbolic names rather than > >> magic constants, but raw encodings of machine instructions don't belon= g > >> into a > >> C header file. [Dhaval] This bytecode was introduced thinking wha= t > >> if all compilers do not support it. but given the default compiler in > >> edk2 GCC 12 supports it > >> we can eliminate this byte encoding completely to make it easy an= d > >> simple to consume for others. > > > > To be honest, I can't determine the minimum expected gcc version for > > edk2. "BaseTools/Conf/tools_def.template" states a minimum version for > > NASM, for example, but I can't find a similar gcc requirement there. > > > > gcc-12 does work for me personally, because my riscv cross-compiler is > > "riscv64-linux-gnu-gcc (GCC) 12.1.1 20220507 (Red Hat Cross 12.1.1-1)". > > > > If the CI environment that builds these patches also provides gcc-12+, > > then I figure you should be set. > > Wait, for the assembly language source files, what matters is the > binutils version, not the gcc version. Mine is "GNU assembler version > 2.38-3.el9" (from "binutils-riscv64-linux-gnu-2.38-3.el9.x86_64"). > > Is that sufficient for the instuctions in question? > > (More generally -- what version does our CI env expect / provide?) > > Thanks > Laszlo > > --=20 Thanks! =3DD -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109813): https://edk2.groups.io/g/devel/message/109813 Mute This Topic: https://groups.io/mt/102016149/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --0000000000003ce6ae060812b447 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
It was introduced in 2.39 it seems. GCC 12 onwards contain= s this binutils version as per my understanding. This version was released = quite long back. I can double check by submitting it through edk2 CI to ens= ure it works. Current CI version is already GCC 12.=C2=A0

On Thu, Oct 19, 20= 23 at 5:47=E2=80=AFPM Laszlo Ersek <lersek@redhat.com> wrote:
On 10/19/23 11:22, Laszlo Ersek wrote:
> On 10/19/23 08:48, Dhaval Sharma wrote:

>> (11) I agree that we should use symbolic names rather than
>> magic=C2=A0constants, but raw encodings of machine instructions do= n't belong
>> into a
>> =C2=A0 =C2=A0 =C2=A0C header file. [Dhaval] This bytecode was intr= oduced thinking what
>> if all compilers do not support it. but given the default compiler= in
>> edk2 GCC 12 supports it
>> =C2=A0 =C2=A0 =C2=A0we can eliminate this byte encoding completely= to make it easy and
>> simple to consume for others.
>
> To be honest, I can't determine the minimum expected gcc version f= or
> edk2. "BaseTools/Conf/tools_def.template" states a minimum v= ersion for
> NASM, for example, but I can't find a similar gcc requirement ther= e.
>
> gcc-12 does work for me personally, because my riscv cross-compiler is=
> "riscv64-linux-gnu-gcc (GCC) 12.1.1 20220507 (Red Hat Cross 12.1.= 1-1)".
>
> If the CI environment that builds these patches also provides gcc-12+,=
> then I figure you should be set.

Wait, for the assembly language source files, what matters is the
binutils version, not the gcc version. Mine is "GNU assembler version<= br> 2.38-3.el9" (from "binutils-riscv64-linux-gnu-2.38-3.el9.x86_64&q= uot;).

Is that sufficient for the instuctions in question?

(More generally -- what version does our CI env expect / provide?)

Thanks
Laszlo



--
Thanks!
=3DD
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#109813) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--0000000000003ce6ae060812b447--