Re: [edk2-devel] [PATCH v2 0/1] UefiPayloadPkg: Set default PciBaseSize on Ia32

["Marcello Sylvester Bauer" <marcello.bauer@9elements.com>]

[-- Attachment #1: Type: text/plain, Size: 4897 bytes --]

Hi Guo,

Sounds good to remove the IA32 target and stick to a single DSC file.
However, Is there an advantage to remove the PEI phase? It breaks many of
our upcoming patches, which currently rely on the PEI phase (e.g.
SecureBoot support).

In addition to the failed PatchCheck, it does not build on Linux gcc:
https://github.com/9elements/edk2/runs/1373473040

thanks,
Marcello


On Sat, Oct 24, 2020 at 12:36 AM Dong, Guo <guo.dong@intel.com> wrote:

>
>
> Hi Marcello,
>
>
>
> It looks there is issue for the CI tool to complete all the checks. So I
> just closed this PR.
>
>
>
> And I just created another PR https://github.com/tianocore/edk2/pull/1046
> to remove PEI phase from UEFI payload.
>
> If the new patch is approved, we don’t need this patch to update DSC file.
>
> In the new patch, UEFI payload would use a single DSC file to support X64,
> IA32X64 and possibly IA32 build.
>
> Please have a look at that PR and let me know if you have any comments.
>
>
>
> Thanks,
>
> Guo
>
>
>
> *From:* devel@edk2.groups.io <devel@edk2.groups.io> * On Behalf Of *Guo
> Dong
> *Sent:* Thursday, October 22, 2020 7:49 PM
> *To:* Marcello Sylvester Bauer <marcello.bauer@9elements.com>; Ma,
> Maurice <maurice.ma@intel.com>
> *Cc:* devel@edk2.groups.io; patrick.rudolph@9elements.com; You, Benjamin <
> benjamin.you@intel.com>
> *Subject:* Re: [edk2-devel] [PATCH v2 0/1] UefiPayloadPkg: Set default
> PciBaseSize on Ia32
>
>
>
>
>
> Hi Marcello,
>
>
>
> Sorry for late response. I created a pull request
> https://github.com/tianocore/edk2/pull/1044 to merge this patch 2 hours
> ago.
>
> Hopefully it could be merged soon after all the checks.
>
>
>
> Thanks,
>
> Guo
>
>
>
> *From:* Marcello Sylvester Bauer <marcello.bauer@9elements.com>
> *Sent:* Thursday, October 22, 2020 1:25 AM
> *To:* Ma, Maurice <maurice.ma@intel.com>
> *Cc:* devel@edk2.groups.io; patrick.rudolph@9elements.com; Dong, Guo <
> guo.dong@intel.com>; You, Benjamin <benjamin.you@intel.com>
> *Subject:* Re: [PATCH v2 0/1] UefiPayloadPkg: Set default PciBaseSize on
> Ia32
>
>
>
> Hi,
>
> As already mentioned, this patch fixes the current master build for the
> UefiPayloadPkgIa32 platform.
> Is it possible to merge this change soon?
>
>
>
> Sorry for the circumstances.
>
>
> thanks,
> Marcello
>
> On Tue, Oct 13, 2020 at 9:02 PM Ma, Maurice <maurice.ma@intel.com> wrote:
>
> Reviewed-by:
> Maurice Ma <maurice.ma@intel.com>
>
> > -----Original Message-----
> > From: Marcello Sylvester Bauer <marcello.bauer@9elements.com>
> > Sent: Tuesday, October 13, 2020 6:34
> > To: devel@edk2.groups.io
> > Cc: Marcello Sylvester Bauer <marcello.bauer@9elements.com>;
> > patrick.rudolph@9elements.com; Ma, Maurice <maurice.ma@intel.com>; Dong,
> > Guo <guo.dong@intel.com>; You, Benjamin <benjamin.you@intel.com>
> > Subject: [PATCH v2 0/1] UefiPayloadPkg: Set default PciBaseSize on Ia32
> >
> > This commit fix UefiPayloadPkgIa32 build in master.
> >
> > In commit 8028b2907e20b21cd7d69639a36ac82a77c81dc1 I did forget to set
> > the default value for PcdPciExpressBaseSize on Ia32 Targets. This patch
> does
> > insert it afterwards. It would be great if it could be merged asap.
> >
> > PS: I added the Ia32 target to our CI to avoid this issue in future.
> Sorry for the
> > misfortune.
> >
> > v2:
> >   * Remove no longer required build-time PcdPciExpressBaseAddress
> >
> > Branch: https://github.com/9elements/edk2/tree/fix/UefiPayloadPkgIa32_V2
> > PR:     https://github.com/tianocore/edk2/pull/1008
> >
> > Marcello Sylvester Bauer (1):
> >   UefiPayloadPkg: Set default PciBaseSize on Ia32
> >
> >  UefiPayloadPkg/UefiPayloadPkgIa32.dsc | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > --
> > 2.28.0
>
>
>
>
> --
>
> *[Marcello Sylvester Bauer]*
>
>
>
> 9elements Agency GmbH, Kortumstraße 19-21, 44787 Bochum, Germany
>
> Email:  [DEINE EMAIL ADDRESSE]
> <https://static.9elements.com/email_signatur.html>
>
> Phone:  *+49 234 68 94 188 <+492346894188>*
>
> Mobile:  *+49 1722847618 <+491722847618>*
>
>
>
> Sitz der Gesellschaft: Bochum
>
> Handelsregister: Amtsgericht Bochum, HRB 17519
>
> Geschäftsführung: Sebastian Deutsch, Eray Basar
>
>
> Datenschutzhinweise nach Art. 13 DSGVO <https://9elements.com/privacy>
>
> 
>


-- 
*[Marcello Sylvester Bauer]*



9elements Agency GmbH, Kortumstraße 19-21, 44787 Bochum, Germany
Email:  [DEINE EMAIL ADDRESSE]
<https://static.9elements.com/email_signatur.html>
Phone:  *+49 234 68 94 188 <+492346894188>*
Mobile:  *+49 1722847618 <+491722847618>*

Sitz der Gesellschaft: Bochum
Handelsregister: Amtsgericht Bochum, HRB 17519
Geschäftsführung: Sebastian Deutsch, Eray Basar

Datenschutzhinweise nach Art. 13 DSGVO <https://9elements.com/privacy>

[-- Attachment #2: Type: text/html, Size: 14812 bytes --]