Re: [edk2-devel] [edk2-platforms][PATCH V1 1/5] Platform/ARM/Morello: Add Platform library implementation

[chandni.cherukuri@arm.com]

Hi Thomas,

Please find my response marked inline below.

On Sat, Feb 27, 2021 at 12:06 AM Thomas Abraham <thomas.abraham@arm.com> wrote:
>
> On 2/24/21 6:42 PM, Chandni Cherukuri via groups.io wrote:
> > From: Anurag Koul <anurag.koul@arm.com>
> >
> > This patch adds initial Morello Platform Library support.
> > It includes virtual memory map and helper functions for
> > platform initialization.
> >
> > Co-authored-by: Chandni Cherukuri <chandni.cherukuri@arm.com>
> > Signed-off-by: Chandni Cherukuri <chandni.cherukuri@arm.com>
> > ---
> >  Platform/ARM/Morello/Library/PlatformLib/PlatformLib.inf  |  52 ++++++
> >  Platform/ARM/Morello/Include/MorelloPlatform.h            |  67 +++++++
> >  Platform/ARM/Morello/Library/PlatformLib/PlatformLib.c    |  66 +++++++
> >  Platform/ARM/Morello/Library/PlatformLib/PlatformLibMem.c | 194
> > ++++++++++++++++++++
> >  Platform/ARM/Morello/Library/PlatformLib/AArch64/Helper.S |  83 +++++++++
> >  5 files changed, 462 insertions(+)
>
> With the platform resources being very similar to that of N1SDP SoC (Silicon/ARM/NeoverseN1Soc), are there opportunities to reuse the NeoverseN1Soc code to build the Morello platform support ?
>
> - Thomas
>
> [...]
>
>
Even though some of the platform resources are similar there are few
IPs which are different between the two and one of them is the CPU
being used.
Morello platform is based on Rainier CPU whereas I assume
Silicon/ARM/NeoverseN1Soc is for platforms which are based on
NeoverseN1 CPU. Also there is going to be support for both Morello FVP
and Morello Silicon platform in the future.

Considering these differences I think it would be best to maintain
Morello as a separate platform.

- Chandni
> 
>
>