On Tue, Feb 27, 2024 at 8:42 PM Sunil V L <sunilvl@ventanamicro.com> wrote:

Hi Tuan,

On Mon, Feb 26, 2024 at 08:34:22PM -0800, Tuan Phan wrote:
> Hi Sunil/ Andrei,
> Any comments on this series?
>
Did I miss your response to Laszlo's feedback on PATCH 2 - [1]? Apart
from that, don't we need to handle EFI_MEMORY_WT similar to
EFI_MEMORY_WC?

Somehow I missed that feedback. Thanks.

About EFI_MEMORY_WT, ARM treats it as EFI_MEMORY_WC under hood but I don't see RISC-V specs mentions it explicitly so don't feel confident to add that.

[1] - https://edk2.groups.io/g/devel/message/115243

Thanks,
Sunil
> Regards,
>
> On Wed, Feb 14, 2024 at 10:16 PM Tuan Phan via groups.io <tphan=
> ventanamicro.com@groups.io> wrote:
>
> >
> >
> > On Wed, Feb 14, 2024 at 9:43 PM Warkentin, Andrei <
> > andrei.warkentin@intel.com> wrote:
> >
> >> Do you mind sharing a GH branch with the patch set?
> >>
> > https://github.com/pttuan/edk2/tree/tphan/riscv_mmu_svpbmt
> > Tuan
> >
> >>
> >> A
> >>
> >> > -----Original Message-----
> >> > From: Tuan Phan <tphan@ventanamicro.com>
> >> > Sent: Tuesday, February 6, 2024 7:29 PM
> >> > To: devel@edk2.groups.io
> >> > Cc: Kinney, Michael D <michael.d.kinney@intel.com>;
> >> > gaoliming@byosoft.com.cn; Liu, Zhiguang <zhiguang.liu@intel.com>;
> >> > kraxel@redhat.com; lersek@redhat.com; Kumar, Rahul R
> >> > <rahul.r.kumar@intel.com>; Ni, Ray <ray.ni@intel.com>;
> >> > sunilvl@ventanamicro.com; Yao, Jiewen <jiewen.yao@intel.com>;
> >> Warkentin,
> >> > Andrei <andrei.warkentin@intel.com>; ardb+tianocore@kernel.org; Tuan
> >> Phan
> >> > <tphan@ventanamicro.com>
> >> > Subject: [PATCH v2 0/3] RISC-V: Support Svpbmt extension
> >> >
> >> > This patchset adds support for RISC-V Svpbmt extension.
> >> >
> >> > The GCD EFI_MEMORY_UC and EFI_MEMORY_WC attributes will be mapped to
> >> > IO and NC mode defined in PBMT field.
> >> >
> >> > v2:
> >> > - Generated patch for each package.
> >> >
> >> > Tuan Phan (3):
> >> > MdePkg.dec: RISC-V: Define override bit for Svpbmt extension
> >> > UefiCpuPkg: RISC-V: MMU: Support Svpbmt extension
> >> > OvmfPkg/RiscVVirt: Override Svpbmt extension
> >> >
> >> > MdePkg/MdePkg.dec | 2 ++
> >> > OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc | 2 +-
> >> > .../Library/BaseRiscVMmuLib/BaseRiscVMmuLib.c | 25 ++++++++++++++++++-
> >> > .../BaseRiscVMmuLib/BaseRiscVMmuLib.inf | 1 +
> >> > 4 files changed, 28 insertions(+), 2 deletions(-)
> >> >
> >> > --
> >> > 2.25.1
> >> > >
> >