From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 0CB8C740059 for ; Fri, 8 Sep 2023 16:01:08 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=JPaMCBDRwSMWAlI8xNSlK8SEmDSmxjcsueDRgQ0Q6qg=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1694188866; v=1; b=UcKlV9qin1KyUpU1Cz7U4xFtjgBcWTrDbVrwPxFHnJcs82g5C/WzLInMdy1XlEmlrkz3NVlb LY4DbqG6qsTL9bpc5dZ1oE92mBHneddoojj3rmgd3EgvJaKiBgDgpmnD5RAMSNwTkNRELJLuy40 EPs/ROa6MMPBTCNPjM8i+iV8= X-Received: by 127.0.0.2 with SMTP id YeFbYY7687511xkARmfriOTE; Fri, 08 Sep 2023 09:01:06 -0700 X-Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) by mx.groups.io with SMTP id smtpd.web11.534.1694188865895092151 for ; Fri, 08 Sep 2023 09:01:06 -0700 X-Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-98377c5d53eso273179566b.0 for ; Fri, 08 Sep 2023 09:01:05 -0700 (PDT) X-Gm-Message-State: iuOZi9oSvDC0L4l9t5PWwN8Mx7686176AA= X-Google-Smtp-Source: AGHT+IEZoCV/j22YYonQn40YENQ0aHbPL+cbmIgCk2phVh6mEvnNM25UXAIVZmiTyg6Ze62+WPy8WUgfo9TqZsL6x3w= X-Received: by 2002:a17:907:77c2:b0:9a2:2842:f1c6 with SMTP id kz2-20020a17090777c200b009a22842f1c6mr2133474ejc.28.1694188863953; Fri, 08 Sep 2023 09:01:03 -0700 (PDT) MIME-Version: 1.0 References: <20230907045914.29608-1-tphan@ventanamicro.com> In-Reply-To: From: "Tuan Phan" Date: Fri, 8 Sep 2023 09:00:52 -0700 Message-ID: Subject: Re: [edk2-devel] [PATCH] StandaloneMmPkg: Make StandaloneMmCpu driver platform independent To: Yeo Reum Yun Cc: "devel@edk2.groups.io" , Sami Mujawar , "ardb+tianocore@kernel.org" , "ray.ni@intel.com" , "huangming@linux.alibaba.com" , "sunilvl@ventanamicro.com" , "yong.li@intel.com" , nd Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,tphan@ventanamicro.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: multipart/alternative; boundary="0000000000006b341b0604db15d4" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=UcKlV9qi; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --0000000000006b341b0604db15d4 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Sep 8, 2023 at 12:12=E2=80=AFAM Yeo Reum Yun = wrote: > > Signed-off-by: Tuan Phan > > --- > > .../Drivers/StandaloneMmCpu/EventHandle.c | 25 +++-------- > > .../Drivers/StandaloneMmCpu/StandaloneMmCpu.c | 42 +++++++++--------- > > .../StandaloneMmCpu/StandaloneMmCpu.inf | 9 ++-- > > .../Library/Arm/StandaloneMmCoreEntryPoint.h | 17 ++------ > > .../StandaloneMmCpu.h | 22 +++++++--- > > .../Arm/CreateHobList.c | 43 ++++++++++--------- > > .../Arm/StandaloneMmCoreEntryPoint.c | 15 ++++++- > > .../StandaloneMmCoreEntryPoint.inf | 2 +- > > StandaloneMmPkg/StandaloneMmPkg.dec | 2 +- > > 9 files changed, 86 insertions(+), 91 deletions(-) > > rename StandaloneMmPkg/{Drivers/StandaloneMmCpu =3D> > Include}/StandaloneMmCpu.h (82%) > > > @Sami, This patch looks good to me :) > BTW, I think it's much better to split this patch to platform independent > part and ARM specific part. > Many thanks. > Sure, will seperate it to 2 parts in the next version. > IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended > recipient, please notify the sender immediately and do not disclose the > contents to any other person, use it for any purpose, or store or copy th= e > information in any medium. Thank you. > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108452): https://edk2.groups.io/g/devel/message/108452 Mute This Topic: https://groups.io/mt/101209230/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --0000000000006b341b0604db15d4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Fri, Sep 8, 2023 at 12:12=E2=80=AF= AM Yeo Reum Yun <YeoReum.Yun@arm.= com> wrote:
> Signed-off-by: Tuan Phan = <tphan@venta= namicro.com>
> ---
>=C2=A0 .../Drivers/StandaloneMmCpu/EventHandle.c=C2=A0 =C2=A0 =C2=A0| 2= 5 +++--------
> .../Drivers/StandaloneMmCpu/StandaloneMmCpu.c | 42 +++++++++---------<= br> > .../StandaloneMmCpu/StandaloneMmCpu.inf=C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2= =A0 9 ++--
> .../Library/Arm/StandaloneMmCoreEntryPoint.h=C2=A0 | 17 ++------
> .../StandaloneMmCpu.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| 22 +++++++---
> .../Arm/CreateHobList.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| 43 ++++++++++---------
> .../Arm/StandaloneMmCoreEntryPoint.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= | 15 ++++++-
> .../StandaloneMmCoreEntryPoint.inf=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 |=C2=A0 2 +-
> StandaloneMmPkg/StandaloneMmPkg.dec=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0|=C2=A0 2 +-
> 9 files changed, 86 insertions(+), 91 deletions(-)
> rename StandaloneMmPkg/{Drivers/StandaloneMmCpu =3D> Include}/Stand= aloneMmCpu.h (82%)


@Sami,=C2=A0 This patch looks good to me :)=C2=A0

BTW, I think it's much better to split this patch to platform independe= nt part and ARM specific part.
Many thanks.
Sure, will seperate it to 2 parts in the = next version.=C2=A0
IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#108452) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--0000000000006b341b0604db15d4--