Re: [edk2-devel] [PATCH v2 3/3] OvmfPkg/RiscVVirt: Override Svpbmt extension

["Tuan Phan" <tphan@ventanamicro.com>]

[-- Attachment #1: Type: text/plain, Size: 1848 bytes --]

On Wed, Feb 7, 2024 at 12:02 PM Laszlo Ersek <lersek@redhat.com> wrote:

> On 2/7/24 02:29, Tuan Phan wrote:
> > Override Svpbmt extension that be disabled by default.
> >
> > Signed-off-by: Tuan Phan <tphan@ventanamicro.com>
> > ---
> >  OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc
> b/OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc
> > index 6bc7c90f31dc..b8338d2eb5f5 100644
> > --- a/OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc
> > +++ b/OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc
> > @@ -203,7 +203,7 @@
> >    gEfiMdeModulePkgTokenSpaceGuid.PcdInstallAcpiSdtProtocol|TRUE
> >
> >  [PcdsFixedAtBuild.common]
> > -  gEfiMdePkgTokenSpaceGuid.PcdRiscVFeatureOverride|0xFFFFFFFFFFFFFFFC
> > +  gEfiMdePkgTokenSpaceGuid.PcdRiscVFeatureOverride|0xFFFFFFFFFFFFFFF8
> >    gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength|1000000
> >    gEfiMdePkgTokenSpaceGuid.PcdMaximumAsciiStringLength|1000000
> >    gEfiMdePkgTokenSpaceGuid.PcdMaximumLinkedListLength|0
>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>
> (Meaning that, IMO, the patch does what it says on the tin. *Why* the
> disablement is justified / necessary, I can't say, neither does the
> commit message. It's probably that QEMU/KVM don't implement Svpbmt.)
>
> Thanks for reviewing. QEMU doesn't enable Svpbmt by default. Will add to
the message in
next version.

Laszlo
>
>
>
> 
>
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115248): https://edk2.groups.io/g/devel/message/115248
Mute This Topic: https://groups.io/mt/104211196/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 3103 bytes --]