From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 91B48740038 for ; Wed, 7 Feb 2024 20:08:25 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=8RYVRugt5zVZUx7bocjDia3Jw2yOKi+V3m60alaU3Yo=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1707336504; v=1; b=wCn94yjMyM+ytJLW31pVu5hgSt+Wey/MLEDy+ZYPofcEnJQzK05IZ18+NTWsxbhEvIZQgkfV aa/sImeTIaBODHhlSVNXJXXc1VY6km1oDVkXSdzPuGWydCbiCmMiog6MXgrcQKqj7H7UUXHiK/1 76VSPNNDox1b4XLKNPosngFw= X-Received: by 127.0.0.2 with SMTP id bOWFYY7687511xcNAd81jdYx; Wed, 07 Feb 2024 12:08:24 -0800 X-Received: from mail-ua1-f42.google.com (mail-ua1-f42.google.com [209.85.222.42]) by mx.groups.io with SMTP id smtpd.web11.8473.1707336503690223612 for ; Wed, 07 Feb 2024 12:08:23 -0800 X-Received: by mail-ua1-f42.google.com with SMTP id a1e0cc1a2514c-7d6275d7d4dso438620241.2 for ; Wed, 07 Feb 2024 12:08:23 -0800 (PST) X-Gm-Message-State: l4iAVhgyFnXzjvMVP16dbtIUx7686176AA= X-Google-Smtp-Source: AGHT+IHz51RQOdKvqG1Dfp1r+GMhw/Ufak06lDI7OTSzDiXzlkzuGgaRZbmClAKDS0cqipSE1dKk1iZqw5RGFo/nknQ= X-Received: by 2002:a05:6122:907:b0:4c0:2747:acce with SMTP id j7-20020a056122090700b004c02747accemr4005583vka.9.1707336502504; Wed, 07 Feb 2024 12:08:22 -0800 (PST) MIME-Version: 1.0 References: <20240207012910.2133-1-tphan@ventanamicro.com> <20240207012910.2133-4-tphan@ventanamicro.com> <4c3eab2b-c7e9-21cd-3bfc-47c7d0e6de6a@redhat.com> In-Reply-To: <4c3eab2b-c7e9-21cd-3bfc-47c7d0e6de6a@redhat.com> From: "Tuan Phan" Date: Wed, 7 Feb 2024 12:08:11 -0800 Message-ID: Subject: Re: [edk2-devel] [PATCH v2 3/3] OvmfPkg/RiscVVirt: Override Svpbmt extension To: devel@edk2.groups.io, lersek@redhat.com Cc: michael.d.kinney@intel.com, gaoliming@byosoft.com.cn, zhiguang.liu@intel.com, kraxel@redhat.com, rahul1.kumar@intel.com, ray.ni@intel.com, sunilvl@ventanamicro.com, jiewen.yao@intel.com, andrei.warkentin@intel.com, ardb+tianocore@kernel.org Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,tphan@ventanamicro.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: multipart/alternative; boundary="000000000000be8d610610d0414c" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=wCn94yjM; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --000000000000be8d610610d0414c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Feb 7, 2024 at 12:02=E2=80=AFPM Laszlo Ersek wr= ote: > On 2/7/24 02:29, Tuan Phan wrote: > > Override Svpbmt extension that be disabled by default. > > > > Signed-off-by: Tuan Phan > > --- > > OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc > b/OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc > > index 6bc7c90f31dc..b8338d2eb5f5 100644 > > --- a/OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc > > +++ b/OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc > > @@ -203,7 +203,7 @@ > > gEfiMdeModulePkgTokenSpaceGuid.PcdInstallAcpiSdtProtocol|TRUE > > > > [PcdsFixedAtBuild.common] > > - gEfiMdePkgTokenSpaceGuid.PcdRiscVFeatureOverride|0xFFFFFFFFFFFFFFFC > > + gEfiMdePkgTokenSpaceGuid.PcdRiscVFeatureOverride|0xFFFFFFFFFFFFFFF8 > > gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength|1000000 > > gEfiMdePkgTokenSpaceGuid.PcdMaximumAsciiStringLength|1000000 > > gEfiMdePkgTokenSpaceGuid.PcdMaximumLinkedListLength|0 > > Reviewed-by: Laszlo Ersek > > (Meaning that, IMO, the patch does what it says on the tin. *Why* the > disablement is justified / necessary, I can't say, neither does the > commit message. It's probably that QEMU/KVM don't implement Svpbmt.) > > Thanks for reviewing. QEMU doesn't enable Svpbmt by default. Will add to the message in next version. Laszlo > > > >=20 > > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115248): https://edk2.groups.io/g/devel/message/115248 Mute This Topic: https://groups.io/mt/104211196/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --000000000000be8d610610d0414c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Wed, Feb 7, 2024 at 12:02=E2=80=AF= PM Laszlo Ersek <lersek@redhat.com<= /a>> wrote:
On 2/7/24 02:29, Tuan Phan wrote:<= br> > Override Svpbmt extension that be disabled by default.
>
> Signed-off-by: Tuan Phan <tphan@ventanamicro.com>
> ---
>=C2=A0 OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc | 2 +-
>=C2=A0 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc b/OvmfPkg/RiscVVirt/R= iscVVirt.dsc.inc
> index 6bc7c90f31dc..b8338d2eb5f5 100644
> --- a/OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc
> +++ b/OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc
> @@ -203,7 +203,7 @@
>=C2=A0 =C2=A0 gEfiMdeModulePkgTokenSpaceGuid.PcdInstallAcpiSdtProtocol|= TRUE
>=C2=A0
>=C2=A0 [PcdsFixedAtBuild.common]
> -=C2=A0 gEfiMdePkgTokenSpaceGuid.PcdRiscVFeatureOverride|0xFFFFFFFFFFF= FFFFC
> +=C2=A0 gEfiMdePkgTokenSpaceGuid.PcdRiscVFeatureOverride|0xFFFFFFFFFFF= FFFF8
>=C2=A0 =C2=A0 gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength|10= 00000
>=C2=A0 =C2=A0 gEfiMdePkgTokenSpaceGuid.PcdMaximumAsciiStringLength|1000= 000
>=C2=A0 =C2=A0 gEfiMdePkgTokenSpaceGuid.PcdMaximumLinkedListLength|0

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

(Meaning that, IMO, the patch does what it says on the tin. *Why* the
disablement is justified / necessary, I can't say, neither does the
commit message. It's probably that QEMU/KVM don't implement Svpbmt.= )

Thanks for reviewing. QEMU doesn't enable Svpbmt = by default. Will add to the message in
next version.
Laszlo






_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#115248) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--000000000000be8d610610d0414c--