From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.103599.1679669159592583902 for ; Fri, 24 Mar 2023 07:46:00 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ccDPl+pw; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: ppolawsk@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679669158; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=O+v8l1NzBSk5bohcm+9/3rCL31diRFRkMTeyY91BVEc=; b=ccDPl+pws4iWskuaJCcynLo/Eviumg3mcB3dvs/02H1gP+rMLwODZAZ+640xcsrrtlTV/M AMdV/s7R3ZtBXIzu219cU1pJNVKAExoIlqxXs6Se0z9lR94n/wdZ76K5FsiVSfGKm+tS26 e5m/Wlga7xSe0ZtV/vmxVPm6Oh4qKeQ= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-413-hOP3nbMUOLyO7J7Au358sw-1; Fri, 24 Mar 2023 10:45:57 -0400 X-MC-Unique: hOP3nbMUOLyO7J7Au358sw-1 Received: by mail-vs1-f70.google.com with SMTP id t22-20020a67d916000000b00425d954c65fso533544vsj.21 for ; Fri, 24 Mar 2023 07:45:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679669157; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=O+v8l1NzBSk5bohcm+9/3rCL31diRFRkMTeyY91BVEc=; b=JrpG9wEd3/LZmJ6Tj2FOkVh+RoCBZbI33Y6t87/OtlLH2miAhAYaqxjRMnVnr+m/HV zBE/511uiBXZEvoWwxIxXh7yi/jPtRcll0VFidmO46/Wpb5Ejjhj5PXKsxzMMgZWwbbe luQWF9J1+q22QKeYGmOWKvA2jvIq0A/SfZyR3pU8ZHTwQMOOfXeI5/qfCoxEzVJhDXBC Ot3Bw6O8hutn6O8MXwBm/LdgBpnqZBhN5HzkqVRrlHc4WFcUT33Qh4em7cOzgfSUyDeJ XXGTAu5MjtUp11g59oHvFYFEKAYucCyQldKmnP50kOpSmkDyp1kdMZzwDodH1tP+omBd vFJA== X-Gm-Message-State: AAQBX9fBfB/jM05PDg1pPXP4PPi/Drp78xDuRCb8OA2bicJ7BUliRtjd KAnra3LLO0USWBHfoHeIIHIkwK4Y7J+76DSQUZSPTZ6MXfMCZ9VgVbGB0fEuoKLggfEjavR/HkG UoQk5370cjv+Zy9qljoCiBHvajUv5xA== X-Received: by 2002:a1f:9058:0:b0:439:cef1:27e4 with SMTP id s85-20020a1f9058000000b00439cef127e4mr1828765vkd.3.1679669156676; Fri, 24 Mar 2023 07:45:56 -0700 (PDT) X-Google-Smtp-Source: AKy350YwjLK5rmY9SIAwPcvCINbpZFQEzr8AwQF1nHEK4DOhNp8oimXANo7Q2SXrrplFUSumbruwBrcRO7b0mbq6wgQ= X-Received: by 2002:a1f:9058:0:b0:439:cef1:27e4 with SMTP id s85-20020a1f9058000000b00439cef127e4mr1828754vkd.3.1679669156339; Fri, 24 Mar 2023 07:45:56 -0700 (PDT) MIME-Version: 1.0 References: <8188524e0c39ae11baf681e3ad375e4c3c284569.1669908382.git.ppolawsk@redhat.com> In-Reply-To: From: =?UTF-8?B?UGF3ZcWCIFBvxYJhd3NraQ==?= Date: Fri, 24 Mar 2023 15:45:44 +0100 Message-ID: Subject: Re: [edk2-devel] PATCH v1 1/1 MdePkg: Remove Itanium leftover data structure To: "Kinney, Michael D" Cc: "devel@edk2.groups.io" , "Gao, Liming" , "Liu, Zhiguang" , "Zimmer, Vincent" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="00000000000067772405f7a673ce" --00000000000067772405f7a673ce Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Michael, Sorry for the delay in my response. I just opened PR against EDK2 repo to trigger CI: https://github.com/tianocore/edk2/pull/4174 Best regards, Pawel On Thu, Mar 23, 2023 at 11:10=E2=80=AFPM Kinney, Michael D < michael.d.kinney@intel.com> wrote: > Hi Pawel, > > Any updates on this task? > > I would like to see this go in soon so it can get some flight time before > next stable tag. > > Mike > > > -----Original Message----- > > From: Kinney, Michael D > > Sent: Tuesday, March 7, 2023 2:25 PM > > To: Pawe=C5=82 Po=C5=82awski ; devel@edk2.groups.i= o > > Cc: Gao, Liming ; Liu, Zhiguang < > zhiguang.liu@intel.com>; Zimmer, Vincent ; > > Kinney, Michael D > > Subject: RE: [edk2-devel] PATCH v1 1/1 MdePkg: Remove Itanium leftover > data structure > > > > Hi Pawel, > > > > Can you please also reference the following BZ and commit in the commit > message > > > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1560 > > > https://github.com/tianocore/edk2/commit/4e1daa60f5372c22a11503961061ffa5= 69eaf873 > > > > If you post a branch with these small updates and my Rb and send it > > through EDK II CI, I can do the push from there. > > > > Thanks, > > > > Mike > > > > > -----Original Message----- > > > From: Kinney, Michael D > > > Sent: Tuesday, March 7, 2023 1:59 PM > > > To: Pawe=C5=82 Po=C5=82awski ; devel@edk2.groups= .io > > > Cc: Gao, Liming ; Liu, Zhiguang < > zhiguang.liu@intel.com>; Zimmer, Vincent > > > ; Kinney, Michael D < > michael.d.kinney@intel.com> > > > Subject: RE: [edk2-devel] PATCH v1 1/1 MdePkg: Remove Itanium leftove= r > data structure > > > > > > Hi Pawel, > > > > > > With suggestion from Vincent, let's remove ItaniumHealthFlags. > > > > > > https://edk2.groups.io/g/devel/message/100812 > > > > > > I recommend adding a note in the comment block for the > > > EFI_SEC_PLATFORM_INFORMATION_RECORD that with the removal of the > > > ItaniumHealthFlags, this union has diverged from the PI > > > Specification definition. > > > > > > With that one comment addition: > > > > > > Reviewed-by: Michael D Kinney > > > > > > Mike > > > > > > > > > > -----Original Message----- > > > > From: Pawe=C5=82 Po=C5=82awski > > > > Sent: Thursday, December 1, 2022 7:36 AM > > > > To: devel@edk2.groups.io > > > > Cc: Kinney, Michael D ; Gao, Liming < > gaoliming@byosoft.com.cn>; Liu, Zhiguang > > > > > > > > Subject: [edk2-devel] PATCH v1 1/1 MdePkg: Remove Itanium leftover > data structure > > > > > > > > Itanium support has been removed from EDK2 aroun 2019. > > > > ITANIUM_HANDOFF_STATUS data structure looks to be > > > > some leftover from that process. > > > > > > > > There is also positive sidefect of this data structure removal. > > > > Due to HOB allocation type used in PEI stage there is a limit > > > > how much data about virtual CPU can be hold. This limit result > > > > in only 1024 vCPU can be used by VM. > > > > With Itanium related data structure removed more allocated space > > > > can be used for vCPU data and with current allocation limit > > > > will change from 1024 to around 8k vCPUs. > > > > > > > > Cc: Michael D Kinney > > > > Cc: Liming Gao > > > > Cc: Zhiguang Liu > > > > > > > > Signed-off-by: Pawe=C5=82 Po=C5=82awski > > > > --- > > > > MdePkg/Include/Ppi/SecPlatformInformation.h | 44 > -------------------- > > > > 1 file changed, 44 deletions(-) > > > > > > > > diff --git a/MdePkg/Include/Ppi/SecPlatformInformation.h > b/MdePkg/Include/Ppi/SecPlatformInformation.h > > > > index 02b0711f189e..fbcd205acd96 100644 > > > > --- a/MdePkg/Include/Ppi/SecPlatformInformation.h > > > > +++ b/MdePkg/Include/Ppi/SecPlatformInformation.h > > > > @@ -84,49 +84,6 @@ typedef union { > > > > > > > > typedef EFI_HEALTH_FLAGS X64_HANDOFF_STATUS; > > > > typedef EFI_HEALTH_FLAGS IA32_HANDOFF_STATUS; > > > > -/// > > > > -/// The hand-off status structure for Itanium architecture. > > > > -/// > > > > -typedef struct { > > > > - /// > > > > - /// SALE_ENTRY state : 3 =3D Recovery_Check > > > > - /// and 0 =3D RESET or Normal_Boot phase. > > > > - /// > > > > - UINT8 BootPhase; > > > > - /// > > > > - /// Firmware status on entry to SALE. > > > > - /// > > > > - UINT8 FWStatus; > > > > - UINT16 Reserved1; > > > > - UINT32 Reserved2; > > > > - /// > > > > - /// Geographically significant unique processor ID assigned by > PAL. > > > > - /// > > > > - UINT16 ProcId; > > > > - UINT16 Reserved3; > > > > - UINT8 IdMask; > > > > - UINT8 EidMask; > > > > - UINT16 Reserved4; > > > > - /// > > > > - /// Address to make PAL calls. > > > > - /// > > > > - UINT64 PalCallAddress; > > > > - /// > > > > - /// If the entry state is RECOVERY_CHECK, this contains the > PAL_RESET > > > > - /// return address, and if entry state is RESET, this contains > > > > - /// address for PAL_authentication call. > > > > - /// > > > > - UINT64 PalSpecialAddress; > > > > - /// > > > > - /// GR35 from PALE_EXIT state. > > > > - /// > > > > - UINT64 SelfTestStatus; > > > > - /// > > > > - /// GR37 from PALE_EXIT state. > > > > - /// > > > > - UINT64 SelfTestControl; > > > > - UINT64 MemoryBufferRequired; > > > > -} ITANIUM_HANDOFF_STATUS; > > > > > > > > /// > > > > /// EFI_SEC_PLATFORM_INFORMATION_RECORD. > > > > @@ -134,7 +91,6 @@ typedef struct { > > > > typedef union { > > > > IA32_HANDOFF_STATUS IA32HealthFlags; > > > > X64_HANDOFF_STATUS x64HealthFlags; > > > > - ITANIUM_HANDOFF_STATUS ItaniumHealthFlags; > > > > } EFI_SEC_PLATFORM_INFORMATION_RECORD; > > > > > > > > /** > > > > -- > > > > 2.38.1 > > --=20 Pawe=C5=82 Po=C5=82awski Red Hat Virtualization ppolawsk@redhat.com @RedHat Red Hat Red Hat --00000000000067772405f7a673ce Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Michael,

Sorry for the de= lay in my response. I just opened PR against EDK2 repo to trigger CI:
=

Best regards,
Pawel

On Thu, Mar 23, 2023 at 11:10=E2=80=AFPM Kinney, Mic= hael D <michael.d.kinney@i= ntel.com> wrote:
Hi Pawel,

Any updates on this task?

I would like to see this go in soon so it can get some flight time before n= ext stable tag.

Mike

> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Tuesday, March 7, 2023 2:25 PM
> To: Pawe=C5=82 Po=C5=82awski <ppolawsk@redhat.com>; devel@edk2.groups.io
> Cc: Gao, Liming <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com= >; Zimmer, Vincent <vincent.zimmer@intel.com>;
> Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: RE: [edk2-devel] PATCH v1 1/1 MdePkg: Remove Itanium leftover= data structure
>
> Hi Pawel,
>
> Can you please also reference the following BZ and commit in the commi= t message
>
> https://bugzilla.tianocore.org/show_bug.c= gi?id=3D1560
> https://github= .com/tianocore/edk2/commit/4e1daa60f5372c22a11503961061ffa569eaf873
>
> If you post a branch with these small updates and my Rb and send it > through EDK II CI, I can do the push from there.
>
> Thanks,
>
> Mike
>
> > -----Original Message-----
> > From: Kinney, Michael D <michael.d.kinney@intel.com>
> > Sent: Tuesday, March 7, 2023 1:59 PM
> > To: Pawe=C5=82 Po=C5=82awski <ppolawsk@redhat.com>; devel@edk2.groups.io
> > Cc: Gao, Liming <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.co= m>; Zimmer, Vincent
> > <vincent.zimmer@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>
> > Subject: RE: [edk2-devel] PATCH v1 1/1 MdePkg: Remove Itanium lef= tover data structure
> >
> > Hi Pawel,
> >
> > With suggestion from Vincent, let's remove ItaniumHealthFlags= .
> >
> > https://edk2.groups.io/g/devel/message/100812=
> >
> > I recommend adding a note in the comment block for the
> > EFI_SEC_PLATFORM_INFORMATION_RECORD that with the removal of the<= br> > > ItaniumHealthFlags, this union has diverged from the PI
> > Specification definition.
> >
> > With that one comment addition:
> >
> > Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> >
> > Mike
> >
> >
> > > -----Original Message-----
> > > From: Pawe=C5=82 Po=C5=82awski <ppolawsk@redhat.com>
> > > Sent: Thursday, December 1, 2022 7:36 AM
> > > To: devel@edk2.groups.io
> > > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Limi= ng <gaolim= ing@byosoft.com.cn>; Liu, Zhiguang
> > > <zhiguang.liu@intel.com>
> > > Subject: [edk2-devel] PATCH v1 1/1 MdePkg: Remove Itanium le= ftover data structure
> > >
> > > Itanium support has been removed from EDK2 aroun 2019.
> > > ITANIUM_HANDOFF_STATUS data structure looks to be
> > > some leftover from that process.
> > >
> > > There is also positive sidefect of this data structure remov= al.
> > > Due to HOB allocation type used in PEI stage there is a limi= t
> > > how much data about virtual CPU can be hold. This limit resu= lt
> > > in only 1024 vCPU can be used by VM.
> > > With Itanium related data structure removed more allocated s= pace
> > > can be used for vCPU data and with current allocation limit<= br> > > > will change from 1024 to around 8k vCPUs.
> > >
> > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> > >
> > > Signed-off-by: Pawe=C5=82 Po=C5=82awski <ppolawsk@redhat.com>
> > > ---
> > >=C2=A0 MdePkg/Include/Ppi/SecPlatformInformation.h | 44 -----= ---------------
> > >=C2=A0 1 file changed, 44 deletions(-)
> > >
> > > diff --git a/MdePkg/Include/Ppi/SecPlatformInformation.h b/M= dePkg/Include/Ppi/SecPlatformInformation.h
> > > index 02b0711f189e..fbcd205acd96 100644
> > > --- a/MdePkg/Include/Ppi/SecPlatformInformation.h
> > > +++ b/MdePkg/Include/Ppi/SecPlatformInformation.h
> > > @@ -84,49 +84,6 @@ typedef union {
> > >
> > >=C2=A0 typedef EFI_HEALTH_FLAGS X64_HANDOFF_STATUS;
> > >=C2=A0 typedef EFI_HEALTH_FLAGS IA32_HANDOFF_STATUS;
> > > -///
> > > -/// The hand-off status structure for Itanium architecture.=
> > > -///
> > > -typedef struct {
> > > -=C2=A0 ///
> > > -=C2=A0 /// SALE_ENTRY state : 3 =3D Recovery_Check
> > > -=C2=A0 /// and 0 =3D RESET or Normal_Boot phase.
> > > -=C2=A0 ///
> > > -=C2=A0 UINT8=C2=A0 =C2=A0 =C2=A0BootPhase;
> > > -=C2=A0 ///
> > > -=C2=A0 /// Firmware status on entry to SALE.
> > > -=C2=A0 ///
> > > -=C2=A0 UINT8=C2=A0 =C2=A0 =C2=A0FWStatus;
> > > -=C2=A0 UINT16=C2=A0 =C2=A0 Reserved1;
> > > -=C2=A0 UINT32=C2=A0 =C2=A0 Reserved2;
> > > -=C2=A0 ///
> > > -=C2=A0 /// Geographically significant unique processor ID a= ssigned by PAL.
> > > -=C2=A0 ///
> > > -=C2=A0 UINT16=C2=A0 =C2=A0 ProcId;
> > > -=C2=A0 UINT16=C2=A0 =C2=A0 Reserved3;
> > > -=C2=A0 UINT8=C2=A0 =C2=A0 =C2=A0IdMask;
> > > -=C2=A0 UINT8=C2=A0 =C2=A0 =C2=A0EidMask;
> > > -=C2=A0 UINT16=C2=A0 =C2=A0 Reserved4;
> > > -=C2=A0 ///
> > > -=C2=A0 /// Address to make PAL calls.
> > > -=C2=A0 ///
> > > -=C2=A0 UINT64=C2=A0 =C2=A0 PalCallAddress;
> > > -=C2=A0 ///
> > > -=C2=A0 /// If the entry state is RECOVERY_CHECK, this conta= ins the PAL_RESET
> > > -=C2=A0 /// return address, and if entry state is RESET, thi= s contains
> > > -=C2=A0 /// address for PAL_authentication call.
> > > -=C2=A0 ///
> > > -=C2=A0 UINT64=C2=A0 =C2=A0 PalSpecialAddress;
> > > -=C2=A0 ///
> > > -=C2=A0 /// GR35 from PALE_EXIT state.
> > > -=C2=A0 ///
> > > -=C2=A0 UINT64=C2=A0 =C2=A0 SelfTestStatus;
> > > -=C2=A0 ///
> > > -=C2=A0 /// GR37 from PALE_EXIT state.
> > > -=C2=A0 ///
> > > -=C2=A0 UINT64=C2=A0 =C2=A0 SelfTestControl;
> > > -=C2=A0 UINT64=C2=A0 =C2=A0 MemoryBufferRequired;
> > > -} ITANIUM_HANDOFF_STATUS;
> > >
> > >=C2=A0 ///
> > >=C2=A0 /// EFI_SEC_PLATFORM_INFORMATION_RECORD.
> > > @@ -134,7 +91,6 @@ typedef struct {
> > >=C2=A0 typedef union {
> > >=C2=A0 =C2=A0 IA32_HANDOFF_STATUS=C2=A0 =C2=A0 =C2=A0 =C2=A0I= A32HealthFlags;
> > >=C2=A0 =C2=A0 X64_HANDOFF_STATUS=C2=A0 =C2=A0 =C2=A0 =C2=A0 x= 64HealthFlags;
> > > -=C2=A0 ITANIUM_HANDOFF_STATUS=C2=A0 =C2=A0 ItaniumHealthFla= gs;
> > >=C2=A0 } EFI_SEC_PLATFORM_INFORMATION_RECORD;
> > >
> > >=C2=A0 /**
> > > --
> > > 2.38.1



--

<= span>Pawe=C5=82 Po=C5=82awski

Red Hat Virtualization

ppolawsk@= redhat.com=C2=A0 =C2=A0

@RedHat=C2=A0=C2=A0=C2=A0Red Hat=C2=A0=C2=A0Red Hat
=
--00000000000067772405f7a673ce--