From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.78435.1656978821166061147 for ; Mon, 04 Jul 2022 16:53:41 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=PvNRy2+D; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: ppolawsk@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656978820; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yRkjrmPlt0imz7RpYh9Sw8fhJQZgvKItoC7PzZb/5ec=; b=PvNRy2+DPFzWKwT2mT+iBS0HWr4gFslUDAaa+sHv0ST1tLobwZryQYctblFTjklwaN+V83 CnglqzyHn8zX7F4XE73jPTRLAvE76f499uA0zr30GW1LVMj3FywZrAN41xU6eDjISMHZ9/ sXMuxvutxAuGiQ+fgTAFzzSQfwhd+PE= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-223-NpOzxzstOOGSQy2YTlKaow-1; Mon, 04 Jul 2022 19:53:38 -0400 X-MC-Unique: NpOzxzstOOGSQy2YTlKaow-1 Received: by mail-ed1-f69.google.com with SMTP id v16-20020a056402349000b00435a1c942a9so8087698edc.15 for ; Mon, 04 Jul 2022 16:53:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yRkjrmPlt0imz7RpYh9Sw8fhJQZgvKItoC7PzZb/5ec=; b=cTdtKfqMKgggLIJduFNkAjhB2b9U8YmXiNyKKj7osPkN1tiPTEweayG0QDTPnB1pV0 WFybRwkV7EO1g5jPyh1eYydMhf/KQwuOCRpRSZhzNZb5h5oQ+sAK7OEjcOvtTh83mfqB 0df1+qq3oCTb7TtSvGvQ2JyrlPoJktHTPVtxzUNoC6EDimaD6OQahQfw/HH4BDq+YCgP NvtbimCxFxr0FUsD7HbBceIXxHlFMYa7aZT9GnU3Wi05LRbRaTpC3hL+gb2ZLPmYsPld xX7gQSnSRcUKd00E9agId0BkU6CHSOp+wmWyiDuevgpqgE26qiXxntoEHsQ+vfnsVXTI wd2w== X-Gm-Message-State: AJIora/aeRLGj/NuY1CuPF1/pAl1g/wzrn/mxr91eclBCG5czMY/22yp AqhkAtYLgSlq7rkLpgMKy6EN4QbxLcuCiJsaXmOkORaJkBDxWJIOofpHpndE9k2WxaT5q/MinZ/ vA50JLzyHF1IQbM2uKkjCZHhBxcJOPg== X-Received: by 2002:a17:907:97d3:b0:726:a5db:3a3a with SMTP id js19-20020a17090797d300b00726a5db3a3amr31901620ejc.654.1656978817608; Mon, 04 Jul 2022 16:53:37 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vFe2H68+oYApHG5+hzKSLtMfMOGP5EBP4k0pViWhfZyTPcr2yfIuXpyPMjqxuAzW9XP/mOPh7HPGmBYB06fsI= X-Received: by 2002:a17:907:97d3:b0:726:a5db:3a3a with SMTP id js19-20020a17090797d300b00726a5db3a3amr31901607ejc.654.1656978817361; Mon, 04 Jul 2022 16:53:37 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: =?UTF-8?B?UGF3ZcWCIFBvxYJhd3NraQ==?= Date: Tue, 5 Jul 2022 01:53:26 +0200 Message-ID: Subject: Re: [PATCH v1 1/1] UefiCpuPkg: Coding style bug fix To: "Ni, Ray" Cc: "devel@edk2.groups.io" , "Dong, Eric" , "Kumar, Rahul1" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ppolawsk@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000cf3d6005e303712c" --000000000000cf3d6005e303712c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Ray, Thank you for the suggestion. I will update the patchset and send version 2 soon. Best regards, Pawel On Fri, Jun 24, 2022 at 11:22 AM Ni, Ray wrote: > How about PlatformInformationRecord2? It also matches to the parameter > used in PPI header file. > > > -----Original Message----- > > From: Pawe=C5=82 Po=C5=82awski > > Sent: Friday, June 24, 2022 6:58 AM > > To: devel@edk2.groups.io > > Cc: Dong, Eric ; Ni, Ray ; > Kumar, Rahul1 > > Subject: [PATCH v1 1/1] UefiCpuPkg: Coding style bug fix > > > > Local variable name overlaped with function name. > > Variable name has been updated to remove name duplication. > > > > Cc: Eric Dong > > Cc: Ray Ni > > Cc: Rahul Kumar > > > > Signed-off-by: Pawe=C5=82 Po=C5=82awski > > --- > > UefiCpuPkg/CpuMpPei/CpuBist.c | 40 ++++++++++---------- > > 1 file changed, 20 insertions(+), 20 deletions(-) > > > > diff --git a/UefiCpuPkg/CpuMpPei/CpuBist.c > b/UefiCpuPkg/CpuMpPei/CpuBist.c > > index 7dc93cd784d4..179063e0d105 100644 > > --- a/UefiCpuPkg/CpuMpPei/CpuBist.c > > +++ b/UefiCpuPkg/CpuMpPei/CpuBist.c > > @@ -91,7 +91,7 @@ GetBistInfoFromPpi ( > > { > > > > EFI_STATUS Status; > > > > EFI_SEC_PLATFORM_INFORMATION2_PPI *SecPlatformInformation2Ppi; > > > > - EFI_SEC_PLATFORM_INFORMATION_RECORD2 *SecPlatformInformation2; > > > > + EFI_SEC_PLATFORM_INFORMATION_RECORD2 *SecPlatformInformation2Rec2; > > > > UINT64 InformationSize; > > > > > > > > Status =3D PeiServicesLocatePpi ( > > > > @@ -108,17 +108,17 @@ GetBistInfoFromPpi ( > > // > > > > // Get the size of the sec platform information2(BSP/APs' BIST dat= a) > > > > // > > > > - InformationSize =3D 0; > > > > - SecPlatformInformation2 =3D NULL; > > > > - Status =3D > SecPlatformInformation2Ppi->PlatformInformation2 ( > > > > - PeiService= s, > > > > - > &InformationSize, > > > > - > SecPlatformInformation2 > > > > - ); > > > > + InformationSize =3D 0; > > > > + SecPlatformInformation2Rec2 =3D NULL; > > > > + Status =3D > SecPlatformInformation2Ppi->PlatformInformation2 ( > > > > + > PeiServices, > > > > + > &InformationSize, > > > > + > SecPlatformInformation2Rec2 > > > > + ); > > > > if (Status =3D=3D EFI_BUFFER_TOO_SMALL) { > > > > Status =3D PeiServicesAllocatePool ( > > > > (UINTN)InformationSize, > > > > - (VOID **)&SecPlatformInformation2 > > > > + (VOID **)&SecPlatformInformation2Rec2 > > > > ); > > > > if (Status =3D=3D EFI_SUCCESS) { > > > > // > > > > @@ -127,10 +127,10 @@ GetBistInfoFromPpi ( > > Status =3D SecPlatformInformation2Ppi->PlatformInformation2 ( > > > > PeiServices, > > > > &InformationSize, > > > > - SecPlatformInformation2 > > > > + > SecPlatformInformation2Rec2 > > > > ); > > > > if (Status =3D=3D EFI_SUCCESS) { > > > > - *BistInformationData =3D SecPlatformInformation2; > > > > + *BistInformationData =3D SecPlatformInformation2Rec2; > > > > if (BistInformationSize !=3D NULL) { > > > > *BistInformationSize =3D InformationSize; > > > > } > > > > @@ -160,7 +160,7 @@ CollectBistDataFromPpi ( > > { > > > > EFI_STATUS Status; > > > > EFI_PEI_PPI_DESCRIPTOR *SecInformationDescriptor; > > > > - EFI_SEC_PLATFORM_INFORMATION_RECORD2 *SecPlatformInformation2; > > > > + EFI_SEC_PLATFORM_INFORMATION_RECORD2 *SecPlatformInformation2Rec2; > > > > EFI_SEC_PLATFORM_INFORMATION_RECORD *SecPlatformInformation; > > > > UINTN NumberOfData; > > > > EFI_SEC_PLATFORM_INFORMATION_CPU *CpuInstance; > > > > @@ -186,10 +186,10 @@ CollectBistDataFromPpi ( > > ASSERT_EFI_ERROR (Status); > > > > PlatformInformationRecord2->NumberOfCpus =3D (UINT32)NumberOfProcess= ors; > > > > > > > > - SecPlatformInformation2 =3D NULL; > > > > - SecPlatformInformation =3D NULL; > > > > - NumberOfData =3D 0; > > > > - CpuInstance =3D NULL; > > > > + SecPlatformInformation2Rec2 =3D NULL; > > > > + SecPlatformInformation =3D NULL; > > > > + NumberOfData =3D 0; > > > > + CpuInstance =3D NULL; > > > > // > > > > // Get BIST information from Sec Platform Information2 Ppi firstly > > > > // > > > > @@ -197,15 +197,15 @@ CollectBistDataFromPpi ( > > PeiServices, > > > > &gEfiSecPlatformInformation2PpiGuid, > > > > &SecInformationDescriptor, > > > > - (VOID *)&SecPlatformInformation2, > > > > + (VOID *)&SecPlatformInformation2Rec2, > > > > NULL > > > > ); > > > > if (Status =3D=3D EFI_SUCCESS) { > > > > // > > > > // Sec Platform Information2 PPI includes BSP/APs' BIST informatio= n > > > > // > > > > - NumberOfData =3D SecPlatformInformation2->NumberOfCpus; > > > > - CpuInstance =3D SecPlatformInformation2->CpuInstance; > > > > + NumberOfData =3D SecPlatformInformation2Rec2->NumberOfCpus; > > > > + CpuInstance =3D SecPlatformInformation2Rec2->CpuInstance; > > > > } else { > > > > // > > > > // Otherwise, get BIST information from Sec Platform Information P= pi > > > > @@ -274,7 +274,7 @@ CollectBistDataFromPpi ( > > (UINTN)BistInformationSize > > > > ); > > > > > > > > - if (SecPlatformInformation2 !=3D NULL) { > > > > + if (SecPlatformInformation2Rec2 !=3D NULL) { > > > > if (NumberOfData < NumberOfProcessors) { > > > > // > > > > // Reinstall SecPlatformInformation2 PPI to include new BIST > information > > > > -- > > 2.34.3 > > --=20 Pawe=C5=82 Po=C5=82awski Red Hat Virtualization ppolawsk@redhat.com @RedHat Red Hat Red Hat --000000000000cf3d6005e303712c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Ray,

Thank you for the su= ggestion.
I will update the patchset and send version 2 soon.

Best regards,
Pawel

On Fri, Jun 24= , 2022 at 11:22 AM Ni, Ray <ray.ni@i= ntel.com> wrote:
How about PlatformInformationRecord2? It also matches to the parame= ter used in PPI header file.

> -----Original Message-----
> From: Pawe=C5=82 Po=C5=82awski <ppolawsk@redhat.com>
> Sent: Friday, June 24, 2022 6:58 AM
> To: devel@ed= k2.groups.io
> Cc: Dong, Eric <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Kumar, Rahul1 <rahul1.kumar@intel.c= om>
> Subject: [PATCH v1 1/1] UefiCpuPkg: Coding style bug fix
>
> Local variable name overlaped with function name.
> Variable name has been updated to remove name duplication.
>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <r= ay.ni@intel.com>
> Cc: Rahul Kumar <rahul1.kumar@intel.com>
>
> Signed-off-by: Pawe=C5=82 Po=C5=82awski <ppolawsk@redhat.com>
> ---
>=C2=A0 UefiCpuPkg/CpuMpPei/CpuBist.c | 40 ++++++++++----------
>=C2=A0 1 file changed, 20 insertions(+), 20 deletions(-)
>
> diff --git a/UefiCpuPkg/CpuMpPei/CpuBist.c b/UefiCpuPkg/CpuMpPei/CpuBi= st.c
> index 7dc93cd784d4..179063e0d105 100644
> --- a/UefiCpuPkg/CpuMpPei/CpuBist.c
> +++ b/UefiCpuPkg/CpuMpPei/CpuBist.c
> @@ -91,7 +91,7 @@ GetBistInfoFromPpi (
>=C2=A0 {
>
>=C2=A0 =C2=A0 EFI_STATUS=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Status;
>
>=C2=A0 =C2=A0 EFI_SEC_PLATFORM_INFORMATION2_PPI=C2=A0 =C2=A0 =C2=A0*Sec= PlatformInformation2Ppi;
>
> -=C2=A0 EFI_SEC_PLATFORM_INFORMATION_RECORD2=C2=A0 *SecPlatformInforma= tion2;
>
> +=C2=A0 EFI_SEC_PLATFORM_INFORMATION_RECORD2=C2=A0 *SecPlatformInforma= tion2Rec2;
>
>=C2=A0 =C2=A0 UINT64=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 InformationS= ize;
>
>
>
>=C2=A0 =C2=A0 Status =3D PeiServicesLocatePpi (
>
> @@ -108,17 +108,17 @@ GetBistInfoFromPpi (
>=C2=A0 =C2=A0 =C2=A0 //
>
>=C2=A0 =C2=A0 =C2=A0 // Get the size of the sec platform information2(B= SP/APs' BIST data)
>
>=C2=A0 =C2=A0 =C2=A0 //
>
> -=C2=A0 =C2=A0 InformationSize=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=3D 0;=
>
> -=C2=A0 =C2=A0 SecPlatformInformation2 =3D NULL;
>
> -=C2=A0 =C2=A0 Status=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =3D SecPlatformInformation2Ppi->PlatformInformation2 (
>
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 PeiServi= ces,
>
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 &Inf= ormationSize,
>
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 SecPlatf= ormInformation2
>
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 );
>
> +=C2=A0 =C2=A0 InformationSize=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0=3D 0;
>
> +=C2=A0 =C2=A0 SecPlatformInformation2Rec2 =3D NULL;
>
> +=C2=A0 =C2=A0 Status=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =3D SecPlatformInformation2Ppi->PlatformInfo= rmation2 (
>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 PeiServices,
>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 &InformationSize,
>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 SecPlatformInformation2Rec2
>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 );
>
>=C2=A0 =C2=A0 =C2=A0 if (Status =3D=3D EFI_BUFFER_TOO_SMALL) {
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 Status =3D PeiServicesAllocatePool (
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(U= INTN)InformationSize,
>
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(VOID *= *)&SecPlatformInformation2
>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(VOID *= *)&SecPlatformInformation2Rec2
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0);=
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 if (Status =3D=3D EFI_SUCCESS) {
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 //
>
> @@ -127,10 +127,10 @@ GetBistInfoFromPpi (
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Status =3D SecPlatformInformation2Pp= i->PlatformInformation2 (
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0PeiServices,
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&InformationSize,
>
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0SecPlatformInformation2
>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0SecPlatformInformation2Rec2
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0);
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (Status =3D=3D EFI_SUCCESS) {
>
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 *BistInformationData =3D SecPlatfo= rmInformation2;
>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 *BistInformationData =3D SecPlatfo= rmInformation2Rec2;
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (BistInformationSize !=3D = NULL) {
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 *BistInformationSize = =3D InformationSize;
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 }
>
> @@ -160,7 +160,7 @@ CollectBistDataFromPpi (
>=C2=A0 {
>
>=C2=A0 =C2=A0 EFI_STATUS=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Status;
>
>=C2=A0 =C2=A0 EFI_PEI_PPI_DESCRIPTOR=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 *SecInformationDescriptor;
>
> -=C2=A0 EFI_SEC_PLATFORM_INFORMATION_RECORD2=C2=A0 *SecPlatformInforma= tion2;
>
> +=C2=A0 EFI_SEC_PLATFORM_INFORMATION_RECORD2=C2=A0 *SecPlatformInforma= tion2Rec2;
>
>=C2=A0 =C2=A0 EFI_SEC_PLATFORM_INFORMATION_RECORD=C2=A0 =C2=A0*SecPlatf= ormInformation;
>
>=C2=A0 =C2=A0 UINTN=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0NumberOfD= ata;
>
>=C2=A0 =C2=A0 EFI_SEC_PLATFORM_INFORMATION_CPU=C2=A0 =C2=A0 =C2=A0 *Cpu= Instance;
>
> @@ -186,10 +186,10 @@ CollectBistDataFromPpi (
>=C2=A0 =C2=A0 ASSERT_EFI_ERROR (Status);
>
>=C2=A0 =C2=A0 PlatformInformationRecord2->NumberOfCpus =3D (UINT32)N= umberOfProcessors;
>
>
>
> -=C2=A0 SecPlatformInformation2 =3D NULL;
>
> -=C2=A0 SecPlatformInformation=C2=A0 =3D NULL;
>
> -=C2=A0 NumberOfData=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =3D 0; >
> -=C2=A0 CpuInstance=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=3D= NULL;
>
> +=C2=A0 SecPlatformInformation2Rec2 =3D NULL;
>
> +=C2=A0 SecPlatformInformation=C2=A0 =C2=A0 =C2=A0 =3D NULL;
>
> +=C2=A0 NumberOfData=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =3D 0;
>
> +=C2=A0 CpuInstance=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0=3D NULL;
>
>=C2=A0 =C2=A0 //
>
>=C2=A0 =C2=A0 // Get BIST information from Sec Platform Information2 Pp= i firstly
>
>=C2=A0 =C2=A0 //
>
> @@ -197,15 +197,15 @@ CollectBistDataFromPpi (
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0PeiServices,
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&gEfiSecPlat= formInformation2PpiGuid,
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&SecInformat= ionDescriptor,
>
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(VOID *)&SecPlatf= ormInformation2,
>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(VOID *)&SecPlatf= ormInformation2Rec2,
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0NULL
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0);
>
>=C2=A0 =C2=A0 if (Status =3D=3D EFI_SUCCESS) {
>
>=C2=A0 =C2=A0 =C2=A0 //
>
>=C2=A0 =C2=A0 =C2=A0 // Sec Platform Information2 PPI includes BSP/APs&= #39; BIST information
>
>=C2=A0 =C2=A0 =C2=A0 //
>
> -=C2=A0 =C2=A0 NumberOfData =3D SecPlatformInformation2->NumberOfCp= us;
>
> -=C2=A0 =C2=A0 CpuInstance=C2=A0 =3D SecPlatformInformation2->CpuIn= stance;
>
> +=C2=A0 =C2=A0 NumberOfData =3D SecPlatformInformation2Rec2->Number= OfCpus;
>
> +=C2=A0 =C2=A0 CpuInstance=C2=A0 =3D SecPlatformInformation2Rec2->C= puInstance;
>
>=C2=A0 =C2=A0 } else {
>
>=C2=A0 =C2=A0 =C2=A0 //
>
>=C2=A0 =C2=A0 =C2=A0 // Otherwise, get BIST information from Sec Platfo= rm Information Ppi
>
> @@ -274,7 +274,7 @@ CollectBistDataFromPpi (
>=C2=A0 =C2=A0 =C2=A0 (UINTN)BistInformationSize
>
>=C2=A0 =C2=A0 =C2=A0 );
>
>
>
> -=C2=A0 if (SecPlatformInformation2 !=3D NULL) {
>
> +=C2=A0 if (SecPlatformInformation2Rec2 !=3D NULL) {
>
>=C2=A0 =C2=A0 =C2=A0 if (NumberOfData < NumberOfProcessors) {
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 //
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 // Reinstall SecPlatformInformation2 PPI to= include new BIST information
>
> --
> 2.34.3



--

Pawe=C5=82 Po=C5=82awski

Red Hat Virtualization

ppolawsk@redhat.com=C2=A0 =C2=A0

@RedHat=C2=A0=C2=A0=C2= =A0Red Hat= =C2=A0=C2=A0Red Hat

--000000000000cf3d6005e303712c--