Hi Liming,

Thank you for the review.

Best regards,
Pawel

On Fri, Mar 10, 2023 at 3:31 AM gaoliming via groups.io <gaoliming=byosoft.com.cn@groups.io> wrote:
Pawel:
  The change in MdeModulePkg looks good to me. Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Pawe?
> Po?awski
> 发送时间: 2023年2月17日 21:02
> 收件人: devel@edk2.groups.io
> 主题: [edk2-devel] PATCH v3 0/3 Add xterm resize support to OVMF
>
> This set of patches adds xterm resize sequences support to OvmfPkg
> and ArmVirtPkg. This way firmware will be able to sent resize
> requests to user terminal (gnome-terminal, xterm, xfce4-terminal).
>
> To test this feature you can use a new configuration option:
> -fw_cfg name=opt/org.tianocore/PcdResizeXterm,string=1
>
> Laszlo Ersek (3):
>   MdeModulePkg: TerminalDxe: set xterm resolution on mode change
>   ArmVirtPkg: take PcdResizeXterm from the QEMU command line
>   OvmfPkg: take PcdResizeXterm from the QEMU command line
>
>  MdeModulePkg/MdeModulePkg.dec
> |  4 ++
>  ArmVirtPkg/ArmVirtQemu.dsc
> |  7 +++-
>  OvmfPkg/AmdSev/AmdSevX64.dsc
> |  6 ++-
>  OvmfPkg/CloudHv/CloudHvX64.dsc
> |  6 ++-
>  OvmfPkg/IntelTdx/IntelTdxX64.dsc
> |  6 ++-
>  OvmfPkg/Microvm/MicrovmX64.dsc
> |  6 ++-
>  OvmfPkg/OvmfPkgIa32.dsc
> |  6 ++-
>  OvmfPkg/OvmfPkgIa32X64.dsc
> |  6 ++-
>  OvmfPkg/OvmfPkgX64.dsc
> |  6 ++-
>  MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf        |
> 2 +
>  OvmfPkg/Library/TerminalPcdProducerLib/TerminalPcdProducerLib.inf | 33
> ++++++++++++++++
>  OvmfPkg/PlatformPei/PlatformPei.inf
> |  1 +
>  MdeModulePkg/Universal/Console/TerminalDxe/TerminalConOut.c
> | 29 ++++++++++++++
>  OvmfPkg/Library/TerminalPcdProducerLib/TerminalPcdProducerLib.c   |
> 41 ++++++++++++++++++++
>  14 files changed, 151 insertions(+), 8 deletions(-)
>  create mode 100644
> OvmfPkg/Library/TerminalPcdProducerLib/TerminalPcdProducerLib.inf
>  create mode 100644
> OvmfPkg/Library/TerminalPcdProducerLib/TerminalPcdProducerLib.c
>
> --
> 2.39.1
>
>
>
>
>










--

Paweł Poławski

Red Hat Virtualization

ppolawsk@redhat.com   

@RedHat   Red Hat  Red Hat