From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.101703.1679666238523870961 for ; Fri, 24 Mar 2023 06:57:19 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=gkKBX/WL; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: ppolawsk@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679666237; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oohsvKQYovE6ybz4P9we/wIPWN+y9LNlhzmm3CbeJNU=; b=gkKBX/WLI1lk45soIKxKGlLnTwG4PuiAq/Bnka8cdFeuBmZGFqpv4pX/ivxVv2YRmq1S8F UIuQEEIHNafBGDmQ//tUqYbL3Sivb5dIm247hxmgQ46zbTeqxvayhC5mbYaPqm7WZRxgjm imq5A/hqpShwlwb7/vgxuWvMYeGvTDw= Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-660-6ZKE0aryPVqQCebUKtPWnA-1; Fri, 24 Mar 2023 09:57:15 -0400 X-MC-Unique: 6ZKE0aryPVqQCebUKtPWnA-1 Received: by mail-vs1-f71.google.com with SMTP id t22-20020a67d916000000b00425d954c65fso480576vsj.21 for ; Fri, 24 Mar 2023 06:57:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679666234; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oohsvKQYovE6ybz4P9we/wIPWN+y9LNlhzmm3CbeJNU=; b=YoZBAC50yljNTXWbbKap1/mG7WAqRDHnt+7yLFy334UBY8ibfNerbdwj4ANrH/9B45 soxJ4PArpq0NYrgyZoR1ET0o8t6e6+KeXE7FJY5wgHLelIXXALTEFyGxpcZa5Hyf2orm Dx9tqYuHVystS8C+18sd20Vij7+BV7iYKDdQ3NFPqWHUxepRInW+fVFrHEta0fvzhkYa mn78FjTsSkvRoRzrXG0Fgkcb6oxok0SddzXh2QVE/gHvIYauskvjoWwE0tAye4NH6ZjX Y4NyeHBcMGkw0dlv/iacJLtgRkCtHK8bYGyaVA530vhtxB/8EWehYv2bMMxvcTw49o5f cGqA== X-Gm-Message-State: AAQBX9eNE3Udwoh+NRzo3ANXSdqMpCURZf6ggcD+LRiv1KhCLWrFFrpv 9Nfoe8nAQRT7bFcUtJ6WoQSdOvKsMrJ1A8nxOqOZIFpcdZkO6NhYy8nAEEl1wTLwxq2ZBuz7TxX AYA2qYWqtLygsM8cs+9HpdYQm8NFeAhqfMoRNfw== X-Received: by 2002:a05:6130:215:b0:688:d612:2024 with SMTP id s21-20020a056130021500b00688d6122024mr1822585uac.2.1679666234534; Fri, 24 Mar 2023 06:57:14 -0700 (PDT) X-Google-Smtp-Source: AKy350bpVNzUYorCdKmfJV+Kg/sAcsfvRp9XmLPPDvhcld+ldYRdkwCicnVnqHemsgtcB6s71s+zG9FLs8eEZEaReSY= X-Received: by 2002:a05:6130:215:b0:688:d612:2024 with SMTP id s21-20020a056130021500b00688d6122024mr1822575uac.2.1679666234152; Fri, 24 Mar 2023 06:57:14 -0700 (PDT) MIME-Version: 1.0 References: <009501d952f8$705647d0$5102d770$@byosoft.com.cn> In-Reply-To: <009501d952f8$705647d0$5102d770$@byosoft.com.cn> From: =?UTF-8?B?UGF3ZcWCIFBvxYJhd3NraQ==?= Date: Fri, 24 Mar 2023 14:57:03 +0100 Message-ID: Subject: Re: [edk2-devel] PATCH v3 0/3 Add xterm resize support to OVMF To: devel@edk2.groups.io, gaoliming@byosoft.com.cn X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="0000000000003a6cae05f7a5c510" --0000000000003a6cae05f7a5c510 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Liming, Thank you for the review. Best regards, Pawel On Fri, Mar 10, 2023 at 3:31=E2=80=AFAM gaoliming via groups.io wrote: > Pawel: > The change in MdeModulePkg looks good to me. Reviewed-by: Liming Gao < > gaoliming@byosoft.com.cn> > > Thanks > Liming > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io =E4=BB=A3=E8=A1=A8 Pawe? > > Po?awski > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2023=E5=B9=B42=E6=9C=8817=E6=97= =A5 21:02 > > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io > > =E4=B8=BB=E9=A2=98: [edk2-devel] PATCH v3 0/3 Add xterm resize support = to OVMF > > > > This set of patches adds xterm resize sequences support to OvmfPkg > > and ArmVirtPkg. This way firmware will be able to sent resize > > requests to user terminal (gnome-terminal, xterm, xfce4-terminal). > > > > To test this feature you can use a new configuration option: > > -fw_cfg name=3Dopt/org.tianocore/PcdResizeXterm,string=3D1 > > > > Laszlo Ersek (3): > > MdeModulePkg: TerminalDxe: set xterm resolution on mode change > > ArmVirtPkg: take PcdResizeXterm from the QEMU command line > > OvmfPkg: take PcdResizeXterm from the QEMU command line > > > > MdeModulePkg/MdeModulePkg.dec > > | 4 ++ > > ArmVirtPkg/ArmVirtQemu.dsc > > | 7 +++- > > OvmfPkg/AmdSev/AmdSevX64.dsc > > | 6 ++- > > OvmfPkg/CloudHv/CloudHvX64.dsc > > | 6 ++- > > OvmfPkg/IntelTdx/IntelTdxX64.dsc > > | 6 ++- > > OvmfPkg/Microvm/MicrovmX64.dsc > > | 6 ++- > > OvmfPkg/OvmfPkgIa32.dsc > > | 6 ++- > > OvmfPkg/OvmfPkgIa32X64.dsc > > | 6 ++- > > OvmfPkg/OvmfPkgX64.dsc > > | 6 ++- > > MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf | > > 2 + > > OvmfPkg/Library/TerminalPcdProducerLib/TerminalPcdProducerLib.inf | 33 > > ++++++++++++++++ > > OvmfPkg/PlatformPei/PlatformPei.inf > > | 1 + > > MdeModulePkg/Universal/Console/TerminalDxe/TerminalConOut.c > > | 29 ++++++++++++++ > > OvmfPkg/Library/TerminalPcdProducerLib/TerminalPcdProducerLib.c | > > 41 ++++++++++++++++++++ > > 14 files changed, 151 insertions(+), 8 deletions(-) > > create mode 100644 > > OvmfPkg/Library/TerminalPcdProducerLib/TerminalPcdProducerLib.inf > > create mode 100644 > > OvmfPkg/Library/TerminalPcdProducerLib/TerminalPcdProducerLib.c > > > > -- > > 2.39.1 > > > > > > > > > > > > > > > >=20 > > > --=20 Pawe=C5=82 Po=C5=82awski Red Hat Virtualization ppolawsk@redhat.com @RedHat Red Hat Red Hat --0000000000003a6cae05f7a5c510 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Liming,

Thank you for the= review.

Best regards,
Pawel

On= Fri, Mar 10, 2023 at 3:31=E2=80=AFAM gaoliming via groups.io <gaoliming=3Dbyosoft.com.cn@groups.io> wrote:
Pawel:
=C2=A0 The change in MdeModulePkg looks good to me. Reviewed-by: Liming Gao= <gaolimin= g@byosoft.com.cn>

Thanks
Liming
> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6-----
> =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io <devel@edk2.groups.io> =E4=BB=A3=E8=A1= =A8 Pawe?
> Po?awski
> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2023=E5=B9=B42=E6=9C=8817=E6=97= =A5 21:02
> =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io
> =E4=B8=BB=E9=A2=98: [edk2-devel] PATCH v3 0/3 Add xterm resize support= to OVMF
>
> This set of patches adds xterm resize sequences support to OvmfPkg
> and ArmVirtPkg. This way firmware will be able to sent resize
> requests to user terminal (gnome-terminal, xterm, xfce4-terminal).
>
> To test this feature you can use a new configuration option:
> -fw_cfg name=3Dopt/org.tianocore/PcdResizeXterm,string=3D1
>
> Laszlo Ersek (3):
>=C2=A0 =C2=A0MdeModulePkg: TerminalDxe: set xterm resolution on mode ch= ange
>=C2=A0 =C2=A0ArmVirtPkg: take PcdResizeXterm from the QEMU command line=
>=C2=A0 =C2=A0OvmfPkg: take PcdResizeXterm from the QEMU command line >
>=C2=A0 MdeModulePkg/MdeModulePkg.dec
> |=C2=A0 4 ++
>=C2=A0 ArmVirtPkg/ArmVirtQemu.dsc
> |=C2=A0 7 +++-
>=C2=A0 OvmfPkg/AmdSev/AmdSevX64.dsc
> |=C2=A0 6 ++-
>=C2=A0 OvmfPkg/CloudHv/CloudHvX64.dsc
> |=C2=A0 6 ++-
>=C2=A0 OvmfPkg/IntelTdx/IntelTdxX64.dsc
> |=C2=A0 6 ++-
>=C2=A0 OvmfPkg/Microvm/MicrovmX64.dsc
> |=C2=A0 6 ++-
>=C2=A0 OvmfPkg/OvmfPkgIa32.dsc
> |=C2=A0 6 ++-
>=C2=A0 OvmfPkg/OvmfPkgIa32X64.dsc
> |=C2=A0 6 ++-
>=C2=A0 OvmfPkg/OvmfPkgX64.dsc
> |=C2=A0 6 ++-
>=C2=A0 MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf=C2=A0= =C2=A0 =C2=A0 =C2=A0 |
> 2 +
>=C2=A0 OvmfPkg/Library/TerminalPcdProducerLib/TerminalPcdProducerLib.in= f | 33
> ++++++++++++++++
>=C2=A0 OvmfPkg/PlatformPei/PlatformPei.inf
> |=C2=A0 1 +
>=C2=A0 MdeModulePkg/Universal/Console/TerminalDxe/TerminalConOut.c
> | 29 ++++++++++++++
>=C2=A0 OvmfPkg/Library/TerminalPcdProducerLib/TerminalPcdProducerLib.c= =C2=A0 =C2=A0|
> 41 ++++++++++++++++++++
>=C2=A0 14 files changed, 151 insertions(+), 8 deletions(-)
>=C2=A0 create mode 100644
> OvmfPkg/Library/TerminalPcdProducerLib/TerminalPcdProducerLib.inf
>=C2=A0 create mode 100644
> OvmfPkg/Library/TerminalPcdProducerLib/TerminalPcdProducerLib.c
>
> --
> 2.39.1
>
>
>
>
>










--

<= span>Pawe=C5=82 Po=C5=82awski

Red Hat Virtualization

ppolawsk@= redhat.com=C2=A0 =C2=A0

@RedHat=C2=A0=C2=A0=C2=A0Red Hat=C2=A0=C2=A0Red Hat
=
--0000000000003a6cae05f7a5c510--