From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) by mx.groups.io with SMTP id smtpd.web10.9480.1626088670035559073 for ; Mon, 12 Jul 2021 04:17:50 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@solid-run-com.20150623.gappssmtp.com header.s=20150623 header.b=XMYQgi/q; spf=pass (domain: solid-run.com, ip: 209.85.208.41, mailfrom: jon@solid-run.com) Received: by mail-ed1-f41.google.com with SMTP id ec55so2572807edb.1 for ; Mon, 12 Jul 2021 04:17:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=solid-run-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=7MBIHPBgJaLzCuHDRUVa0cMW1gJYyNTkXNLj6fmjQSo=; b=XMYQgi/qKB196LaQfhkjyLAeqRec1lkuaa5lqL5hOsXjU4C+dCOzScAl4NluS5KcMS p5YEe6q4zbyW7SkZlEpIt+sfQDX/ud51WwFwFRwLq8RE5997+lbmWOq7ehJhgMjU9w+U 6k67BDvGw5YKIDDdKYG6pNqmHDI0VkH3RG/qxE99KDTAMQbX0IJAj/WidT5ds/FRZVgt 3S84w0SF4WdjTONPiANlKTHItiKsNdIaeHnbN7YJn7yoBmj/n3wTTo0xSG7mgDCZJi0J wyI0GHMYeZk3HJKPBjjj4b7LpZCfetqo+nScYwFmPfqLwj5CFqnqQh7o+3lpl8lSi4D/ qk0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=7MBIHPBgJaLzCuHDRUVa0cMW1gJYyNTkXNLj6fmjQSo=; b=X2jw0MmGT46n0jDI+GVZ1RZj4/5M4NpAAUuzIYvT1uHET9Lg3YNm0I8hH4nkXbeRwG 8xszl3+Lxk/ryE6mJSlSuuCfQle/UHgWfeM71T6SN3/N1Jfs5reG0dKG5S0WsQW8Wxb/ M9NLZfU1LPWgHMRdp+WiE2vymmp/DDUvrISbpEK063WNUk7T6LrouAJgws1n3But4fPV ujBz7QM501QP8K8JC2t04woPBWLuCmnSgW6QSS305jU+O+jEfO4R2WQouxdYLVoK3zO5 7zJYaPFG1hNSXbGiAABhz7CjasjUd0aTh7bf5wRlzDYqvkZCG9r618q6o0Cv/hROWihh Uy8Q== X-Gm-Message-State: AOAM530pRgls4PgmU5JzQAli1yw2tBoN6iRlEzAZ7RDUboskka686Ex3 SEG8V7R+z6tkxHePIOAx9SUMEdzZNKbJU/K6qLvnEA== X-Google-Smtp-Source: ABdhPJxTN4RWnffR5ZKcqlqGBBnGII7OaTmn7k7NlG9Ar3bh5NVA6P4n8v8HqIXSZ0P2QQWXWwbPp1j6AbWnehQ9TX0= X-Received: by 2002:a05:6402:312e:: with SMTP id dd14mr733716edb.33.1626088668341; Mon, 12 Jul 2021 04:17:48 -0700 (PDT) MIME-Version: 1.0 References: <20210613181631.2247221-1-mw@semihalf.com> <20210614215540.u2y4oc2s4cvs6kxw@leviathan> In-Reply-To: From: "Jon Nettleton" Date: Mon, 12 Jul 2021 13:17:10 +0200 Message-ID: Subject: Re: [edk2-platforms PATCH 0/4] ACPI MDIO support for Marvell SoCs To: Marcin Wojtas Cc: Leif Lindholm , Ard Biesheuvel , edk2-devel-groups-io , Grzegorz Jaszczyk , Grzegorz Bernacki , upstream@semihalf.com, Samer El-Haj-Mahmoud Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Jul 12, 2021 at 12:52 PM Marcin Wojtas wrote: > > Hi, > > wt., 29 cze 2021 o 16:17 Marcin Wojtas napisa=C5=82(a): > > > > Hi Leif, > > > > pon., 14 cze 2021 o 23:55 Leif Lindholm napisa=C5= =82(a): > > > > > > Hi Marcin, > > > > > > On Sun, Jun 13, 2021 at 20:16:27 +0200, Marcin Wojtas wrote: > > > > Hi, > > > > > > > > The MDIO ACPI binding has been established and merged to the > > > > Linux tree, > > > > > > Congratulations! :) > > > > > > Is FreeBSD expected to follow suit? > > > > There's no driver yet, but once it's finally created I will make sure > > it supports ACPI properly. > > > > > > > > > hence it is now possible to update the ACPI > > > > description of the platforms that base on the Marvell SoCs. > > > > > > > > For convenience, the code is exposed in the public github branch: > > > > https://github.com/semihalf-wojtas-marcin/edk2-platforms/commits/ac= pi-mdio-r20210613 > > > > There is also MacchiatoBin firmware binary avaialable for testing: > > > > https://drive.google.com/file/d/1eigP_aeM4wYQpEaLAlQzs3IN_w1-kQr0 > > > > > > > > I'm looking forward to the comments or remarks. > > > > > > The patches themselves look straightforward enough. > > > I *would* prefer some tested-by, for these sources rather than the > > > binary, before merging though. > > > > > > > I have some our patches queued, that are blocked by this patchset. In > > case no time is found for external testers - if this may help to get > > it pushed through, please see below logs from the next-20210628 tag > > and unchanged firmware. All network ports of MacchiatoBin and > > CN913x-DB work properly, with full 1G/10G PHY support via X/MDIO > > interfaces: > > > > MacchiatoBin > > # uname -a > > Linux buildroot 5.13.0-rc7-next-20210628 #6 SMP PREEMPT Tue Jun 29 > > 09:14:07 CEST 2021 aarch64 GNU/Linux > > # dmesg | grep MRVL0101 > > [ 1.829659] mv88x3340 MRVL0101:00-mii:00: Firmware version 0.3.3.0 > > [ 1.839622] mv88x3340 MRVL0101:00-mii:08: Firmware version 0.3.3.0 > > [ 2.748351] mvpp2 MRVL0110:00 eth1: PHY [MRVL0101:00-mii:00] driver > > [mv88x3340] (irq=3DPOLL) > > [ 2.767479] mvpp2 MRVL0110:01 eth2: PHY [MRVL0101:00-mii:08] driver > > [mv88x3340] (irq=3DPOLL) > > # dmesg | grep MRVL0100 > > [ 2.919424] mvpp2 MRVL0110:01 eth3: PHY [MRVL0100:00-mii:00] driver > > [Marvell 88E1510] (irq=3DPOLL) > > # dmesg | grep mvpp2 > > [...] > > [ 2.748351] mvpp2 MRVL0110:00 eth1: PHY [MRVL0101:00-mii:00] driver > > [mv88x3340] (irq=3DPOLL) > > [ 2.756701] mvpp2 MRVL0110:00 eth1: configuring for phy/10gbase-r li= nk mode > > [ 2.767479] mvpp2 MRVL0110:01 eth2: PHY [MRVL0101:00-mii:08] driver > > [mv88x3340] (irq=3DPOLL) > > [ 2.775834] mvpp2 MRVL0110:01 eth2: configuring for phy/10gbase-r li= nk mode > > [ 2.919424] mvpp2 MRVL0110:01 eth3: PHY [MRVL0100:00-mii:00] driver > > [Marvell 88E1510] (irq=3DPOLL) > > [ 2.928285] mvpp2 MRVL0110:01 eth3: configuring for phy/sgmii link m= ode > > [ 2.936351] mvpp2 MRVL0110:01 eth4: configuring for > > inband/2500base-x link mode > > [ 5.987259] mvpp2 MRVL0110:01 eth3: Link is Up - 1Gbps/Full - flow > > control off > > # > > > > CN913x-DB > > # uname -a > > Linux buildroot 5.13.0-rc7-next-20210628 #6 SMP PREEMPT Tue Jun 29 > > 09:14:07 CEST 2021 aarch64 GNU/Linux > > # dmesg | grep MRVL0100 > > [ 2.621201] mvpp2 MRVL0110:00 eth2: PHY [MRVL0100:00-mii:00] driver > > [Marvell 88E1510] (irq=3DPOLL) > > [ 2.741199] mvpp2 MRVL0110:00 eth3: PHY [MRVL0100:00-mii:01] driver > > [Marvell 88E1510] (irq=3DPOLL) > > # dmesg | grep mvpp2 > > [...] > > [ 2.544917] mvpp2 MRVL0110:00 eth1: configuring for > > inband/10gbase-r link mode > > [ 2.552480] mvpp2 MRVL0110:00 eth1: Link is Up - 10Gbps/Full - flow > > control rx > > [ 2.621201] mvpp2 MRVL0110:00 eth2: PHY [MRVL0100:00-mii:00] driver > > [Marvell 88E1510] (irq=3DPOLL) > > [ 2.630060] mvpp2 MRVL0110:00 eth2: configuring for phy/rgmii-id lin= k mode > > [ 2.741199] mvpp2 MRVL0110:00 eth3: PHY [MRVL0100:00-mii:01] driver > > [Marvell 88E1510] (irq=3DPOLL) > > [ 2.750056] mvpp2 MRVL0110:00 eth3: configuring for phy/rgmii-id lin= k mode > > [ 2.810169] mvpp2 MRVL0110:01 eth4: configuring for > > inband/10gbase-r link mode > > [ 2.817471] mvpp2 MRVL0110:01 eth4: Link is Up - 10Gbps/Full - flow > > control rx > > [ 5.693231] mvpp2 MRVL0110:00 eth2: Link is Up - 1Gbps/Full - flow > > control off > > [ 10.840942] mvpp2 MRVL0110:00 eth1: Link is Down > > [ 10.864124] mvpp2 MRVL0110:01 eth4: Link is Down > > # > > > > Both platforms were have been additionally tested by Greg, do you have > any comments/objections to merging this patchset? > > Thanks, > Marcin You can add my Tested-by as well. Finally got time over the weekend to verify on all my Marvell platforms this effects. -Jon